Patchwork [1/2] systemd-compat-units: do not create runlevel command

login
register
mail settings
Submitter rongqing.li@windriver.com
Date Sept. 4, 2013, 6:56 a.m.
Message ID <c4888f2e74ac1e1a20ea6907d982f208a0bd556d.1378276893.git.rongqing.li@windriver.com>
Download mbox | patch
Permalink /patch/57325/
State Accepted
Commit adc11d60fd4b555198d6653cd71eb1372e0b03a0
Headers show

Comments

rongqing.li@windriver.com - Sept. 4, 2013, 6:56 a.m.
From: "Roy.Li" <rongqing.li@windriver.com>

It seems strange that runlevel always returns 1, we should create
a runlevel link to systemctl if systemd is installed.

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
---
 meta/recipes-core/systemd/systemd-compat-units.bb |    5 -----
 1 file changed, 5 deletions(-)
rongqing.li@windriver.com - Sept. 4, 2013, 7 a.m.
On 09/04/2013 02:56 PM, rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> It seems strange that runlevel always returns 1, we should create
> a runlevel link to systemctl if systemd is installed.
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
>   meta/recipes-core/systemd/systemd-compat-units.bb |    5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
> index 9b4a8a4..c47c14b 100644
> --- a/meta/recipes-core/systemd/systemd-compat-units.bb
> +++ b/meta/recipes-core/systemd/systemd-compat-units.bb
> @@ -21,11 +21,6 @@ do_install() {
>   	install -m 0644 ${WORKDIR}/machineid.service ${D}${systemd_unitdir}/system
>   	ln -sf ../machineid.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
>   	ln -sf ../machineid.service ${D}${systemd_unitdir}/system/basic.target.wants/
> -
> -	# hack to make old style sysvinit postinsts succeed
> -	install -d ${D}${bindir}
> -	echo "echo 1" > ${D}${bindir}/runlevel
> -	chmod 0755 ${D}${bindir}/runlevel


In fact, I am not sure what they are fixing, if these codes are still using,
I will think other methods to make runlevel work

-Roy



>   }
>
>   SYSTEMD_DISABLED_SYSV_SERVICES = " \
>

Patch

diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
index 9b4a8a4..c47c14b 100644
--- a/meta/recipes-core/systemd/systemd-compat-units.bb
+++ b/meta/recipes-core/systemd/systemd-compat-units.bb
@@ -21,11 +21,6 @@  do_install() {
 	install -m 0644 ${WORKDIR}/machineid.service ${D}${systemd_unitdir}/system
 	ln -sf ../machineid.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
 	ln -sf ../machineid.service ${D}${systemd_unitdir}/system/basic.target.wants/
-
-	# hack to make old style sysvinit postinsts succeed
-	install -d ${D}${bindir}
-	echo "echo 1" > ${D}${bindir}/runlevel
-	chmod 0755 ${D}${bindir}/runlevel
 }
 
 SYSTEMD_DISABLED_SYSV_SERVICES = " \