Patchwork [meta-fsl-arm,1/3] packagegroup-core-directfb: Add Vivante GPU support

login
register
mail settings
Submitter Otavio Salvador
Date Sept. 3, 2013, 7:36 p.m.
Message ID <1378237001-9517-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/57317/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Sept. 3, 2013, 7:36 p.m.
Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
Daiane Angolini - Sept. 4, 2013, 12:06 p.m.
On Tue, Sep 3, 2013 at 4:36 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Tested-by: Daiane Angolini <daiane.angolini@freescale.com>

and it worked ;-)

But, you can add more information on commit log. Could you, please,
tell why you decided
to create a bbappend on packagegroup instead of directfb itself?

I'm sorry, I just remembered now why I asked about it yesterday and we
started a fight regarding
recompiling everything for every machine and all this stuf. The only
goal was tell you to add
your arguments on commit log =P




>  recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
>
> diff --git a/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend b/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
> new file mode 100644
> index 0000000..a95af53
> --- /dev/null
> +++ b/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
> @@ -0,0 +1,3 @@
> +# i.MX6 has DirectFB acceleration support, so add it
> +RDEPENDS_${PN}_append_mx6 = " libvivante-dfb-mx6"
> +PACKAGE_ARCH_mx6 = "${MACHINE_ARCH}"
> --
> 1.8.4.rc3
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Otavio Salvador - Sept. 4, 2013, 1:50 p.m.
On Wed, Sep 4, 2013 at 9:06 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Tue, Sep 3, 2013 at 4:36 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>
> Tested-by: Daiane Angolini <daiane.angolini@freescale.com>
>
> and it worked ;-)
>
> But, you can add more information on commit log. Could you, please,
> tell why you decided
> to create a bbappend on packagegroup instead of directfb itself?
>
> I'm sorry, I just remembered now why I asked about it yesterday and we
> started a fight regarding
> recompiling everything for every machine and all this stuf. The only
> goal was tell you to add
> your arguments on commit log =P

I changed it to:

commit 094fd3101510e57f8aad0b49c590333e84b43e51
Author: Otavio Salvador <otavio@ossystems.com.br>
Date:   Tue Sep 3 13:19:01 2013 -0300

    packagegroup-core-directfb: Add Vivante GPU support

    This allow for easy addition of DirectFB support in image; we opted to
    add this here to avoid forcing a 'directfb' to be machine specific.

    Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

please ack it and I push this version.
Daiane Angolini - Sept. 4, 2013, 1:51 p.m.
On Wed, Sep 4, 2013 at 10:50 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Sep 4, 2013 at 9:06 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> On Tue, Sep 3, 2013 at 4:36 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>
>> Tested-by: Daiane Angolini <daiane.angolini@freescale.com>
>>
>> and it worked ;-)
>>
>> But, you can add more information on commit log. Could you, please,
>> tell why you decided
>> to create a bbappend on packagegroup instead of directfb itself?
>>
>> I'm sorry, I just remembered now why I asked about it yesterday and we
>> started a fight regarding
>> recompiling everything for every machine and all this stuf. The only
>> goal was tell you to add
>> your arguments on commit log =P
>
> I changed it to:
>
> commit 094fd3101510e57f8aad0b49c590333e84b43e51
> Author: Otavio Salvador <otavio@ossystems.com.br>
> Date:   Tue Sep 3 13:19:01 2013 -0300
>
>     packagegroup-core-directfb: Add Vivante GPU support
>
>     This allow for easy addition of DirectFB support in image; we opted to
>     add this here to avoid forcing a 'directfb' to be machine specific.
>
>     Change-Id: I20ca9625a6b3cd7a54e8718ef012ed6717313ba5
>     Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> please ack it and I push this version.

Acked ;-)

Thanks <3

Patch

diff --git a/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend b/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
new file mode 100644
index 0000000..a95af53
--- /dev/null
+++ b/recipes-graphics/packagegroups/packagegroup-core-directfb.bbappend
@@ -0,0 +1,3 @@ 
+# i.MX6 has DirectFB acceleration support, so add it
+RDEPENDS_${PN}_append_mx6 = " libvivante-dfb-mx6"
+PACKAGE_ARCH_mx6 = "${MACHINE_ARCH}"