Patchwork [meta-oe] qt-creator: update to 2.8.1

login
register
mail settings
Submitter Jonathan Liu
Date Aug. 30, 2013, 12:55 a.m.
Message ID <1377824151-7538-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/57099/
State Accepted, archived
Headers show

Comments

Jonathan Liu - Aug. 30, 2013, 12:55 a.m.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 .../qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb}           | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta-oe/recipes-qt/qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb} (87%)
Martin Jansa - Aug. 30, 2013, 9:01 a.m.
On Fri, Aug 30, 2013 at 10:55:51AM +1000, Jonathan Liu wrote:
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  .../qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb}           | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>  rename meta-oe/recipes-qt/qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb} (87%)
> 
> diff --git a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> similarity index 87%
> rename from meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> rename to meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> index a95ad5a..21d5264 100644
> --- a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> +++ b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> @@ -7,8 +7,8 @@ LIC_FILES_CHKSUM = "file://LGPL_EXCEPTION.TXT;md5=eb6c371255e1262c55ae9b652a90b5
>  SECTION = "qt/app"
>  
>  SRC_URI = "http://download.qt-project.org/official_releases/qtcreator/2.8/${PV}/${BP}-src.tar.gz"
> -SRC_URI[md5sum] = "5aacdad4491b7dda9758a81384d8da79"
> -SRC_URI[sha256sum] = "7ac5d9a36c2f561f74d77378d4eae95a78c7752b323e1df924d6e895e99f45d2"
> +SRC_URI[md5sum] = "79ef6c6ece0c00035ef744c9d6e3bd3b"
> +SRC_URI[sha256sum] = "d5ae007a297a4288d0e95fd605edbfb8aee80f6788c7a6cfb9cb297f50c364b9"

Hi, does it fix build on arm?

One issue was missing cpuid.h
http://lists.openembedded.org/pipermail/openembedded-devel/2013-August/091952.html

and then there were some warning causing build failure with -Werror.

If yes, I'll happily replace my patch with this one :).
Jonathan Liu - Aug. 30, 2013, 10:37 a.m.
On 30/08/2013 7:01 PM, Martin Jansa wrote:
> On Fri, Aug 30, 2013 at 10:55:51AM +1000, Jonathan Liu wrote:
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>>   .../qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb}           | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>   rename meta-oe/recipes-qt/qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb} (87%)
>>
>> diff --git a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
>> similarity index 87%
>> rename from meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
>> rename to meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
>> index a95ad5a..21d5264 100644
>> --- a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
>> +++ b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
>> @@ -7,8 +7,8 @@ LIC_FILES_CHKSUM = "file://LGPL_EXCEPTION.TXT;md5=eb6c371255e1262c55ae9b652a90b5
>>   SECTION = "qt/app"
>>   
>>   SRC_URI = "http://download.qt-project.org/official_releases/qtcreator/2.8/${PV}/${BP}-src.tar.gz"
>> -SRC_URI[md5sum] = "5aacdad4491b7dda9758a81384d8da79"
>> -SRC_URI[sha256sum] = "7ac5d9a36c2f561f74d77378d4eae95a78c7752b323e1df924d6e895e99f45d2"
>> +SRC_URI[md5sum] = "79ef6c6ece0c00035ef744c9d6e3bd3b"
>> +SRC_URI[sha256sum] = "d5ae007a297a4288d0e95fd605edbfb8aee80f6788c7a6cfb9cb297f50c364b9"
> Hi, does it fix build on arm?
I tested for x86 target. I haven't tested on ARM. 
https://codereview.qt-project.org/#change,61264 hasn't been merged yet 
and I don't see any ARM build fixes in the logs between v2.8.0 and 
v2.8.1 so I am guessing compiling for ARM isn't fixed yet.
>
> One issue was missing cpuid.h
> http://lists.openembedded.org/pipermail/openembedded-devel/2013-August/091952.html
>
> and then there were some warning causing build failure with -Werror.
Is -Werror standard or added through a conf option?
>
> If yes, I'll happily replace my patch with this one :).
Regards,
Jonathan
Martin Jansa - Aug. 30, 2013, 10:54 a.m.
On Fri, Aug 30, 2013 at 08:37:38PM +1000, Jonathan Liu wrote:
> On 30/08/2013 7:01 PM, Martin Jansa wrote:
> > On Fri, Aug 30, 2013 at 10:55:51AM +1000, Jonathan Liu wrote:
> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> ---
> >>   .../qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb}           | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>   rename meta-oe/recipes-qt/qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb} (87%)
> >>
> >> diff --git a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> >> similarity index 87%
> >> rename from meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> >> rename to meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> >> index a95ad5a..21d5264 100644
> >> --- a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> >> +++ b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> >> @@ -7,8 +7,8 @@ LIC_FILES_CHKSUM = "file://LGPL_EXCEPTION.TXT;md5=eb6c371255e1262c55ae9b652a90b5
> >>   SECTION = "qt/app"
> >>   
> >>   SRC_URI = "http://download.qt-project.org/official_releases/qtcreator/2.8/${PV}/${BP}-src.tar.gz"
> >> -SRC_URI[md5sum] = "5aacdad4491b7dda9758a81384d8da79"
> >> -SRC_URI[sha256sum] = "7ac5d9a36c2f561f74d77378d4eae95a78c7752b323e1df924d6e895e99f45d2"
> >> +SRC_URI[md5sum] = "79ef6c6ece0c00035ef744c9d6e3bd3b"
> >> +SRC_URI[sha256sum] = "d5ae007a297a4288d0e95fd605edbfb8aee80f6788c7a6cfb9cb297f50c364b9"
> > Hi, does it fix build on arm?
> I tested for x86 target. I haven't tested on ARM. 
> https://codereview.qt-project.org/#change,61264 hasn't been merged yet 
> and I don't see any ARM build fixes in the logs between v2.8.0 and 
> v2.8.1 so I am guessing compiling for ARM isn't fixed yet.
> >
> > One issue was missing cpuid.h
> > http://lists.openembedded.org/pipermail/openembedded-devel/2013-August/091952.html
> >
> > and then there were some warning causing build failure with -Werror.
> Is -Werror standard or added through a conf option?

I haven't spent much time on this one so I don't know from where -Werror
was passed, but you can see the error in
http://logs.nslu2-linux.org/buildlogs/oe/oe-shr-core-branches/log.world.20130829_131018.log/min_failed/qt-creator

|
/home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/sysroots/qemuarm/usr/include/qt4/QtCore/qsharedpointer_impl.h:336:11:
error: 'product' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Martin Jansa - Sept. 4, 2013, 12:50 p.m.
On Fri, Aug 30, 2013 at 12:54:58PM +0200, Martin Jansa wrote:
> On Fri, Aug 30, 2013 at 08:37:38PM +1000, Jonathan Liu wrote:
> > On 30/08/2013 7:01 PM, Martin Jansa wrote:
> > > On Fri, Aug 30, 2013 at 10:55:51AM +1000, Jonathan Liu wrote:
> > >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> > >> ---
> > >>   .../qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb}           | 4 ++--
> > >>   1 file changed, 2 insertions(+), 2 deletions(-)
> > >>   rename meta-oe/recipes-qt/qt-creator/{qt-creator_2.8.0.bb => qt-creator_2.8.1.bb} (87%)
> > >>
> > >> diff --git a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> > >> similarity index 87%
> > >> rename from meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> > >> rename to meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> > >> index a95ad5a..21d5264 100644
> > >> --- a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
> > >> +++ b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
> > >> @@ -7,8 +7,8 @@ LIC_FILES_CHKSUM = "file://LGPL_EXCEPTION.TXT;md5=eb6c371255e1262c55ae9b652a90b5
> > >>   SECTION = "qt/app"
> > >>   
> > >>   SRC_URI = "http://download.qt-project.org/official_releases/qtcreator/2.8/${PV}/${BP}-src.tar.gz"
> > >> -SRC_URI[md5sum] = "5aacdad4491b7dda9758a81384d8da79"
> > >> -SRC_URI[sha256sum] = "7ac5d9a36c2f561f74d77378d4eae95a78c7752b323e1df924d6e895e99f45d2"
> > >> +SRC_URI[md5sum] = "79ef6c6ece0c00035ef744c9d6e3bd3b"
> > >> +SRC_URI[sha256sum] = "d5ae007a297a4288d0e95fd605edbfb8aee80f6788c7a6cfb9cb297f50c364b9"
> > > Hi, does it fix build on arm?
> > I tested for x86 target. I haven't tested on ARM. 
> > https://codereview.qt-project.org/#change,61264 hasn't been merged yet 
> > and I don't see any ARM build fixes in the logs between v2.8.0 and 
> > v2.8.1 so I am guessing compiling for ARM isn't fixed yet.
> > >
> > > One issue was missing cpuid.h
> > > http://lists.openembedded.org/pipermail/openembedded-devel/2013-August/091952.html
> > >
> > > and then there were some warning causing build failure with -Werror.
> > Is -Werror standard or added through a conf option?
> 
> I haven't spent much time on this one so I don't know from where -Werror
> was passed, but you can see the error in
> http://logs.nslu2-linux.org/buildlogs/oe/oe-shr-core-branches/log.world.20130829_131018.log/min_failed/qt-creator
> 
> |
> /home/jenkins/oe/shr-core-branches/shr-core/tmp-eglibc/sysroots/qemuarm/usr/include/qt4/QtCore/qsharedpointer_impl.h:336:11:
> error: 'product' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]

Both issues are still there with 2.8.1

Patch

diff --git a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
similarity index 87%
rename from meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
rename to meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
index a95ad5a..21d5264 100644
--- a/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.0.bb
+++ b/meta-oe/recipes-qt/qt-creator/qt-creator_2.8.1.bb
@@ -7,8 +7,8 @@  LIC_FILES_CHKSUM = "file://LGPL_EXCEPTION.TXT;md5=eb6c371255e1262c55ae9b652a90b5
 SECTION = "qt/app"
 
 SRC_URI = "http://download.qt-project.org/official_releases/qtcreator/2.8/${PV}/${BP}-src.tar.gz"
-SRC_URI[md5sum] = "5aacdad4491b7dda9758a81384d8da79"
-SRC_URI[sha256sum] = "7ac5d9a36c2f561f74d77378d4eae95a78c7752b323e1df924d6e895e99f45d2"
+SRC_URI[md5sum] = "79ef6c6ece0c00035ef744c9d6e3bd3b"
+SRC_URI[sha256sum] = "d5ae007a297a4288d0e95fd605edbfb8aee80f6788c7a6cfb9cb297f50c364b9"
 
 S = "${WORKDIR}/${BP}-src"