Patchwork [oe-core] qemuarma9: Update qemuarma9-standard.scc definition.

login
register
mail settings
Submitter Elvis Dowson
Date Aug. 29, 2013, 6:41 p.m.
Message ID <1377801711-4120-1-git-send-email-elvis.dowson@gmail.com>
Download mbox | patch
Permalink /patch/57075/
State Not Applicable
Headers show

Comments

Elvis Dowson - Aug. 29, 2013, 6:41 p.m.
This commit
- updates the KMACHINE definition to vexpress.
- updates the branch to qemuarma9.

Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
---
 meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Elvis Dowson - Aug. 29, 2013, 6:55 p.m.
On Aug 29, 2013, at 10:45 PM, Bruce Ashfield <bruce.ashfield@windriver.com> wrote:

> On 13-08-29 02:41 PM, Elvis Dowson wrote:
>> This commit
>> - updates the KMACHINE definition to vexpress.
>> - updates the branch to qemuarma9.
>> 
>> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
>> ---
>>  meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
>> index c71fe1c..83911ff 100644
>> --- a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
>> +++ b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
>> @@ -1,9 +1,9 @@
>> -define KMACHINE qemuarma9
>> +define KMACHINE vexpress
> 
> There's no reason to delete the old machine, they are all valid
> and additive. Think of them as aliases. You can have as many
> as you want :)

In the kernel, there is no qemuarma9 machine. The corresponding
kernel machine is vexpress .. I checked the kernel sources, .. 
correct me if I'm wrong, but I thought the intent of the KMACHINE
variable was to map to the correct machine defined in the kernel.

> 
>>  define KTYPE standard
>>  define KARCH arm
>> 
>>  include ktypes/standard/standard.scc
>> -branch arm-versatile-926ejs
>> +branch qemuarma9
> 
> There's no reason for a custom branch as well. Unless patches are
> being maintained that break compatibility with other boards.
> 


If we plan on having multiple arm architecture support (A8, A8, A15) to
QEMU, perhaps its better to rename this branch to qemuarm.

Best regards,

Elvis Dowson

Patch

diff --git a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
index c71fe1c..83911ff 100644
--- a/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
+++ b/meta/cfg/kernel-cache/bsp/qemuarma9/qemuarma9-standard.scc
@@ -1,9 +1,9 @@ 
-define KMACHINE qemuarma9
+define KMACHINE vexpress
 define KTYPE standard
 define KARCH arm
 
 include ktypes/standard/standard.scc
-branch arm-versatile-926ejs
+branch qemuarma9
 
 include qemuarma9.scc