Patchwork busybox: set default log buffer size to 64 at compile time

login
register
mail settings
Submitter Paul Eggleton
Date Aug. 28, 2013, 3:39 p.m.
Message ID <1377704359-5104-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/56835/
State Accepted
Commit 3095ee5154002134fac3fc1e4a8cfe5a5b2f70ca
Headers show

Comments

Paul Eggleton - Aug. 28, 2013, 3:39 p.m.
This provides a more reasonable log buffer size to avoid losing earlier
events, and 64K is not a problem for modern systems. When the buffer is
used on sysvinit-based systems, which it isn't by default, 64K is already
the runtime default size unless /etc/syslog-startup.conf is modified or
deleted, so this only really affects systems using systemd. This
completely removes the need for the busybox bbappend in meta-oe.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/recipes-core/busybox/busybox-1.21.1/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Khem Raj - Aug. 28, 2013, 4:08 p.m.
On Aug 28, 2013, at 8:39 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> This provides a more reasonable log buffer size to avoid losing earlier
> events, and 64K is not a problem for modern systems. When the buffer is
> used on sysvinit-based systems, which it isn't by default, 64K is already
> the runtime default size unless /etc/syslog-startup.conf is modified or
> deleted, so this only really affects systems using systemd. This
> completely removes the need for the busybox bbappend in meta-oe.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Looks good.
Acked-by: Khem Raj <raj.khem@gmail.com>

> ---
> meta/recipes-core/busybox/busybox-1.21.1/defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox-1.21.1/defconfig b/meta/recipes-core/busybox/busybox-1.21.1/defconfig
> index bdfdadf..e287a0d 100644
> --- a/meta/recipes-core/busybox/busybox-1.21.1/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.21.1/defconfig
> @@ -1012,7 +1012,7 @@ CONFIG_FEATURE_SYSLOGD_DUP=y
> CONFIG_FEATURE_SYSLOGD_CFG=y
> CONFIG_FEATURE_SYSLOGD_READ_BUFFER_SIZE=256
> CONFIG_FEATURE_IPC_SYSLOG=y
> -CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=16
> +CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=64
> CONFIG_LOGREAD=y
> CONFIG_FEATURE_LOGREAD_REDUCED_LOCKING=y
> CONFIG_KLOGD=y
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/busybox/busybox-1.21.1/defconfig b/meta/recipes-core/busybox/busybox-1.21.1/defconfig
index bdfdadf..e287a0d 100644
--- a/meta/recipes-core/busybox/busybox-1.21.1/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.21.1/defconfig
@@ -1012,7 +1012,7 @@  CONFIG_FEATURE_SYSLOGD_DUP=y
 CONFIG_FEATURE_SYSLOGD_CFG=y
 CONFIG_FEATURE_SYSLOGD_READ_BUFFER_SIZE=256
 CONFIG_FEATURE_IPC_SYSLOG=y
-CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=16
+CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE=64
 CONFIG_LOGREAD=y
 CONFIG_FEATURE_LOGREAD_REDUCED_LOCKING=y
 CONFIG_KLOGD=y