| Submitter | Koen Kooi |
|---|---|
| Date | June 12, 2011, 4:26 p.m. |
| Message ID | <1703bd12b68b86a3d73fe39e9fd9369ac0b027ca.1307895912.git.koen@dominion.thruhere.net> |
| Download | mbox | patch |
| Permalink | /patch/5679/ |
| State | New, archived |
| Headers | show |
Comments
On 06/12/2011 09:26 AM, Koen Kooi wrote: > The ext3 format is pretty much mandatory for qemu usage, so always create it. > > Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> > --- > meta/conf/machine/include/qemu.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc > index 9ef242f..e908f69 100644 > --- a/meta/conf/machine/include/qemu.inc > +++ b/meta/conf/machine/include/qemu.inc > @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" > > MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" > > -IMAGE_FSTYPES ?= "tar.bz2 ext3" > +IMAGE_FSTYPES += "tar.bz2 ext3" > > ROOT_FLASH_SIZE = "280" > Koen, Are you still putting forth this patch? I don't see it in your tree and wanted to confirm with you. I am trying to clean up a back-log of patch requests that might have been lost. Thanks Sau!
ping Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: > The ext3 format is pretty much mandatory for qemu usage, so always create it. > > Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> > --- > meta/conf/machine/include/qemu.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc > index 9ef242f..e908f69 100644 > --- a/meta/conf/machine/include/qemu.inc > +++ b/meta/conf/machine/include/qemu.inc > @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" > > MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" > > -IMAGE_FSTYPES ?= "tar.bz2 ext3" > +IMAGE_FSTYPES += "tar.bz2 ext3" > > ROOT_FLASH_SIZE = "280" > > -- > 1.6.6.1 >
On 06/30/2011 03:33 PM, Koen Kooi wrote: > ping > I believe that this has been discussed elsewhere. Sau! > Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: > >> The ext3 format is pretty much mandatory for qemu usage, so always create it. >> >> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> >> --- >> meta/conf/machine/include/qemu.inc | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc >> index 9ef242f..e908f69 100644 >> --- a/meta/conf/machine/include/qemu.inc >> +++ b/meta/conf/machine/include/qemu.inc >> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" >> >> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" >> >> -IMAGE_FSTYPES ?= "tar.bz2 ext3" >> +IMAGE_FSTYPES += "tar.bz2 ext3" >> >> ROOT_FLASH_SIZE = "280" >> >> -- >> 1.6.6.1 >> > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
Op 1 jul 2011, om 01:09 heeft Saul Wold het volgende geschreven: > On 06/30/2011 03:33 PM, Koen Kooi wrote: >> ping >> > I believe that this has been discussed elsewhere. Let's post the outcome here then, since I still want this patch to go in. > > Sau! > >> Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: >> >>> The ext3 format is pretty much mandatory for qemu usage, so always create it. >>> >>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> >>> --- >>> meta/conf/machine/include/qemu.inc | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc >>> index 9ef242f..e908f69 100644 >>> --- a/meta/conf/machine/include/qemu.inc >>> +++ b/meta/conf/machine/include/qemu.inc >>> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" >>> >>> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" >>> >>> -IMAGE_FSTYPES ?= "tar.bz2 ext3" >>> +IMAGE_FSTYPES += "tar.bz2 ext3" >>> >>> ROOT_FLASH_SIZE = "280" >>> >>> -- >>> 1.6.6.1 >>> >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >>
On Fri, 2011-07-01 at 08:50 +0200, Koen Kooi wrote: > Op 1 jul 2011, om 01:09 heeft Saul Wold het volgende geschreven: > > > On 06/30/2011 03:33 PM, Koen Kooi wrote: > > I believe that this has been discussed elsewhere. > > Let's post the outcome here then, since I still want this patch to go in. > > >> Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: > >> > >>> The ext3 format is pretty much mandatory for qemu usage, so always create it. > >>> > >>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> > >>> --- > >>> meta/conf/machine/include/qemu.inc | 2 +- > >>> 1 files changed, 1 insertions(+), 1 deletions(-) > >>> > >>> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc > >>> index 9ef242f..e908f69 100644 > >>> --- a/meta/conf/machine/include/qemu.inc > >>> +++ b/meta/conf/machine/include/qemu.inc > >>> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" > >>> > >>> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" > >>> > >>> -IMAGE_FSTYPES ?= "tar.bz2 ext3" > >>> +IMAGE_FSTYPES += "tar.bz2 ext3" > >>> > >>> ROOT_FLASH_SIZE = "280" > >>> Well, I've mentioned this once in a reply but for the record if we start using += in machine files this makes the values much harder to change and for anyone to exclude either tar.bz2 or ext3 from the variable. I'm therefore concerned this change makes things less usable. Cheers, Richard
Op 5 jul. 2011 om 15:17 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: > On Fri, 2011-07-01 at 08:50 +0200, Koen Kooi wrote: >> Op 1 jul 2011, om 01:09 heeft Saul Wold het volgende geschreven: >> >>> On 06/30/2011 03:33 PM, Koen Kooi wrote: >>> I believe that this has been discussed elsewhere. >> >> Let's post the outcome here then, since I still want this patch to go in. >> >>>> Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: >>>> >>>>> The ext3 format is pretty much mandatory for qemu usage, so always create it. >>>>> >>>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> >>>>> --- >>>>> meta/conf/machine/include/qemu.inc | 2 +- >>>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>>> >>>>> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc >>>>> index 9ef242f..e908f69 100644 >>>>> --- a/meta/conf/machine/include/qemu.inc >>>>> +++ b/meta/conf/machine/include/qemu.inc >>>>> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" >>>>> >>>>> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" >>>>> >>>>> -IMAGE_FSTYPES ?= "tar.bz2 ext3" >>>>> +IMAGE_FSTYPES += "tar.bz2 ext3" >>>>> >>>>> ROOT_FLASH_SIZE = "280" >>>>> > > Well, I've mentioned this once in a reply but for the record if we start > using += in machine files this makes the values much harder to change > and for anyone to exclude either tar.bz2 or ext3 from the variable. > > I'm therefore concerned this change makes things less usable. currently I get no ext3 images which breaks the qemu scripts. I currently have no way of saying "I always want tgz and the native formats" > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Tue, 2011-07-05 at 16:01 +0100, Koen Kooi wrote: > I currently have no way of saying "I always want tgz and the native > formats" Does IMAGE_FSTYPES_append = "tgz" not do what you want? p.
Op 5 jul. 2011 om 15:17 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven: > On Fri, 2011-07-01 at 08:50 +0200, Koen Kooi wrote: >> Op 1 jul 2011, om 01:09 heeft Saul Wold het volgende geschreven: >> >>> On 06/30/2011 03:33 PM, Koen Kooi wrote: >>> I believe that this has been discussed elsewhere. >> >> Let's post the outcome here then, since I still want this patch to go in. >> >>>> Op 12 jun 2011, om 18:26 heeft Koen Kooi het volgende geschreven: >>>> >>>>> The ext3 format is pretty much mandatory for qemu usage, so always create it. >>>>> >>>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net> >>>>> --- >>>>> meta/conf/machine/include/qemu.inc | 2 +- >>>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>>> >>>>> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc >>>>> index 9ef242f..e908f69 100644 >>>>> --- a/meta/conf/machine/include/qemu.inc >>>>> +++ b/meta/conf/machine/include/qemu.inc >>>>> @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" >>>>> >>>>> MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" >>>>> >>>>> -IMAGE_FSTYPES ?= "tar.bz2 ext3" >>>>> +IMAGE_FSTYPES += "tar.bz2 ext3" >>>>> >>>>> ROOT_FLASH_SIZE = "280" >>>>> > > Well, I've mentioned this once in a reply but for the record if we start > using += in machine files += is what we do in .dev fwiw > this makes the values much harder to change > and for anyone to exclude either tar.bz2 or ext3 from the variable. how does the current exclusion work? > > I'm therefore concerned this change makes things less usable. > > Cheers, > > Richard > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc index 9ef242f..e908f69 100644 --- a/meta/conf/machine/include/qemu.inc +++ b/meta/conf/machine/include/qemu.inc @@ -3,7 +3,7 @@ PREFERRED_PROVIDER_virtual/xserver ?= "xserver-kdrive" MACHINE_FEATURES = "kernel26 apm alsa pcmcia bluetooth irda usbgadget screen" -IMAGE_FSTYPES ?= "tar.bz2 ext3" +IMAGE_FSTYPES += "tar.bz2 ext3" ROOT_FLASH_SIZE = "280"
The ext3 format is pretty much mandatory for qemu usage, so always create it. Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> --- meta/conf/machine/include/qemu.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)