Patchwork [1/1] eglibc: nscd support depends on OPTION_EGLIBC_INET

login
register
mail settings
Submitter Andrei Gherzan
Date Aug. 26, 2013, 6:48 p.m.
Message ID <1377542924-1605-1-git-send-email-andrei.gherzan@windriver.com>
Download mbox | patch
Permalink /patch/56649/
State New
Headers show

Comments

Andrei Gherzan - Aug. 26, 2013, 6:48 p.m.
Add --disable-nscd if DISTRO_FEATURES does not contain ipv4. This features is
mapped to OPTION_EGLIBC_INET.
The default behavior is to activate nscd (if --disable-nscd is not passed to
configure script). But nscd depends on OPTION_EGLIBC_INET, so compilation will
fail if this option is not activated.

Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
 meta/recipes-core/eglibc/eglibc_2.18.bb |    1 +
 1 file changed, 1 insertion(+)
Saul Wold - Aug. 26, 2013, 9:47 p.m.
On 08/26/2013 11:48 AM, Andrei Gherzan wrote:
> Add --disable-nscd if DISTRO_FEATURES does not contain ipv4. This features is
> mapped to OPTION_EGLIBC_INET.
> The default behavior is to activate nscd (if --disable-nscd is not passed to
> configure script). But nscd depends on OPTION_EGLIBC_INET, so compilation will
> fail if this option is not activated.
>
Does this also need the Package to be set for ALLOW_EMPTY?

Sau!

> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
>   meta/recipes-core/eglibc/eglibc_2.18.bb |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/eglibc/eglibc_2.18.bb b/meta/recipes-core/eglibc/eglibc_2.18.bb
> index 17b651f..771f3e7 100644
> --- a/meta/recipes-core/eglibc/eglibc_2.18.bb
> +++ b/meta/recipes-core/eglibc/eglibc_2.18.bb
> @@ -79,6 +79,7 @@ EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \
>                   --without-selinux \
>                   --enable-obsolete-rpc \
>                   --with-kconfig=${STAGING_BINDIR_NATIVE} \
> +                ${@base_contains('DISTRO_FEATURES', 'ipv4', '', '--disable-nscd', d)} \
>                   ${GLIBC_EXTRA_OECONF}"
>
>   EXTRA_OECONF += "${@get_libc_fpu_setting(bb, d)}"
>
Andrei Gherzan - Aug. 27, 2013, 7:19 a.m.
On Tue, Aug 27, 2013 at 12:47 AM, Saul Wold <sgw@linux.intel.com> wrote:

> On 08/26/2013 11:48 AM, Andrei Gherzan wrote:
>
>> Add --disable-nscd if DISTRO_FEATURES does not contain ipv4. This
>> features is
>> mapped to OPTION_EGLIBC_INET.
>> The default behavior is to activate nscd (if --disable-nscd is not passed
>> to
>> configure script). But nscd depends on OPTION_EGLIBC_INET, so compilation
>> will
>> fail if this option is not activated.
>>
>>  Does this also need the Package to be set for ALLOW_EMPTY?
>
> Sau!
>
>
You're right. V2 is coming. Thanks.

Patch

diff --git a/meta/recipes-core/eglibc/eglibc_2.18.bb b/meta/recipes-core/eglibc/eglibc_2.18.bb
index 17b651f..771f3e7 100644
--- a/meta/recipes-core/eglibc/eglibc_2.18.bb
+++ b/meta/recipes-core/eglibc/eglibc_2.18.bb
@@ -79,6 +79,7 @@  EXTRA_OECONF = "--enable-kernel=${OLDEST_KERNEL} \
                 --without-selinux \
                 --enable-obsolete-rpc \
                 --with-kconfig=${STAGING_BINDIR_NATIVE} \
+                ${@base_contains('DISTRO_FEATURES', 'ipv4', '', '--disable-nscd', d)} \
                 ${GLIBC_EXTRA_OECONF}"
 
 EXTRA_OECONF += "${@get_libc_fpu_setting(bb, d)}"