Patchwork [meta-fsl-arm-extra,PATCHv2,4/4] cfa10036: Add cfa10036 machine configuration

login
register
mail settings
Submitter Alexandre Belloni
Date Aug. 23, 2013, 4:28 p.m.
Message ID <1377275339-10686-5-git-send-email-alexandre.belloni@free-electrons.com>
Download mbox | patch
Permalink /patch/56425/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Alexandre Belloni - Aug. 23, 2013, 4:28 p.m.
This configuration supports the following Crystalfontz boards:
 - cfa-10036
 - cfa-10037
 - cfa-10049
 - cfa-10055
 - cfa-10056
 - cfa-10057
 - cfa-10058

which are all based on the cfa-10036.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10036.conf | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 conf/machine/cfa10036.conf
Otavio Salvador - Aug. 24, 2013, 6:29 p.m.
On Fri, Aug 23, 2013 at 1:28 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> This configuration supports the following Crystalfontz boards:
>  - cfa-10036
>  - cfa-10037
>  - cfa-10049
>  - cfa-10055
>  - cfa-10056
>  - cfa-10057
>  - cfa-10058
>
> which are all based on the cfa-10036.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>


> ---
>  conf/machine/cfa10036.conf | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 conf/machine/cfa10036.conf
>
> diff --git a/conf/machine/cfa10036.conf b/conf/machine/cfa10036.conf
> new file mode 100644
> index 0000000..aa6c9d2
> --- /dev/null
> +++ b/conf/machine/cfa10036.conf
> @@ -0,0 +1,38 @@
> +#@TYPE: Machine
> +#@NAME: Crystalfontz CFA-10036
> +#@SOC: i.MX28
> +#@DESCRIPTION: Machine configuration for CFA-10036
> +
> +include conf/machine/include/mxs-base.inc
> +
> +SOC_FAMILY = "mxs:mx28"
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
> +PREFERRED_VERSION_barebox = "2013.08.0"

The barebox version shouldn't be fixed here. We ought to provide a
single one here and in case it is updated we're fine as it is
supported by the official one.

> +IMAGE_BOOTLOADER = "barebox"
> +BAREBOX_BINARY = "barebox"
> +
> +IMXBOOTLETS_MACHINE = "cfa10036"
> +
> +KERNEL_IMAGETYPE = "zImage"
> +KERNEL_DEVICETREE = "imx28-cfa10036.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10049.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10055.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10056.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10057.dtb"
> +KERNEL_DEVICETREE += "imx28-cfa10058.dtb"

I'd use:

KERNEL_DEVICETREE = "imx28-cfa10036.dtb \
                                        imx28-cfa10037.dtb \
                                        ..."

But this is style so you can choose what you prefer.

> +#we need the kernel to be installed in the final image

# we ...

Patch

diff --git a/conf/machine/cfa10036.conf b/conf/machine/cfa10036.conf
new file mode 100644
index 0000000..aa6c9d2
--- /dev/null
+++ b/conf/machine/cfa10036.conf
@@ -0,0 +1,38 @@ 
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10036
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10036
+
+include conf/machine/include/mxs-base.inc
+
+SOC_FAMILY = "mxs:mx28"
+
+PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
+PREFERRED_VERSION_barebox = "2013.08.0"
+
+IMAGE_BOOTLOADER = "barebox"
+BAREBOX_BINARY = "barebox"
+
+IMXBOOTLETS_MACHINE = "cfa10036"
+
+KERNEL_IMAGETYPE = "zImage"
+KERNEL_DEVICETREE = "imx28-cfa10036.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10049.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10055.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10056.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10057.dtb"
+KERNEL_DEVICETREE += "imx28-cfa10058.dtb"
+
+#we need the kernel to be installed in the final image
+IMAGE_INSTALL_append = " kernel-image kernel-devicetree"
+
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
+IMAGE_FSTYPES ?= "tar.bz2 ext3 barebox.mxsboot-sdcard sdcard"
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
+
+MACHINE_FEATURES = "apm usbgadget usbhost vfat"
+
+# Gstreamer plugin
+MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"