Patchwork runqemu-ifup: when tunctl can't be found, say what package builds it

login
register
mail settings
Submitter Ross Burton
Date Aug. 22, 2013, 2:36 p.m.
Message ID <1377182178-19511-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/56263/
State New
Headers show

Comments

Ross Burton - Aug. 22, 2013, 2:36 p.m.
If runqemu is used without actually building any qemu images (i.e. you
downloaded the images) it's likely that qemu-helper-native hasn't been built.
Instead of just saying what command can't be found, tell the user how to solve
their problem.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 scripts/runqemu-ifup |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Aug. 22, 2013, 3:17 p.m.
On Thu, Aug 22, 2013 at 03:36:18PM +0100, Ross Burton wrote:
> If runqemu is used without actually building any qemu images (i.e. you
> downloaded the images) it's likely that qemu-helper-native hasn't been built.
> Instead of just saying what command can't be found, tell the user how to solve
> their problem.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  scripts/runqemu-ifup |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
> index 5f6a437..140dd88 100755
> --- a/scripts/runqemu-ifup
> +++ b/scripts/runqemu-ifup
> @@ -53,7 +53,7 @@ NATIVE_SYSROOT_DIR=$3
>  
>  TUNCTL=$NATIVE_SYSROOT_DIR/usr/bin/tunctl
>  if [ ! -x "$TUNCTL" ]; then
> -	echo "Error: Unable to find tunctl binary in '$NATIVE_SYSROOT_DIR/usr/bin'"
> +        echo "Error: Unable to find tunctl binary in '$NATIVE_SYSROOT_DIR/usr/bin', please bitbake qemu-helper-native"

^ inconsistent whitespace

>  	exit 1
>  fi
>  
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/scripts/runqemu-ifup b/scripts/runqemu-ifup
index 5f6a437..140dd88 100755
--- a/scripts/runqemu-ifup
+++ b/scripts/runqemu-ifup
@@ -53,7 +53,7 @@  NATIVE_SYSROOT_DIR=$3
 
 TUNCTL=$NATIVE_SYSROOT_DIR/usr/bin/tunctl
 if [ ! -x "$TUNCTL" ]; then
-	echo "Error: Unable to find tunctl binary in '$NATIVE_SYSROOT_DIR/usr/bin'"
+        echo "Error: Unable to find tunctl binary in '$NATIVE_SYSROOT_DIR/usr/bin', please bitbake qemu-helper-native"
 	exit 1
 fi