Patchwork insane.bbclass:WARNING: QA Issue: xxx doesn't match the [a-z0-9.+-]+ regex

login
register
mail settings
Submitter yaoxp
Date Aug. 21, 2013, 6:28 a.m.
Message ID <020301ce9e37$b92b36d0$2b81a470$@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/56115/
State New
Headers show

Comments

yaoxp - Aug. 21, 2013, 6:28 a.m.
Will offer the following warning when there are upper case letters in the BB file name:
WARNING: QA Issue: xxx doesn't match the [a-z0-9.+-]+ regex

Is there such a regulation in yocto that there can't be upper case letters in the BB file name ?

Signed-off-by: Yao Xinpan <yaoxp@cn.fujitsu.com>
---
 meta/classes/insane.bbclass |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

--
1.7.1
Andrei Gherzan - Aug. 28, 2013, 11:18 p.m.
On Wed, Aug 21, 2013 at 9:28 AM, yaoxp <yaoxp@cn.fujitsu.com> wrote:

> Will offer the following warning when there are upper case letters in the
> BB file name:
> WARNING: QA Issue: xxx doesn't match the [a-z0-9.+-]+ regex
>
> Is there such a regulation in yocto that there can't be upper case letters
> in the BB file name ?
>

It used to be a bug in opkg. Isn't that still reproducible? I didn't test
it a while ago.
Here is the link: https://bugzilla.yoctoproject.org/show_bug.cgi?id=3139

ag

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 336beaa..4042e1e 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -776,8 +776,8 @@  python do_package_qa () {
 
     testmatrix = d.getVarFlags("QAPATHTEST")
     import re
-    # The package name matches the [a-z0-9.+-]+ regular expression
-    pkgname_pattern = re.compile("^[a-z0-9.+-]+$")
+    # The package name matches the [A-Za-z0-9.+-]+ regular expression
+    pkgname_pattern = re.compile("^[A-Za-z0-9.+-]+$")
 
     g = globals()
     walk_sane = True
@@ -804,7 +804,7 @@  python do_package_qa () {
         # Check package name
         if not pkgname_pattern.match(package):
             package_qa_handle_error("pkgname",
-                    "%s doesn't match the [a-z0-9.+-]+ regex\n" % package, d)
+                    "%s doesn't match the [A-Za-z0-9.+-]+ regex\n" % 
+ package, d)
 
         path = "%s/%s" % (pkgdest, package)
         if not package_qa_walk(path, warnchecks, errorchecks, skip, package, d):