Patchwork [meta-fsl-arm-extra,2/2] Rework machines to use dtb file in KERNEL_DEVICETREE variable

login
register
mail settings
Submitter Otavio Salvador
Date Aug. 20, 2013, 2:33 a.m.
Message ID <1376966021-14699-2-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/56011/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - Aug. 20, 2013, 2:33 a.m.
The linux-dtb.inc has been rework to use the Linux kernel build system
to generate the DeviceTree binaries so now KERNEL_DEVICETREE variable
should has the /target/ name, not the file path. This patch rework
following machines:

 - imx233-olinuxino-*
 - m28evk
 - m53evk

Change-Id: I824e818f50de094fe1b25ef3ea202abd90093650
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 conf/machine/include/imx233-olinuxino.inc | 2 +-
 conf/machine/m28evk.conf                  | 2 +-
 conf/machine/m53evk.conf                  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Daiane Angolini - Aug. 20, 2013, 3:49 p.m.
I'm sorry, I was not able to review your patches yesterday.

On 08/19/2013 11:33 PM, Otavio Salvador wrote:
> The linux-dtb.inc has been rework to use the Linux kernel build system

The linux-dtb.inc has been *reworked* to use the Linux......

> to generate the DeviceTree binaries so now KERNEL_DEVICETREE variable
> should has the /target/ name, not the file path. This patch rework

blablabla. This patch *reworks*

> following machines:
>
>   - imx233-olinuxino-*
>   - m28evk
>   - m53evk
>
> Change-Id: I824e818f50de094fe1b25ef3ea202abd90093650
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>   conf/machine/include/imx233-olinuxino.inc | 2 +-
>   conf/machine/m28evk.conf                  | 2 +-
>   conf/machine/m53evk.conf                  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/conf/machine/include/imx233-olinuxino.inc b/conf/machine/include/imx233-olinuxino.inc
> index 9c4e9d9..c0b400b 100644
> --- a/conf/machine/include/imx233-olinuxino.inc
> +++ b/conf/machine/include/imx233-olinuxino.inc
> @@ -9,7 +9,7 @@ UBOOT_MACHINE = "mx23_olinuxino_config"
>   SOC_FAMILY = "mxs:mx23:imx233-olinuxino"
>
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx23-olinuxino.dts"
> +KERNEL_DEVICETREE = "imx23-olinuxino.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> diff --git a/conf/machine/m28evk.conf b/conf/machine/m28evk.conf
> index 675d56a..ec8af0e 100644
> --- a/conf/machine/m28evk.conf
> +++ b/conf/machine/m28evk.conf
> @@ -11,7 +11,7 @@ UBOOT_MACHINE = "m28evk_config"
>
>   PREFERRED_PROVIDER_virtual/kernel = "linux-fslc"
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx28-m28evk.dts"
> +KERNEL_DEVICETREE = "imx28-m28evk.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> diff --git a/conf/machine/m53evk.conf b/conf/machine/m53evk.conf
> index 293aa66..33f9cef 100644
> --- a/conf/machine/m53evk.conf
> +++ b/conf/machine/m53evk.conf
> @@ -13,7 +13,7 @@ UBOOT_MACHINE = "m53evk_config"
>   PREFERRED_PROVIDER_virtual/kernel = "linux-denx"
>
>   KERNEL_IMAGETYPE = "uImage"
> -KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx53-m53evk.dts"
> +KERNEL_DEVICETREE = "imx53-m53evk.dtb"
>
>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>   IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
>

Everything else looks fine.
Otavio Salvador - Aug. 20, 2013, 4:51 p.m.
On Tue, Aug 20, 2013 at 12:49 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> I'm sorry, I was not able to review your patches yesterday.

No problem :-)

> On 08/19/2013 11:33 PM, Otavio Salvador wrote:
>>
>> The linux-dtb.inc has been rework to use the Linux kernel build system
>
>
> The linux-dtb.inc has been *reworked* to use the Linux......
>
>
>> to generate the DeviceTree binaries so now KERNEL_DEVICETREE variable
>> should has the /target/ name, not the file path. This patch rework
>
>
> blablabla. This patch *reworks*
...
>
> Everything else looks fine.

Great.

New commit log is:

commit 7c869ff2634a39d1d64bd81ab9474e1386c167f6
Author: Otavio Salvador <otavio@ossystems.com.br>
Date:   Sat Aug 17 19:00:36 2013 -0300

    Rework machines to use dtb file in KERNEL_DEVICETREE variable

    The linux-dtb.inc has been reworked to use the Linux kernel build
    system to generate the DeviceTree binaries so now KERNEL_DEVICETREE
    variable should has the /target/ name, not the file path. This patch
    reworks following machines:

     - imx23evk
     - imx28evk
     - imx51evk
     - imx53ard
     - imx53qsb
     - imx6dlsabreauto
     - imx6dlsabresd
     - imx6qsabreauto
     - imx6qsabresd
     - imx6solosabreauto
     - imx6solosabresd

    Change-Id: I37e9c3737552299677e315b6279a6e0a8e217836
    Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Regards,

Patch

diff --git a/conf/machine/include/imx233-olinuxino.inc b/conf/machine/include/imx233-olinuxino.inc
index 9c4e9d9..c0b400b 100644
--- a/conf/machine/include/imx233-olinuxino.inc
+++ b/conf/machine/include/imx233-olinuxino.inc
@@ -9,7 +9,7 @@  UBOOT_MACHINE = "mx23_olinuxino_config"
 SOC_FAMILY = "mxs:mx23:imx233-olinuxino"
 
 KERNEL_IMAGETYPE = "uImage"
-KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx23-olinuxino.dts"
+KERNEL_DEVICETREE = "imx23-olinuxino.dtb"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
 IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
diff --git a/conf/machine/m28evk.conf b/conf/machine/m28evk.conf
index 675d56a..ec8af0e 100644
--- a/conf/machine/m28evk.conf
+++ b/conf/machine/m28evk.conf
@@ -11,7 +11,7 @@  UBOOT_MACHINE = "m28evk_config"
 
 PREFERRED_PROVIDER_virtual/kernel = "linux-fslc"
 KERNEL_IMAGETYPE = "uImage"
-KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx28-m28evk.dts"
+KERNEL_DEVICETREE = "imx28-m28evk.dtb"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
 IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
diff --git a/conf/machine/m53evk.conf b/conf/machine/m53evk.conf
index 293aa66..33f9cef 100644
--- a/conf/machine/m53evk.conf
+++ b/conf/machine/m53evk.conf
@@ -13,7 +13,7 @@  UBOOT_MACHINE = "m53evk_config"
 PREFERRED_PROVIDER_virtual/kernel = "linux-denx"
 
 KERNEL_IMAGETYPE = "uImage"
-KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx53-m53evk.dts"
+KERNEL_DEVICETREE = "imx53-m53evk.dtb"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
 IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"