Patchwork [meta-fsl-arm] qt4-embedded: Allow use of Qt Media Player in multi-headed system

login
register
mail settings
Submitter Eric Nelson
Date Aug. 17, 2013, 1:59 p.m.
Message ID <1376747966-4629-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/55963/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

Eric Nelson - Aug. 17, 2013, 1:59 p.m.
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 recipes-qt/qt4/qt4-embedded_4.8.5.bbappend         |  5 ++-
 ...renderer-Allow-v4l-device-from-environmen.patch | 46 ++++++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)
 create mode 100644 recipes-qt/qt4/qt4/0002-i.MX-video-renderer-Allow-v4l-device-from-environmen.patch
Otavio Salvador - Aug. 19, 2013, 11:28 a.m.
Hi Eric and Rogerio,

On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>

Eric, could you extend the commit log to describe how user would use
this? You did a nice commit log for the patch file (which is good) but
the BSP commit log should also provide information for the users.

Rogerio, could you take a look in the patch and ack/nack/comment?

Regards,
Fabio Estevam - Aug. 19, 2013, 11:54 a.m.
On Mon, Aug 19, 2013 at 8:28 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hi Eric and Rogerio,
>
> On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> Eric, could you extend the commit log to describe how user would use
> this? You did a nice commit log for the patch file (which is good) but
> the BSP commit log should also provide information for the users.
>
> Rogerio, could you take a look in the patch and ack/nack/comment?

Adding the correct email from Rogerio on Cc.
Rogerio Pimentel - Aug. 19, 2013, 1:33 p.m.
On 08/19/2013 08:28 AM, Otavio Salvador wrote:
> Hi Eric and Rogerio,
>
> On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> Eric, could you extend the commit log to describe how user would use
> this? You did a nice commit log for the patch file (which is good) but
> the BSP commit log should also provide information for the users.
>
> Rogerio, could you take a look in the patch and ack/nack/comment?
>
> Regards,
>
>
Hi Otavio,

There is a long time I don't work with it. I have no comments. I'm sorry.

Rgds
Rogerio
Otavio Salvador - Aug. 19, 2013, 1:43 p.m.
Hello Rogerio and Eric,

On Mon, Aug 19, 2013 at 10:33 AM, Rogerio Pimentel
<rogerio.pimentel@freescale.com> wrote:
> On 08/19/2013 08:28 AM, Otavio Salvador wrote:
>>
>> Hi Eric and Rogerio,
>>
>> On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>>
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>
>> Eric, could you extend the commit log to describe how user would use
>> this? You did a nice commit log for the patch file (which is good) but
>> the BSP commit log should also provide information for the users.
>>
>> Rogerio, could you take a look in the patch and ack/nack/comment?
>>
>> Regards,
>>
>>
> Hi Otavio,
>
> There is a long time I don't work with it. I have no comments. I'm sorry.

Rogerio, OK.

Eric, please address the commit log issue than and we're good.
Eric Nelson - Aug. 19, 2013, 2:12 p.m.
Hi Otavio,

On 08/19/2013 04:28 AM, Otavio Salvador wrote:
> Hi Eric and Rogerio,
>
> On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> Eric, could you extend the commit log to describe how user would use
> this? You did a nice commit log for the patch file (which is good) but
> the BSP commit log should also provide information for the users.
>
> Rogerio, could you take a look in the patch and ack/nack/comment?
>

Just sent V2.

Let me know what you think.

This is a bit weird, since there are two-levels of commit message
(1 in the outer patch, and another in the inner).

Regards,


Eric
Eric Nelson - Aug. 19, 2013, 2:14 p.m.
On 08/19/2013 07:12 AM, Eric Nelson wrote:
> Hi Otavio,
>
> On 08/19/2013 04:28 AM, Otavio Salvador wrote:
>> Hi Eric and Rogerio,
>>
>> On Sat, Aug 17, 2013 at 10:59 AM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>>
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>
>> Eric, could you extend the commit log to describe how user would use
>> this? You did a nice commit log for the patch file (which is good) but
>> the BSP commit log should also provide information for the users.
>>
>> Rogerio, could you take a look in the patch and ack/nack/comment?
>>
>
> Just sent V2.
>
Okay, I realized upon receiving V2 that I didn't include a
description of what was changed in V2.

Remedied with V3

Patch

diff --git a/recipes-qt/qt4/qt4-embedded_4.8.5.bbappend b/recipes-qt/qt4/qt4-embedded_4.8.5.bbappend
index 4c4d0c9..fc16670 100644
--- a/recipes-qt/qt4/qt4-embedded_4.8.5.bbappend
+++ b/recipes-qt/qt4/qt4-embedded_4.8.5.bbappend
@@ -2,7 +2,10 @@ 
 FILESEXTRAPATHS_prepend := "${THISDIR}/qt4:"
 
 SRC_URI_append_mx5 += "file://0001-Add-support-for-i.MX-codecs-to-phonon.patch"
-SRC_URI_append_mx6 += "file://0001-Add-support-for-i.MX-codecs-to-phonon.patch"
+SRC_URI_append_mx6 += " \
+	file://0001-Add-support-for-i.MX-codecs-to-phonon.patch \
+	file://0002-i.MX-video-renderer-Allow-v4l-device-from-environmen.patch \
+"
 
 DEPENDS_append_mx5 = " virtual/kernel virtual/libgles2"
 PACKAGE_ARCH_mx5 = "${MACHINE_ARCH}"
diff --git a/recipes-qt/qt4/qt4/0002-i.MX-video-renderer-Allow-v4l-device-from-environmen.patch b/recipes-qt/qt4/qt4/0002-i.MX-video-renderer-Allow-v4l-device-from-environmen.patch
new file mode 100644
index 0000000..0226db5
--- /dev/null
+++ b/recipes-qt/qt4/qt4/0002-i.MX-video-renderer-Allow-v4l-device-from-environmen.patch
@@ -0,0 +1,46 @@ 
+From 023befba9aad60ef58177fd987a6aa40c357b2b2 Mon Sep 17 00:00:00 2001
+From: Eric Nelson <eric.nelson@boundarydevices.com>
+Date: Fri, 16 Aug 2013 11:42:23 -0700
+Subject: [PATCH] i.MX video renderer: Allow v4l device from environment
+
+The i.MX6 supports multiple IPUs and multiple V4L2 output
+devices for each.
+
+Devices are numbered starting with /dev/video16 and defined
+for each configured display. In general, /dev/video16 will
+correspond to the RGB (background) layer for /dev/fb0.
+If a display is the first on an IPU, an additional V4L2
+output will be defined that corresponds to the normally
+YUV overlay (foreground) layer.
+
+This patch allows association of the proper device for
+a particular session for use in multi-headed applications.
+The default is /dev/video17:
+	export v4lsinkdev=/dev/video17
+
+Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
+---
+ src/3rdparty/phonon/gstreamer/widgetrenderer.cpp | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/3rdparty/phonon/gstreamer/widgetrenderer.cpp b/src/3rdparty/phonon/gstreamer/widgetrenderer.cpp
+index aa4925a..a502ccd 100644
+--- a/src/3rdparty/phonon/gstreamer/widgetrenderer.cpp
++++ b/src/3rdparty/phonon/gstreamer/widgetrenderer.cpp
+@@ -58,9 +58,12 @@ WidgetRenderer::WidgetRenderer(VideoWidget *videoWidget)
+         : AbstractRenderer(videoWidget)
+ {
+     if ((m_videoSink = gst_element_factory_make("mfw_v4lsink", NULL)) && m_videoSink != NULL) {
+-	
++	char *videodev;
+ 	gst_object_ref (GST_OBJECT (m_videoSink)); //Take ownership
+         gst_object_sink (GST_OBJECT (m_videoSink));
++	videodev=getenv("v4lsinkdev");
++	if (videodev)
++                g_object_set (G_OBJECT (m_videoSink), "device", videodev, NULL);
+     }
+ 
+     // Clear the background with black by default
+-- 
+1.8.1.2
+