Patchwork initramfs-live-install: remove allarch inherit

login
register
mail settings
Submitter Tom Zanussi
Date June 8, 2011, 1:48 p.m.
Message ID <1307540891.2580.2.camel@elmorro>
Download mbox | patch
Permalink /patch/5563/
State New, archived
Headers show

Comments

Tom Zanussi - June 8, 2011, 1:48 p.m.
initramfs-live-install is only compatible with i.86|x86_64 so
shouldn't inherit 'allarch'.  This removes it.

More specifically, commit 52295fa3deef3b0374b99829626d524cefae6001
(Improve handling of 'all' architecture recipes and their interaction
with sstate) sets TARGET_ARCH which due to the COMPATIBLE_HOST setting
in the recipe causes it to be skipped and gives the following error
for any -live build:

NOTE: Resolving any missing task queue dependencies
NOTE: Runtime target 'initramfs-live-install' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['initramfs-live-install']
ERROR: Required build target 'core-image-sato-live' has no buildable providers.
Missing or unbuildable dependency chain was: ['core-image-sato-live', 'core-ima\
ge-minimal-initramfs', 'initramfs-live-install']
ERROR: Nothing RPROVIDES 'initramfs-live-install'

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../initrdscripts/initramfs-live-install_1.0.bb    |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Saul Wold - June 9, 2011, 6:41 p.m.
On 06/08/2011 06:48 AM, Tom Zanussi wrote:
> initramfs-live-install is only compatible with i.86|x86_64 so
> shouldn't inherit 'allarch'.  This removes it.
>
> More specifically, commit 52295fa3deef3b0374b99829626d524cefae6001
> (Improve handling of 'all' architecture recipes and their interaction
> with sstate) sets TARGET_ARCH which due to the COMPATIBLE_HOST setting
> in the recipe causes it to be skipped and gives the following error
> for any -live build:
>
> NOTE: Resolving any missing task queue dependencies
> NOTE: Runtime target 'initramfs-live-install' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['initramfs-live-install']
> ERROR: Required build target 'core-image-sato-live' has no buildable providers.
> Missing or unbuildable dependency chain was: ['core-image-sato-live', 'core-ima\
> ge-minimal-initramfs', 'initramfs-live-install']
> ERROR: Nothing RPROVIDES 'initramfs-live-install'
>
> Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
> ---
>   .../initrdscripts/initramfs-live-install_1.0.bb    |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
> index fdda718..6a16f4c 100644
> --- a/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
> +++ b/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
> @@ -11,8 +11,6 @@ do_install() {
>           install -m 0755 ${WORKDIR}/init-install.sh ${D}/install.sh
>   }
>
> -inherit allarch
> -
>   FILES_${PN} = " /install.sh "
>
>   # Alternatives to grub need adding for other arch support


Merged into OE-Core with slight modification to keep the inherit 
allarch, but commented out.

Thanks
	Sau!

Patch

diff --git a/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
index fdda718..6a16f4c 100644
--- a/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-live-install_1.0.bb
@@ -11,8 +11,6 @@  do_install() {
         install -m 0755 ${WORKDIR}/init-install.sh ${D}/install.sh
 }
 
-inherit allarch
-
 FILES_${PN} = " /install.sh "
 
 # Alternatives to grub need adding for other arch support