Patchwork [3/3] gst-meta-base: bring in the v4l2 related gst plugin

login
register
mail settings
Submitter Nitin A Kamble
Date Aug. 8, 2013, 9:34 p.m.
Message ID <ebd74052582cd3def1b5a4c3d609cfc6b2613933.1375996888.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/55363/
State New
Headers show

Comments

Nitin A Kamble - Aug. 8, 2013, 9:34 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
is also pulled in the gst-meta-base packages.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Otavio Salvador - Aug. 8, 2013, 9:57 p.m.
On Thu, Aug 8, 2013 at 6:34 PM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> is also pulled in the gst-meta-base packages.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 210da37..c1139f4 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
>      gst-plugins-base-videoscale \
>      gst-plugins-base-ffmpegcolorspace \
>      gst-plugins-good-autodetect \
> -    gst-plugins-good-souphttpsrc"
> +    gst-plugins-good-souphttpsrc \
> +    gst-plugins-base-videotestsrc \

videotestsrc is not related to this change.

> +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"
>
>  RRECOMMENDS_gst-meta-x11-base = "\
>      gst-plugins-base-ximagesink \
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Nitin A Kamble - Aug. 8, 2013, 10 p.m.
> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Thursday, August 08, 2013 2:57 PM
> To: Kamble, Nitin A
> Cc: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 3/3] gst-meta-base: bring in the v4l2 related
> gst plugin
> 
> On Thu, Aug 8, 2013 at 6:34 PM,  <nitin.a.kamble@intel.com> wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> > is also pulled in the gst-meta-base packages.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > index 210da37..c1139f4 100644
> > --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
> >      gst-plugins-base-videoscale \
> >      gst-plugins-base-ffmpegcolorspace \
> >      gst-plugins-good-autodetect \
> > -    gst-plugins-good-souphttpsrc"
> > +    gst-plugins-good-souphttpsrc \
> > +    gst-plugins-base-videotestsrc \
> 
> videotestsrc is not related to this change.
> 


Thanks for the feedback Otavio. I need it for the encoding support. So I will move it in a separate commit instead.

Nitin

> > +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-
> video4linux2', '', d)}"
> >
> >  RRECOMMENDS_gst-meta-x11-base = "\
> >      gst-plugins-base-ximagesink \
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Martin Jansa - Aug. 8, 2013, 10:37 p.m.
On Thu, Aug 08, 2013 at 09:34:29PM +0000, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> is also pulled in the gst-meta-base packages.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 210da37..c1139f4 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
>      gst-plugins-base-videoscale \
>      gst-plugins-base-ffmpegcolorspace \
>      gst-plugins-good-autodetect \
> -    gst-plugins-good-souphttpsrc"
> +    gst-plugins-good-souphttpsrc \
> +    gst-plugins-base-videotestsrc \
> +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"

I was expecting to see PACKAGECONFIG somewhere, is v4l2 autodetected?

Why not keep v4l2-utils in meta-multimedia?

>  
>  RRECOMMENDS_gst-meta-x11-base = "\
>      gst-plugins-base-ximagesink \
> -- 
> 1.8.1.4
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Nitin A Kamble - Aug. 8, 2013, 11:10 p.m.
> -----Original Message-----
> From: Martin Jansa [mailto:martin.jansa@gmail.com]
> Sent: Thursday, August 08, 2013 3:37 PM
> To: Kamble, Nitin A
> Cc: Openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 3/3] gst-meta-base: bring in the v4l2 related
> gst plugin
> 
> On Thu, Aug 08, 2013 at 09:34:29PM +0000, nitin.a.kamble@intel.com wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> >
> > If the v4l2 machine feature is enabled, then the v4l2 gstreamer plugin
> > is also pulled in the gst-meta-base packages.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> > ---
> >  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > index 210da37..c1139f4 100644
> > --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> > @@ -35,7 +35,9 @@ RDEPENDS_gst-meta-base = "\
> >      gst-plugins-base-videoscale \
> >      gst-plugins-base-ffmpegcolorspace \
> >      gst-plugins-good-autodetect \
> > -    gst-plugins-good-souphttpsrc"
> > +    gst-plugins-good-souphttpsrc \
> > +    gst-plugins-base-videotestsrc \
> > +    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-
> video4linux2', '', d)}"
> 
> I was expecting to see PACKAGECONFIG somewhere, is v4l2 autodetected?

There are PACKAGECONFIG definitions for v4l in meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc & meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.31.bb in oecore, which controls building of the v4l2 plugin. And I see it is built even when v4l is not listed in PACKAGECONFIG var, so looks like it is autodetected.

But the above change is to make sure that the v4l2 plugins gets pulled in the image.
> 
> Why not keep v4l2-utils in meta-multimedia?
Because of the general availability of accelerated encoding in processors, many BSPs can include the accelerated encoding support. Also because the gstreamers plugin for v4l2 is in oecore, so oecore will be ideal location for v4l-utils.

Thanks,
Nitin


> 
> >
> >  RRECOMMENDS_gst-meta-x11-base = "\
> >      gst-plugins-base-ximagesink \
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 210da37..c1139f4 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -35,7 +35,9 @@  RDEPENDS_gst-meta-base = "\
     gst-plugins-base-videoscale \
     gst-plugins-base-ffmpegcolorspace \
     gst-plugins-good-autodetect \
-    gst-plugins-good-souphttpsrc"
+    gst-plugins-good-souphttpsrc \
+    gst-plugins-base-videotestsrc \
+    ${@base_contains('MACHINE_FEATURES', 'v4l2', 'gst-plugins-good-video4linux2', '', d)}"
 
 RRECOMMENDS_gst-meta-x11-base = "\
     gst-plugins-base-ximagesink \