Patchwork [V2] oe-setup-builddir: substitute ##OEROOT## when using templates

login
register
mail settings
Submitter Ross Burton
Date Aug. 8, 2013, 2:45 p.m.
Message ID <1375973136-11264-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/55345/
State New
Headers show

Comments

Ross Burton - Aug. 8, 2013, 2:45 p.m.
oe-setup-builddir substitutes ##COREBASE## which seems like it should have the
same value as the variable ${COREBASE}.  In reality it doesn't as ##COREBASE##
is substituted with the value of $OEROOT (the location of the oe-init-build-env
script), whereas ${COREBASE} is set by oe-core to the parent directory of meta/.
If oe-core's meta/ isn't a top-level directory then ##COREBASE## and ${COREBASE}
have different values, which can lead to confusion.

To resolve this, deprecate (but still substitute) ##COREBASE## and substitute

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend |    2 +-
 scripts/oe-setup-builddir                                    |    5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Khem Raj - Aug. 8, 2013, 8:26 p.m.
On Aug 8, 2013, at 7:45 AM, Ross Burton <ross.burton@intel.com> wrote:

> -KBRANCH_genericx86  = "standard/common-pc/atom-pc"
> +KBRANCH_genericx86  = "standard/common-pc/genericx86"

This seems to be unrelated to what you are doing with this commit.
secondly this belongs to yocto mailing list not OE-Core
Ross Burton - Aug. 9, 2013, 8:56 a.m.
On 8 August 2013 21:26, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Aug 8, 2013, at 7:45 AM, Ross Burton <ross.burton@intel.com> wrote:
>
>> -KBRANCH_genericx86  = "standard/common-pc/atom-pc"
>> +KBRANCH_genericx86  = "standard/common-pc/genericx86"
>
> This seems to be unrelated to what you are doing with this commit.
> secondly this belongs to yocto mailing list not OE-Core

How did that slip in there.  Sorry. :(

Ross

Patch

diff --git a/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend b/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
index c4c005d..7882ba1 100644
--- a/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
+++ b/meta-yocto-bsp/recipes-kernel/linux/linux-yocto_3.8.bbappend
@@ -1,5 +1,5 @@ 
 KBRANCH_atom-pc  = "standard/common-pc/atom-pc"
-KBRANCH_genericx86  = "standard/common-pc/atom-pc"
+KBRANCH_genericx86  = "standard/common-pc/genericx86"
 KBRANCH_routerstationpro = "standard/routerstationpro"
 KBRANCH_mpc8315e-rdb = "standard/fsl-mpc8315e-rdb"
 KBRANCH_beagleboard = "standard/beagleboard"
diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
index d5d8d98..adb55c7 100755
--- a/scripts/oe-setup-builddir
+++ b/scripts/oe-setup-builddir
@@ -101,7 +101,10 @@  EOM
 
     # Put the abosolute path to the layers in bblayers.conf so we can run
     # bitbake without the init script after the first run
-    sed "s|##COREBASE##|$OEROOT|g" $OECORELAYERCONF > $BUILDDIR/conf/bblayers.conf
+    sed "s|##OEROOT##|$OEROOT|g" $OECORELAYERCONF > $BUILDDIR/conf/bblayers.conf
+    # ##COREBASE## is deprecated as it's meaning was inconsistent, but continue
+    # to replace it for compatibility.
+    sed -i -e "s|##COREBASE##|$OEROOT|g" $BUILDDIR/conf/bblayers.conf
 fi
 
 # Prevent disturbing a new GIT clone in same console