Patchwork acpica: Add ACPICA package

login
register
mail settings
Submitter Matt Ranostay
Date Aug. 7, 2013, 2:17 p.m.
Message ID <1375885075-13410-1-git-send-email-mranostay@gmail.com>
Download mbox | patch
Permalink /patch/55271/
State New
Headers show

Comments

Matt Ranostay - Aug. 7, 2013, 2:17 p.m.
Added ACPICA package which enables viewing/editing/compiling
of ACPI tables.

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
 meta/recipes-extended/acpica/acpica_20130725.bb | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta/recipes-extended/acpica/acpica_20130725.bb
Ross Burton - Aug. 7, 2013, 2:34 p.m.
Hi,

On 7 August 2013 15:17, Matt Ranostay <mranostay@gmail.com> wrote:
> Added ACPICA package which enables viewing/editing/compiling
> of ACPI tables.

Is this really general-purpose enough to be suitable for oe-core, or
would it be more suited to meta-oe or some other layer?

> +PR = "r0"

Remove this line, r0 is the default.

+LIC_FILES_CHKSUM =
"file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"

${S} is default, so in general people do file://sources/...

> +SRC_URI = "https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz"

Fetching that here with wget produces:

ERROR: The certificate of ‘acpica.org’ is not trusted.

Someone should tell them...

> +inherit autotools

The recipe doesn't use autotools, so you should drop this inherit.

> +do_install() {
> +    oe_runmake INSTALLFLAGS="-m 555"
> +}

That's just running 'make INSTALLFLAGS="-m 555"'.  You'll need to tell
it to run the right target for install, and to pass ${D} somehow so
the makefile doesn't try and write to /usr directly.

Ross
Matt Ranostay - Aug. 7, 2013, 3:53 p.m.
On Wed, Aug 7, 2013 at 7:34 AM, Burton, Ross <ross.burton@intel.com> wrote:

> Hi,
>
> On 7 August 2013 15:17, Matt Ranostay <mranostay@gmail.com> wrote:
> > Added ACPICA package which enables viewing/editing/compiling
> > of ACPI tables.
>
> Is this really general-purpose enough to be suitable for oe-core, or
> would it be more suited to meta-oe or some other layer?
>
> Probably correct to be in meta-oe or another layer since only x86 and some
ARM platforms use ACPI as of now.


> > +PR = "r0"
>
> Remove this line, r0 is the default.
>
> +LIC_FILES_CHKSUM =
>
> "file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"
>
> ${S} is default, so in general people do file://sources/...
>
> > +SRC_URI = "
> https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz"
>
> Fetching that here with wget produces:
>
> ERROR: The certificate of ‘acpica.org’ is not trusted.
>
>
Seems StartCom Ltd. isn't a trusted  CA or just not in the keystore by
default.


> Someone should tell them...
>
> > +inherit autotools
>
> The recipe doesn't use autotools, so you should drop this inherit.
>
> > +do_install() {
> > +    oe_runmake INSTALLFLAGS="-m 555"
> > +}
>
> That's just running 'make INSTALLFLAGS="-m 555"'.  You'll need to tell
> it to run the right target for install, and to pass ${D} somehow so
> the makefile doesn't try and write to /usr directly.
>
> Gah good catch. Will fix up and resubmit.


> Ross
>
Fathi Boudra - Aug. 7, 2013, 4:05 p.m.
Hi Matt,

On 7 August 2013 18:53, Matt Ranostay <mranostay@gmail.com> wrote:
>
>
> On Wed, Aug 7, 2013 at 7:34 AM, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> Hi,
>>
>> On 7 August 2013 15:17, Matt Ranostay <mranostay@gmail.com> wrote:
>> > Added ACPICA package which enables viewing/editing/compiling
>> > of ACPI tables.

2 weeks ago, I've added acpica to our meta layer:
https://git.linaro.org/gitweb?p=openembedded/meta-linaro.git;a=blob;f=meta-linaro/recipes-extra/acpica/acpica_20130626.bb;h=65eadac0d8cb289fafc3fd9093771414850b9973;hb=ac4d009827b1552e3422aede2c06b5a610221144

Feel free to cherry pick if you found anything useful.

>> Is this really general-purpose enough to be suitable for oe-core, or
>> would it be more suited to meta-oe or some other layer?
>>
> Probably correct to be in meta-oe or another layer since only x86 and some
> ARM platforms use ACPI as of now.
>
>>
>> > +PR = "r0"
>>
>> Remove this line, r0 is the default.
>>
>> +LIC_FILES_CHKSUM =
>>
>> "file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"
>>
>> ${S} is default, so in general people do file://sources/...
>>
>> > +SRC_URI =
>> > "https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz"
>>
>> Fetching that here with wget produces:
>>
>> ERROR: The certificate of ‘acpica.org’ is not trusted.
>>
>
> Seems StartCom Ltd. isn't a trusted  CA or just not in the keystore by
> default.
>
>>
>> Someone should tell them...
>>
>> > +inherit autotools
>>
>> The recipe doesn't use autotools, so you should drop this inherit.
>>
>> > +do_install() {
>> > +    oe_runmake INSTALLFLAGS="-m 555"
>> > +}
>>
>> That's just running 'make INSTALLFLAGS="-m 555"'.  You'll need to tell
>> it to run the right target for install, and to pass ${D} somehow so
>> the makefile doesn't try and write to /usr directly.
>>
> Gah good catch. Will fix up and resubmit.

Cheers,
Fathi

Patch

diff --git a/meta/recipes-extended/acpica/acpica_20130725.bb b/meta/recipes-extended/acpica/acpica_20130725.bb
new file mode 100644
index 0000000..6fa183c
--- /dev/null
+++ b/meta/recipes-extended/acpica/acpica_20130725.bb
@@ -0,0 +1,23 @@ 
+DESCRIPTION = "ACPI Component Architecture (ACPICA) project"
+LICENSE = "BSD | GPLv2"
+HOMEPAGE = "http://www.acpica.org"
+PR = "r0"
+
+LIC_FILES_CHKSUM = "file://${S}/source/include/aclocal.h;endline=42;md5=07fbd4e514c75e140a19e3ab508f763d"
+
+SRC_URI = "https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "ef854d8c97f04795d6ac958cb8898e7e"
+SRC_URI[sha256sum] = "f31ad702a17f9dd03907693120267216d1a797625d123a38f3064fbafe141d8a"
+
+S = "${WORKDIR}/acpica-unix2-${PV}"
+
+inherit autotools
+
+do_compile() {
+    oe_runmake CC="${CC}"
+}
+
+do_install() {
+    oe_runmake INSTALLFLAGS="-m 555"
+}