Patchwork [meta-fsl-arm,1/2] barebox: Rework do_configure_prepend to do_pre_configure

login
register
mail settings
Submitter Alexandre Belloni
Date Aug. 7, 2013, 10:40 a.m.
Message ID <1375872027-20428-1-git-send-email-alexandre.belloni@free-electrons.com>
Download mbox | patch
Permalink /patch/55259/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Alexandre Belloni - Aug. 7, 2013, 10:40 a.m.
Defining a new task instead of using configure_prepend allows inheriting
recipes to override the pre_configure task.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 recipes-bsp/barebox/barebox.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Otavio Salvador - Aug. 7, 2013, 1:35 p.m.
Hello  Alexandre,

On Wed, Aug 7, 2013 at 7:40 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Defining a new task instead of using configure_prepend allows inheriting
> recipes to override the pre_configure task.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

I applied both batches to master branch. Thanks for those.

I'd like to know if you'd be willing to prepare a patchset to move
barebox to OE-Core as it should be put there, not in meta-fsl-arm?
Alexandre Belloni - Aug. 7, 2013, 2:46 p.m.
Hello,

On 07/08/2013 15:35, Otavio Salvador wrote:
> Hello  Alexandre,
>
> On Wed, Aug 7, 2013 at 7:40 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
>> Defining a new task instead of using configure_prepend allows inheriting
>> recipes to override the pre_configure task.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> I applied both batches to master branch. Thanks for those.
>
> I'd like to know if you'd be willing to prepare a patchset to move
> barebox to OE-Core as it should be put there, not in meta-fsl-arm?
>

The actual current goal is to get support for the i.mx28 based cfa-100xx
boards in meta-fsl-arm-extra. As the boards are supported by the
mainline barebox and they have a defconfig there, I had to get the
flexibility to do:

do_pre_configure() {
    oe_runmake cfa10036_defconfig
}

in my recipe.

Also, barebox_default_env is now generated in common/ and I want to had
support for custom default environment.

What features do you think would be missing before submitting that to
oe-core ?
Eric BENARD - Aug. 7, 2013, 2:58 p.m.
Hi Alexandre,

Le Wed, 07 Aug 2013 16:46:49 +0200,
Alexandre Belloni <alexandre.belloni@free-electrons.com> a écrit :
> On 07/08/2013 15:35, Otavio Salvador wrote:
> > I'd like to know if you'd be willing to prepare a patchset to move
> > barebox to OE-Core as it should be put there, not in meta-fsl-arm?
> >
> What features do you think would be missing before submitting that to
> oe-core ?
> 
Last time I asked on oe-core's mailing list concerning the criteria to
get barebox accepted, I didn't get any answer, maybe you will have more
luck.

Eric
Otavio Salvador - Aug. 7, 2013, 4:02 p.m.
On Wed, Aug 7, 2013 at 11:46 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hello,
>
> On 07/08/2013 15:35, Otavio Salvador wrote:
>> Hello  Alexandre,
>>
>> On Wed, Aug 7, 2013 at 7:40 AM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>>> Defining a new task instead of using configure_prepend allows inheriting
>>> recipes to override the pre_configure task.
>>>
>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> I applied both batches to master branch. Thanks for those.
>>
>> I'd like to know if you'd be willing to prepare a patchset to move
>> barebox to OE-Core as it should be put there, not in meta-fsl-arm?
>>
>
> The actual current goal is to get support for the i.mx28 based cfa-100xx
> boards in meta-fsl-arm-extra. As the boards are supported by the
> mainline barebox and they have a defconfig there, I had to get the
> flexibility to do:
>
> do_pre_configure() {
>     oe_runmake cfa10036_defconfig
> }
>
> in my recipe.
>
> Also, barebox_default_env is now generated in common/ and I want to had
> support for custom default environment.
>
> What features do you think would be missing before submitting that to
> oe-core ?

I think a small cleanup and test it on qemu.

Patch

diff --git a/recipes-bsp/barebox/barebox.inc b/recipes-bsp/barebox/barebox.inc
index 5902f15..e52b463 100644
--- a/recipes-bsp/barebox/barebox.inc
+++ b/recipes-bsp/barebox/barebox.inc
@@ -20,10 +20,11 @@  BAREBOXENV_SYMLINK ?= "bareboxenv-${MACHINE}.bin"
 
 INSANE_SKIP_${PN} = "True"
 
-do_configure_prepend() {
+do_pre_configure() {
 	   cp ${WORKDIR}/defconfig ${S}/.config
 	   oe_runmake oldconfig
 }
+addtask pre_configure before do_configure after do_patch
 
 do_compile () {
 	if [ "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', 'ld-is-gold', '', d)}" = "ld-is-gold" ] ; then