Patchwork icu: fix configure error

login
register
mail settings
Submitter Bian Naimeng
Date Aug. 5, 2013, 9:39 a.m.
Message ID <51FF72B7.9070706@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/55117/
State New
Headers show

Comments

Bian Naimeng - Aug. 5, 2013, 9:39 a.m.
If we don't create ${STAGING_ICU_DIR_NATIVE} before doing 
do_configure for cross target, the following will be caught.

 |configure: error: No such directory ${cross_buildroot} supplied as
 | the argument to --with-cross-build. Use an absolute path.
 |Configure failed. The contents of all config.log files follows to
 | aid debugging
 |ERROR: oe_runconf failed

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 meta/recipes-support/icu/icu.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Saul Wold - Aug. 5, 2013, 5:39 p.m.
On 08/05/2013 02:39 AM, Bian Naimeng wrote:
> If we don't create ${STAGING_ICU_DIR_NATIVE} before doing
> do_configure for cross target, the following will be caught.
>
>   |configure: error: No such directory ${cross_buildroot} supplied as
>   | the argument to --with-cross-build. Use an absolute path.
>   |Configure failed. The contents of all config.log files follows to
>   | aid debugging
>   |ERROR: oe_runconf failed
>
Is this really needed?  Which ICU is failing, the target or -native 
version?  The target version depends on the -native version which should 
have created this directory first.

What are the steps to reproduce this?

Sau!

> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>
> ---
>   meta/recipes-support/icu/icu.inc |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-support/icu/icu.inc b/meta/recipes-support/icu/icu.inc
> index e3944cd..3987e42 100644
> --- a/meta/recipes-support/icu/icu.inc
> +++ b/meta/recipes-support/icu/icu.inc
> @@ -27,6 +27,7 @@ EXTRA_OECONF_class-native = ""
>   # http://bugs.icu-project.org/trac/ticket/9790
>   do_configure_prepend() {
>       [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
> +    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
>   }
>
>   do_install_append_class-native() {
>
Bian Naimeng - Aug. 6, 2013, 9:40 a.m.
said the following on 2013-8-6 1:39:, Saul Wold wrote:
> On 08/05/2013 02:39 AM, Bian Naimeng wrote:
>> If we don't create ${STAGING_ICU_DIR_NATIVE} before doing
>> do_configure for cross target, the following will be caught.
>>
>>   |configure: error: No such directory ${cross_buildroot} supplied as
>>   | the argument to --with-cross-build. Use an absolute path.
>>   |Configure failed. The contents of all config.log files follows to
>>   | aid debugging
>>   |ERROR: oe_runconf failed
>>
> Is this really needed?  Which ICU is failing, the target or -native version?  The target version depends on the -native version which should have created this directory first.
> 

We don't need it almost.
As you said, the native version will create this directory first.

> What are the steps to reproduce this?

It occurs in my strange case.
My icu-native is different version from icu.

In my opinion, it's better to remove this dependence.

Thanks
 Bian

> 
> Sau!
> 
>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>>
>> ---
>>   meta/recipes-support/icu/icu.inc |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-support/icu/icu.inc b/meta/recipes-support/icu/icu.inc
>> index e3944cd..3987e42 100644
>> --- a/meta/recipes-support/icu/icu.inc
>> +++ b/meta/recipes-support/icu/icu.inc
>> @@ -27,6 +27,7 @@ EXTRA_OECONF_class-native = ""
>>   # http://bugs.icu-project.org/trac/ticket/9790
>>   do_configure_prepend() {
>>       [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
>> +    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
>>   }
>>
>>   do_install_append_class-native() {

Patch

diff --git a/meta/recipes-support/icu/icu.inc b/meta/recipes-support/icu/icu.inc
index e3944cd..3987e42 100644
--- a/meta/recipes-support/icu/icu.inc
+++ b/meta/recipes-support/icu/icu.inc
@@ -27,6 +27,7 @@  EXTRA_OECONF_class-native = ""
 # http://bugs.icu-project.org/trac/ticket/9790
 do_configure_prepend() {
     [ -f ${S}/acinclude.m4 ] || cp ${S}/aclocal.m4 ${S}/acinclude.m4
+    [ -d ${STAGING_ICU_DIR_NATIVE} ] || mkdir -p ${STAGING_ICU_DIR_NATIVE}
 }
 
 do_install_append_class-native() {