Patchwork [meta-kde] qt4: Rename bbappend to match oe-core

login
register
mail settings
Submitter Khem Raj
Date Aug. 1, 2013, 11:26 p.m.
Message ID <1375399572-4926-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/54939/
State Accepted, archived
Headers show

Comments

Khem Raj - Aug. 1, 2013, 11:26 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes-misc-support/qt4-native_4.8.4.bbappend   |    9 ---------
 recipes-misc-support/qt4-native_4.8.5.bbappend   |    9 +++++++++
 recipes-misc-support/qt4-x11-free_4.8.4.bbappend |   11 -----------
 recipes-misc-support/qt4-x11-free_4.8.5.bbappend |   11 +++++++++++
 4 files changed, 20 insertions(+), 20 deletions(-)
 delete mode 100644 recipes-misc-support/qt4-native_4.8.4.bbappend
 create mode 100644 recipes-misc-support/qt4-native_4.8.5.bbappend
 delete mode 100644 recipes-misc-support/qt4-x11-free_4.8.4.bbappend
 create mode 100644 recipes-misc-support/qt4-x11-free_4.8.5.bbappend
Samuel Stirtzel - Aug. 5, 2013, 8:34 a.m.
2013/8/2 Khem Raj <raj.khem@gmail.com>:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes-misc-support/qt4-native_4.8.4.bbappend   |    9 ---------
>  recipes-misc-support/qt4-native_4.8.5.bbappend   |    9 +++++++++
>  recipes-misc-support/qt4-x11-free_4.8.4.bbappend |   11 -----------
>  recipes-misc-support/qt4-x11-free_4.8.5.bbappend |   11 +++++++++++
>  4 files changed, 20 insertions(+), 20 deletions(-)
>  delete mode 100644 recipes-misc-support/qt4-native_4.8.4.bbappend
>  create mode 100644 recipes-misc-support/qt4-native_4.8.5.bbappend
>  delete mode 100644 recipes-misc-support/qt4-x11-free_4.8.4.bbappend
>  create mode 100644 recipes-misc-support/qt4-x11-free_4.8.5.bbappend
>
> diff --git a/recipes-misc-support/qt4-native_4.8.4.bbappend b/recipes-misc-support/qt4-native_4.8.4.bbappend
> deleted file mode 100644
> index b6ee9f2..0000000
> --- a/recipes-misc-support/qt4-native_4.8.4.bbappend
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -# Needed by kdelibs4-native
> -DEPENDS += "openssl-native"
> -PRINC := "${@int(PRINC) + 1}"
> -
> -EXTRA_OECONF += "-no-pch -no-sm -openssl"
> -
> -TOBUILD += "src/phonon"
> -
> -PRINC := "${@int(PRINC) + 1}"
> diff --git a/recipes-misc-support/qt4-native_4.8.5.bbappend b/recipes-misc-support/qt4-native_4.8.5.bbappend
> new file mode 100644
> index 0000000..b6ee9f2
> --- /dev/null
> +++ b/recipes-misc-support/qt4-native_4.8.5.bbappend
> @@ -0,0 +1,9 @@
> +# Needed by kdelibs4-native
> +DEPENDS += "openssl-native"
> +PRINC := "${@int(PRINC) + 1}"
> +
> +EXTRA_OECONF += "-no-pch -no-sm -openssl"
> +
> +TOBUILD += "src/phonon"
> +
> +PRINC := "${@int(PRINC) + 1}"
> diff --git a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend b/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> deleted file mode 100644
> index 9d13ffa..0000000
> --- a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -DEPENDS_append_omap3 = " libgles-omap3"
> -DEPENDS_append_ti33x = " libgles-omap3"
> -PRINC := "${@int(PRINC) + 3}"
> -
> -#This will add reduced visibility to some exports on Qt, otherwise KDE plugins will fail
> -QT_CONFIG_FLAGS_append = " --reduce-exports"
> -
> -# Build OpenGL/ES support if available
> -QT_GLFLAGS_omap3 = "-opengl es2 "
> -# Needed by kdelibs
> -QT_DISTRO_FLAGS = "-accessibility -sm"
> diff --git a/recipes-misc-support/qt4-x11-free_4.8.5.bbappend b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> new file mode 100644
> index 0000000..9d13ffa
> --- /dev/null
> +++ b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> @@ -0,0 +1,11 @@
> +DEPENDS_append_omap3 = " libgles-omap3"
> +DEPENDS_append_ti33x = " libgles-omap3"
> +PRINC := "${@int(PRINC) + 3}"
> +
> +#This will add reduced visibility to some exports on Qt, otherwise KDE plugins will fail
> +QT_CONFIG_FLAGS_append = " --reduce-exports"
> +
> +# Build OpenGL/ES support if available
> +QT_GLFLAGS_omap3 = "-opengl es2 "
> +# Needed by kdelibs
> +QT_DISTRO_FLAGS = "-accessibility -sm"
> --
> 1.7.9.5

Applied,
thanks for the patch.

In a follow up I have removed the platform dependent configuration, as
it has become an unnecessary hurdle.


Some questions towards meta-kde "users":
Do you actually use (or try to use) meta-kde, or is it just enabled
for tests like world builds?
What are your expectations regarding this layer?
I am asking since the feedback for this layer is very sparse (mostly
because it is very uncommon for embedded devices and the recipes are
incomplete).

TBH it is unlikely that my priorities will shift back to meta-kde in this year.
Khem Raj - Aug. 5, 2013, 8:21 p.m.
On Mon, Aug 5, 2013 at 1:34 AM, Samuel Stirtzel
<s.stirtzel@googlemail.com>wrote:

> 2013/8/2 Khem Raj <raj.khem@gmail.com>:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  recipes-misc-support/qt4-native_4.8.4.bbappend   |    9 ---------
> >  recipes-misc-support/qt4-native_4.8.5.bbappend   |    9 +++++++++
> >  recipes-misc-support/qt4-x11-free_4.8.4.bbappend |   11 -----------
> >  recipes-misc-support/qt4-x11-free_4.8.5.bbappend |   11 +++++++++++
> >  4 files changed, 20 insertions(+), 20 deletions(-)
> >  delete mode 100644 recipes-misc-support/qt4-native_4.8.4.bbappend
> >  create mode 100644 recipes-misc-support/qt4-native_4.8.5.bbappend
> >  delete mode 100644 recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> >  create mode 100644 recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> >
> > diff --git a/recipes-misc-support/qt4-native_4.8.4.bbappend
> b/recipes-misc-support/qt4-native_4.8.4.bbappend
> > deleted file mode 100644
> > index b6ee9f2..0000000
> > --- a/recipes-misc-support/qt4-native_4.8.4.bbappend
> > +++ /dev/null
> > @@ -1,9 +0,0 @@
> > -# Needed by kdelibs4-native
> > -DEPENDS += "openssl-native"
> > -PRINC := "${@int(PRINC) + 1}"
> > -
> > -EXTRA_OECONF += "-no-pch -no-sm -openssl"
> > -
> > -TOBUILD += "src/phonon"
> > -
> > -PRINC := "${@int(PRINC) + 1}"
> > diff --git a/recipes-misc-support/qt4-native_4.8.5.bbappend
> b/recipes-misc-support/qt4-native_4.8.5.bbappend
> > new file mode 100644
> > index 0000000..b6ee9f2
> > --- /dev/null
> > +++ b/recipes-misc-support/qt4-native_4.8.5.bbappend
> > @@ -0,0 +1,9 @@
> > +# Needed by kdelibs4-native
> > +DEPENDS += "openssl-native"
> > +PRINC := "${@int(PRINC) + 1}"
> > +
> > +EXTRA_OECONF += "-no-pch -no-sm -openssl"
> > +
> > +TOBUILD += "src/phonon"
> > +
> > +PRINC := "${@int(PRINC) + 1}"
> > diff --git a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> b/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> > deleted file mode 100644
> > index 9d13ffa..0000000
> > --- a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
> > +++ /dev/null
> > @@ -1,11 +0,0 @@
> > -DEPENDS_append_omap3 = " libgles-omap3"
> > -DEPENDS_append_ti33x = " libgles-omap3"
> > -PRINC := "${@int(PRINC) + 3}"
> > -
> > -#This will add reduced visibility to some exports on Qt, otherwise KDE
> plugins will fail
> > -QT_CONFIG_FLAGS_append = " --reduce-exports"
> > -
> > -# Build OpenGL/ES support if available
> > -QT_GLFLAGS_omap3 = "-opengl es2 "
> > -# Needed by kdelibs
> > -QT_DISTRO_FLAGS = "-accessibility -sm"
> > diff --git a/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> > new file mode 100644
> > index 0000000..9d13ffa
> > --- /dev/null
> > +++ b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
> > @@ -0,0 +1,11 @@
> > +DEPENDS_append_omap3 = " libgles-omap3"
> > +DEPENDS_append_ti33x = " libgles-omap3"
> > +PRINC := "${@int(PRINC) + 3}"
> > +
> > +#This will add reduced visibility to some exports on Qt, otherwise KDE
> plugins will fail
> > +QT_CONFIG_FLAGS_append = " --reduce-exports"
> > +
> > +# Build OpenGL/ES support if available
> > +QT_GLFLAGS_omap3 = "-opengl es2 "
> > +# Needed by kdelibs
> > +QT_DISTRO_FLAGS = "-accessibility -sm"
> > --
> > 1.7.9.5
>
> Applied,
> thanks for the patch.
>
> In a follow up I have removed the platform dependent configuration, as
> it has become an unnecessary hurdle.
>
>
> Some questions towards meta-kde "users":
> Do you actually use (or try to use) meta-kde, or is it just enabled
> for tests like world builds?
>

?right now its in world builds for me.



> What are your expectations regarding this layer?
>


??However I want to be
able to have a systemd-plasma-active-image as a possibility for
angstrom reference images.?


I am asking since the feedback for this layer is very sparse (mostly
> because it is very uncommon for embedded devices and the recipes are
> incomplete).
>
> TBH it is unlikely that my priorities will shift back to meta-kde in this
> year.
>
>
>
> --
> Regards
> Samuel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes-misc-support/qt4-native_4.8.4.bbappend b/recipes-misc-support/qt4-native_4.8.4.bbappend
deleted file mode 100644
index b6ee9f2..0000000
--- a/recipes-misc-support/qt4-native_4.8.4.bbappend
+++ /dev/null
@@ -1,9 +0,0 @@ 
-# Needed by kdelibs4-native
-DEPENDS += "openssl-native"
-PRINC := "${@int(PRINC) + 1}"
-
-EXTRA_OECONF += "-no-pch -no-sm -openssl"
-
-TOBUILD += "src/phonon"
-
-PRINC := "${@int(PRINC) + 1}"
diff --git a/recipes-misc-support/qt4-native_4.8.5.bbappend b/recipes-misc-support/qt4-native_4.8.5.bbappend
new file mode 100644
index 0000000..b6ee9f2
--- /dev/null
+++ b/recipes-misc-support/qt4-native_4.8.5.bbappend
@@ -0,0 +1,9 @@ 
+# Needed by kdelibs4-native
+DEPENDS += "openssl-native"
+PRINC := "${@int(PRINC) + 1}"
+
+EXTRA_OECONF += "-no-pch -no-sm -openssl"
+
+TOBUILD += "src/phonon"
+
+PRINC := "${@int(PRINC) + 1}"
diff --git a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend b/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
deleted file mode 100644
index 9d13ffa..0000000
--- a/recipes-misc-support/qt4-x11-free_4.8.4.bbappend
+++ /dev/null
@@ -1,11 +0,0 @@ 
-DEPENDS_append_omap3 = " libgles-omap3"
-DEPENDS_append_ti33x = " libgles-omap3"
-PRINC := "${@int(PRINC) + 3}"
-
-#This will add reduced visibility to some exports on Qt, otherwise KDE plugins will fail
-QT_CONFIG_FLAGS_append = " --reduce-exports"
-
-# Build OpenGL/ES support if available
-QT_GLFLAGS_omap3 = "-opengl es2 "
-# Needed by kdelibs
-QT_DISTRO_FLAGS = "-accessibility -sm"
diff --git a/recipes-misc-support/qt4-x11-free_4.8.5.bbappend b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
new file mode 100644
index 0000000..9d13ffa
--- /dev/null
+++ b/recipes-misc-support/qt4-x11-free_4.8.5.bbappend
@@ -0,0 +1,11 @@ 
+DEPENDS_append_omap3 = " libgles-omap3"
+DEPENDS_append_ti33x = " libgles-omap3"
+PRINC := "${@int(PRINC) + 3}"
+
+#This will add reduced visibility to some exports on Qt, otherwise KDE plugins will fail
+QT_CONFIG_FLAGS_append = " --reduce-exports"
+
+# Build OpenGL/ES support if available
+QT_GLFLAGS_omap3 = "-opengl es2 "
+# Needed by kdelibs
+QT_DISTRO_FLAGS = "-accessibility -sm"