Patchwork [meta-fsl-arm,v2] gst-plugins-gl: Add dependencies on libjpeg, libpng

login
register
mail settings
Submitter Eric Nelson
Date July 26, 2013, 4:06 p.m.
Message ID <1374854807-3997-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/54609/
State Not Applicable
Delegated to: Otavio Salvador
Headers show

Comments

Eric Nelson - July 26, 2013, 4:06 p.m.
There's a tight dependency on libjpeg.so.8 and libpng16.so.16
inside of the libgstopengl.so library:

~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
  | grep NEED
  NEEDED               libgstgl-0.10.so.1
  NEEDED               libgstcontroller-0.10.so.0
  NEEDED               libgstfsl-0.10.so.0
  NEEDED               libipu.so.0
  NEEDED               librt.so.1
  NEEDED               libgstvideo-0.10.so.0
  NEEDED               libgstbase-0.10.so.0
  NEEDED               libgstinterfaces-0.10.so.0
  NEEDED               libgstreamer-0.10.so.0
  NEEDED               libgobject-2.0.so.0
  NEEDED               libffi.so.6
  NEEDED               libgmodule-2.0.so.0
  NEEDED               libgthread-2.0.so.0
  NEEDED               libxml2.so.2
  NEEDED               libdl.so.2
  NEEDED               libglib-2.0.so.0
  NEEDED               libpthread.so.0
  NEEDED               libGLESv2.so.2
  NEEDED               libEGL.so.1
  NEEDED               libpng16.so.16
  NEEDED               libz.so.1
  NEEDED               libjpeg.so.8
  NEEDED               libm.so.6
  NEEDED               libc.so.6
  VERNEED              0x00001de4
  VERNEEDNUM           0x00000003

Change-Id: Ieec9824d8fb3883265148e228bc7d374ba4f755b
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend | 1 +
 1 file changed, 1 insertion(+)
Otavio Salvador - July 26, 2013, 4:17 p.m.
On Fri, Jul 26, 2013 at 1:06 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
> inside of the libgstopengl.so library:
>
> ~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
>   | grep NEED
>   NEEDED               libgstgl-0.10.so.1
>   NEEDED               libgstcontroller-0.10.so.0
>   NEEDED               libgstfsl-0.10.so.0
>   NEEDED               libipu.so.0
>   NEEDED               librt.so.1
>   NEEDED               libgstvideo-0.10.so.0
>   NEEDED               libgstbase-0.10.so.0
>   NEEDED               libgstinterfaces-0.10.so.0
>   NEEDED               libgstreamer-0.10.so.0
>   NEEDED               libgobject-2.0.so.0
>   NEEDED               libffi.so.6
>   NEEDED               libgmodule-2.0.so.0
>   NEEDED               libgthread-2.0.so.0
>   NEEDED               libxml2.so.2
>   NEEDED               libdl.so.2
>   NEEDED               libglib-2.0.so.0
>   NEEDED               libpthread.so.0
>   NEEDED               libGLESv2.so.2
>   NEEDED               libEGL.so.1
>   NEEDED               libpng16.so.16
>   NEEDED               libz.so.1
>   NEEDED               libjpeg.so.8
>   NEEDED               libm.so.6
>   NEEDED               libc.so.6
>   VERNEED              0x00001de4
>   VERNEEDNUM           0x00000003
>
> Change-Id: Ieec9824d8fb3883265148e228bc7d374ba4f755b
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>

> ---
>  recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
> index 51eb457..2d4f0ec 100644
> --- a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
> +++ b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
> @@ -3,6 +3,7 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>  PRINC := "${@int(PRINC) + 4}"
>
> +DEPENDS += "jpeg libpng"
>  DEPENDS_append_mx6 = " gst-fsl-plugin gpu-viv-bin-mx6q"
>
>  SRC_URI_append_mx6 = " file://IMX_MMCODEC_3.0.35_4.0.0.patch"
> --
> 1.8.1.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Otavio Salvador - July 26, 2013, 4:18 p.m.
On Fri, Jul 26, 2013 at 1:06 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
> inside of the libgstopengl.so library:
>
> ~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
>   | grep NEED
>   NEEDED               libgstgl-0.10.so.1
>   NEEDED               libgstcontroller-0.10.so.0
>   NEEDED               libgstfsl-0.10.so.0
>   NEEDED               libipu.so.0
>   NEEDED               librt.so.1
>   NEEDED               libgstvideo-0.10.so.0
>   NEEDED               libgstbase-0.10.so.0
>   NEEDED               libgstinterfaces-0.10.so.0
>   NEEDED               libgstreamer-0.10.so.0
>   NEEDED               libgobject-2.0.so.0
>   NEEDED               libffi.so.6
>   NEEDED               libgmodule-2.0.so.0
>   NEEDED               libgthread-2.0.so.0
>   NEEDED               libxml2.so.2
>   NEEDED               libdl.so.2
>   NEEDED               libglib-2.0.so.0
>   NEEDED               libpthread.so.0
>   NEEDED               libGLESv2.so.2
>   NEEDED               libEGL.so.1
>   NEEDED               libpng16.so.16
>   NEEDED               libz.so.1
>   NEEDED               libjpeg.so.8
>   NEEDED               libm.so.6
>   NEEDED               libc.so.6
>   VERNEED              0x00001de4
>   VERNEEDNUM           0x00000003
>
> Change-Id: Ieec9824d8fb3883265148e228bc7d374ba4f755b
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>

I am sorry to didn't find this before but this is not a meta-fsl-arm
specific fix. Instead this should be send to OE-Core and modify the
.bb file.

I checked the source:

.../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
configure.ac:  JPEG_LIBS="-ljpeg"
.../gst-plugins-gl-0.10.3% git grep lpng configure.ac
.../gst-plugins-gl-0.10.3% git grep png configure.ac
configure.ac:dnl libpng is optional
configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes, HAVE_PNG=no)
configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])


--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Eric Nelson - July 26, 2013, 6:17 p.m.
Thanks Otavio,

On 07/26/2013 09:18 AM, Otavio Salvador wrote:
> On Fri, Jul 26, 2013 at 1:06 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
>> inside of the libgstopengl.so library:
>>
>> <snip>
 >>
>>
>> Change-Id: Ieec9824d8fb3883265148e228bc7d374ba4f755b
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> I am sorry to didn't find this before but this is not a meta-fsl-arm
> specific fix. Instead this should be send to OE-Core and modify the
> .bb file.
>
> I checked the source:
>
> .../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
> configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
> configure.ac:  JPEG_LIBS="-ljpeg"
> .../gst-plugins-gl-0.10.3% git grep lpng configure.ac
> .../gst-plugins-gl-0.10.3% git grep png configure.ac
> configure.ac:dnl libpng is optional
> configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes, HAVE_PNG=no)
> configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])
>

I'm going to need to re-test this. It looks like 'jpeg' is
already expressed as a dependency:

	http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bb?h=dylan

Regards,


Eric
Otavio Salvador - July 26, 2013, 6:33 p.m.
On Fri, Jul 26, 2013 at 3:17 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> On 07/26/2013 09:18 AM, Otavio Salvador wrote:
>> I am sorry to didn't find this before but this is not a meta-fsl-arm
>> specific fix. Instead this should be send to OE-Core and modify the
>> .bb file.
>>
>> I checked the source:
>>
>> .../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
>> configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
>> configure.ac:  JPEG_LIBS="-ljpeg"
>> .../gst-plugins-gl-0.10.3% git grep lpng configure.ac
>> .../gst-plugins-gl-0.10.3% git grep png configure.ac
>> configure.ac:dnl libpng is optional
>> configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes,
>> HAVE_PNG=no)
>> configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])
>>
>
> I'm going to need to re-test this. It looks like 'jpeg' is
> already expressed as a dependency:
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bb?h=dylan

Yes; right.

So it lacking png dependency; seems to be the only real issue here.
Eric Nelson - July 26, 2013, 6:43 p.m.
On 07/26/2013 11:33 AM, Otavio Salvador wrote:
> On Fri, Jul 26, 2013 at 3:17 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> On 07/26/2013 09:18 AM, Otavio Salvador wrote:
>>> I am sorry to didn't find this before but this is not a meta-fsl-arm
>>> specific fix. Instead this should be send to OE-Core and modify the
>>> .bb file.
>>>
>>> I checked the source:
>>>
>>> .../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
>>> configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
>>> configure.ac:  JPEG_LIBS="-ljpeg"
>>> .../gst-plugins-gl-0.10.3% git grep lpng configure.ac
>>> .../gst-plugins-gl-0.10.3% git grep png configure.ac
>>> configure.ac:dnl libpng is optional
>>> configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes,
>>> HAVE_PNG=no)
>>> configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])
>>>
>>
>> I'm going to need to re-test this. It looks like 'jpeg' is
>> already expressed as a dependency:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bb?h=dylan
>
> Yes; right.
>
> So it lacking png dependency; seems to be the only real issue here.
>

Well, maybe.

For some reason, neither libpng nor libjpeg was installed
in my rootfs.

I'll do a clean build and look more closely the next time.

I'm also confused about how things linked in the first place.

Both of those libraries must have been present during the
configure and build steps, but neither made into the
filesystem and I'm not sure why.

In my first attempt to pull in the gl-plugin, I added it
via local.conf. Perhaps that's the root cause and I'll
try to confirm things...

Regards,


Eric
Eric Nelson - July 28, 2013, 4 p.m.
On 07/26/2013 11:43 AM, Eric Nelson wrote:
> On 07/26/2013 11:33 AM, Otavio Salvador wrote:
>> On Fri, Jul 26, 2013 at 3:17 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>> On 07/26/2013 09:18 AM, Otavio Salvador wrote:
>>>> I am sorry to didn't find this before but this is not a meta-fsl-arm
>>>> specific fix. Instead this should be send to OE-Core and modify the
>>>> .bb file.
>>>>
>>>> I checked the source:
>>>>
>>>> .../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
>>>> configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
>>>> configure.ac:  JPEG_LIBS="-ljpeg"
>>>> .../gst-plugins-gl-0.10.3% git grep lpng configure.ac
>>>> .../gst-plugins-gl-0.10.3% git grep png configure.ac
>>>> configure.ac:dnl libpng is optional
>>>> configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes,
>>>> HAVE_PNG=no)
>>>> configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])
>>>>
>>>
>>> I'm going to need to re-test this. It looks like 'jpeg' is
>>> already expressed as a dependency:
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bb?h=dylan
>>>
>>
>> Yes; right.
>>
>> So it lacking png dependency; seems to be the only real issue here.
>>
>
> Well, maybe.
>
> For some reason, neither libpng nor libjpeg was installed
> in my rootfs.
>
> I'll do a clean build and look more closely the next time.
>
> I'm also confused about how things linked in the first place.
>
> Both of those libraries must have been present during the
> configure and build steps, but neither made into the
> filesystem and I'm not sure why.
>
> In my first attempt to pull in the gl-plugin, I added it
> via local.conf. Perhaps that's the root cause and I'll
> try to confirm things...
>

I confirmed that this is not a problem with a clean build.

Sorry for the noise, and please disregard the patch.

Patch

diff --git a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
index 51eb457..2d4f0ec 100644
--- a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
+++ b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
@@ -3,6 +3,7 @@ 
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 PRINC := "${@int(PRINC) + 4}"
 
+DEPENDS += "jpeg libpng"
 DEPENDS_append_mx6 = " gst-fsl-plugin gpu-viv-bin-mx6q"
 
 SRC_URI_append_mx6 = " file://IMX_MMCODEC_3.0.35_4.0.0.patch"