Patchwork [bitbake-devel] hob/settings: remove extra variable declarations

login
register
mail settings
Submitter Cristiana Voicu
Date July 26, 2013, 8:29 a.m.
Message ID <1374827345-15234-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/54565/
State New
Headers show

Comments

Cristiana Voicu - July 26, 2013, 8:29 a.m.
When the settings were split in two: simple and advanced,
it seems that some declarations were added in addition on advanced
settings page, and some of them were forgotten on simple
settings page.

Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 .../lib/bb/ui/crumbs/hig/advancedsettingsdialog.py |    5 -----
 .../lib/bb/ui/crumbs/hig/simplesettingsdialog.py   |    5 -----
 2 files changed, 10 deletions(-)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hig/advancedsettingsdialog.py b/bitbake/lib/bb/ui/crumbs/hig/advancedsettingsdialog.py
index bbcaba8..8702a52 100644
--- a/bitbake/lib/bb/ui/crumbs/hig/advancedsettingsdialog.py
+++ b/bitbake/lib/bb/ui/crumbs/hig/advancedsettingsdialog.py
@@ -123,11 +123,6 @@  class AdvancedSettingsDialog (CrumbsDialog, SettingsUIHelper):
 
         # class members for internal use
         self.distro_combo = None
-        self.dldir_text = None
-        self.sstatedir_text = None
-        self.sstatemirror_text = None
-        self.bb_spinner = None
-        self.pmake_spinner = None
         self.rootfs_size_spinner = None
         self.extra_size_spinner = None
         self.gplv3_checkbox = None
diff --git a/bitbake/lib/bb/ui/crumbs/hig/simplesettingsdialog.py b/bitbake/lib/bb/ui/crumbs/hig/simplesettingsdialog.py
index c1bd45f..2672ed8 100644
--- a/bitbake/lib/bb/ui/crumbs/hig/simplesettingsdialog.py
+++ b/bitbake/lib/bb/ui/crumbs/hig/simplesettingsdialog.py
@@ -78,12 +78,7 @@  class SimpleSettingsDialog (CrumbsDialog, SettingsUIHelper):
         self.sstatemirrors_changed = 0
         self.bb_spinner = None
         self.pmake_spinner = None
-        self.rootfs_size_spinner = None
-        self.extra_size_spinner = None
-        self.gplv3_checkbox = None
-        self.toolchain_checkbox = None
         self.setting_store = None
-        self.image_types_checkbuttons = {}
 
         self.md5 = self.config_md5()
         self.proxy_md5 = self.config_proxy_md5()