Patchwork [meta-fsl-arm] gst-plugins-gl: Add dependencies on libjpeg, libpng

login
register
mail settings
Submitter Eric Nelson
Date July 26, 2013, 12:04 a.m.
Message ID <1374797051-3697-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/54537/
State Not Applicable
Delegated to: Otavio Salvador
Headers show

Comments

Eric Nelson - July 26, 2013, 12:04 a.m.
There's a tight dependency on libjpeg.so.8 and libpng16.so.16
inside of the libgstopengl.so library:

~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
  | grep NEED
  NEEDED               libgstgl-0.10.so.1
  NEEDED               libgstcontroller-0.10.so.0
  NEEDED               libgstfsl-0.10.so.0
  NEEDED               libipu.so.0
  NEEDED               librt.so.1
  NEEDED               libgstvideo-0.10.so.0
  NEEDED               libgstbase-0.10.so.0
  NEEDED               libgstinterfaces-0.10.so.0
  NEEDED               libgstreamer-0.10.so.0
  NEEDED               libgobject-2.0.so.0
  NEEDED               libffi.so.6
  NEEDED               libgmodule-2.0.so.0
  NEEDED               libgthread-2.0.so.0
  NEEDED               libxml2.so.2
  NEEDED               libdl.so.2
  NEEDED               libglib-2.0.so.0
  NEEDED               libpthread.so.0
  NEEDED               libGLESv2.so.2
  NEEDED               libEGL.so.1
  NEEDED               libpng16.so.16
  NEEDED               libz.so.1
  NEEDED               libjpeg.so.8
  NEEDED               libm.so.6
  NEEDED               libc.so.6
  VERNEED              0x00001de4
  VERNEEDNUM           0x00000003

Change-Id: Idf6f824847ee6978d8ecd2e793bbd0fd97b54c82
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend | 1 +
 1 file changed, 1 insertion(+)
Otavio Salvador - July 26, 2013, 12:58 p.m.
On Thu, Jul 25, 2013 at 9:04 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
> inside of the libgstopengl.so library:
>
> ~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
>   | grep NEED
>   NEEDED               libgstgl-0.10.so.1
>   NEEDED               libgstcontroller-0.10.so.0
>   NEEDED               libgstfsl-0.10.so.0
>   NEEDED               libipu.so.0
>   NEEDED               librt.so.1
>   NEEDED               libgstvideo-0.10.so.0
>   NEEDED               libgstbase-0.10.so.0
>   NEEDED               libgstinterfaces-0.10.so.0
>   NEEDED               libgstreamer-0.10.so.0
>   NEEDED               libgobject-2.0.so.0
>   NEEDED               libffi.so.6
>   NEEDED               libgmodule-2.0.so.0
>   NEEDED               libgthread-2.0.so.0
>   NEEDED               libxml2.so.2
>   NEEDED               libdl.so.2
>   NEEDED               libglib-2.0.so.0
>   NEEDED               libpthread.so.0
>   NEEDED               libGLESv2.so.2
>   NEEDED               libEGL.so.1
>   NEEDED               libpng16.so.16
>   NEEDED               libz.so.1
>   NEEDED               libjpeg.so.8
>   NEEDED               libm.so.6
>   NEEDED               libc.so.6
>   VERNEED              0x00001de4
>   VERNEEDNUM           0x00000003
>
> Change-Id: Idf6f824847ee6978d8ecd2e793bbd0fd97b54c82
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>

This should be add as depends, not rdepends. As the rdepends should be
computed automatically :)

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Eric Nelson - July 26, 2013, 2:25 p.m.
Thanks for the guidance, Otavio.

On 07/26/2013 05:58 AM, Otavio Salvador wrote:
> On Thu, Jul 25, 2013 at 9:04 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
>> inside of the libgstopengl.so library:
>>
>> ~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so \
>>    | grep NEED
>>    NEEDED               libgstgl-0.10.so.1
>>    NEEDED               libgstcontroller-0.10.so.0
>>    NEEDED               libgstfsl-0.10.so.0
>>    NEEDED               libipu.so.0
>>    NEEDED               librt.so.1
>>    NEEDED               libgstvideo-0.10.so.0
>>    NEEDED               libgstbase-0.10.so.0
>>    NEEDED               libgstinterfaces-0.10.so.0
>>    NEEDED               libgstreamer-0.10.so.0
>>    NEEDED               libgobject-2.0.so.0
>>    NEEDED               libffi.so.6
>>    NEEDED               libgmodule-2.0.so.0
>>    NEEDED               libgthread-2.0.so.0
>>    NEEDED               libxml2.so.2
>>    NEEDED               libdl.so.2
>>    NEEDED               libglib-2.0.so.0
>>    NEEDED               libpthread.so.0
>>    NEEDED               libGLESv2.so.2
>>    NEEDED               libEGL.so.1
>>    NEEDED               libpng16.so.16
>>    NEEDED               libz.so.1
>>    NEEDED               libjpeg.so.8
>>    NEEDED               libm.so.6
>>    NEEDED               libc.so.6
>>    VERNEED              0x00001de4
>>    VERNEEDNUM           0x00000003
>>
>> Change-Id: Idf6f824847ee6978d8ecd2e793bbd0fd97b54c82
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> This should be add as depends, not rdepends. As the rdepends should be
> computed automatically :)
>

Specifically, would this be
	DEPENDS +=
or
	DEPENDS_${PN} +=
Otavio Salvador - July 26, 2013, 2:54 p.m.
On Fri, Jul 26, 2013 at 11:25 AM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> Thanks for the guidance, Otavio.
>
>
> On 07/26/2013 05:58 AM, Otavio Salvador wrote:
>>
>> On Thu, Jul 25, 2013 at 9:04 PM, Eric Nelson
>> <eric.nelson@boundarydevices.com> wrote:
>>>
>>> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
>>> inside of the libgstopengl.so library:
>>>
>>> ~/objdump -x myimage/1.0-r0/rootfs/usr/lib/gstreamer-0.10/libgstopengl.so
>>> \
>>>    | grep NEED
>>>    NEEDED               libgstgl-0.10.so.1
>>>    NEEDED               libgstcontroller-0.10.so.0
>>>    NEEDED               libgstfsl-0.10.so.0
>>>    NEEDED               libipu.so.0
>>>    NEEDED               librt.so.1
>>>    NEEDED               libgstvideo-0.10.so.0
>>>    NEEDED               libgstbase-0.10.so.0
>>>    NEEDED               libgstinterfaces-0.10.so.0
>>>    NEEDED               libgstreamer-0.10.so.0
>>>    NEEDED               libgobject-2.0.so.0
>>>    NEEDED               libffi.so.6
>>>    NEEDED               libgmodule-2.0.so.0
>>>    NEEDED               libgthread-2.0.so.0
>>>    NEEDED               libxml2.so.2
>>>    NEEDED               libdl.so.2
>>>    NEEDED               libglib-2.0.so.0
>>>    NEEDED               libpthread.so.0
>>>    NEEDED               libGLESv2.so.2
>>>    NEEDED               libEGL.so.1
>>>    NEEDED               libpng16.so.16
>>>    NEEDED               libz.so.1
>>>    NEEDED               libjpeg.so.8
>>>    NEEDED               libm.so.6
>>>    NEEDED               libc.so.6
>>>    VERNEED              0x00001de4
>>>    VERNEEDNUM           0x00000003
>>>
>>> Change-Id: Idf6f824847ee6978d8ecd2e793bbd0fd97b54c82
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>
>>
>> This should be add as depends, not rdepends. As the rdepends should be
>> computed automatically :)
>>
>
> Specifically, would this be
>         DEPENDS +=
> or
>         DEPENDS_${PN} +=
>

DEPENDS as it cannot be done package specific. The RDEPENDS need
/always/ to be package specific.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Eric Nelson - July 26, 2013, 4:07 p.m.
Thanks Otavio,

On 07/26/2013 07:54 AM, Otavio Salvador wrote:
> On Fri, Jul 26, 2013 at 11:25 AM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> Thanks for the guidance, Otavio.
>>
>>
>> On 07/26/2013 05:58 AM, Otavio Salvador wrote:
>>>
>>> On Thu, Jul 25, 2013 at 9:04 PM, Eric Nelson
>>> <eric.nelson@boundarydevices.com> wrote:
>>>>
>>>> There's a tight dependency on libjpeg.so.8 and libpng16.so.16
>>>> inside of the libgstopengl.so library:
>>>>
>>>
>>> This should be add as depends, not rdepends. As the rdepends should be
>>> computed automatically :)
>>>
>>
>> Specifically, would this be
>>          DEPENDS +=
>> or
>>          DEPENDS_${PN} +=
>>
>
> DEPENDS as it cannot be done package specific. The RDEPENDS need
> /always/ to be package specific.
>

Patch v2 is in flight.

Patch

diff --git a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
index 51eb457..a18ae17 100644
--- a/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
+++ b/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bbappend
@@ -3,6 +3,7 @@ 
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 PRINC := "${@int(PRINC) + 4}"
 
+RDEPENDS_${PN} += "jpeg libpng"
 DEPENDS_append_mx6 = " gst-fsl-plugin gpu-viv-bin-mx6q"
 
 SRC_URI_append_mx6 = " file://IMX_MMCODEC_3.0.35_4.0.0.patch"