Patchwork [10/11] chkconfig-alternatives-native: add git token in package version

login
register
mail settings
Submitter Emilia Ciobanu
Date July 18, 2013, 2:16 p.m.
Message ID <64f18573660b81394357d27a13ca89856fa94536.1374141084.git.emilia.maria.silvia.ciobanu@intel.com>
Download mbox | patch
Permalink /patch/53985/
State New
Headers show

Comments

Emilia Ciobanu - July 18, 2013, 2:16 p.m.
Git packages should have the following format:
    version+gitAUTOINC[r|-]+revision

Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
---
 .../chkconfig-alternatives-native_1.3.59.bb        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Chris Larson - July 18, 2013, 10:05 p.m.
On Thu, Jul 18, 2013 at 7:16 AM, Emilia Ciobanu <
emilia.maria.silvia.ciobanu@intel.com> wrote:

> Git packages should have the following format:
>     version+gitAUTOINC[r|-]+revision
>
> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
>

Just as an FYI, in case you didn't consider it, this may well result in
package versions going backwards. Not in this case, but the general one,
depending on the SRCREV.
Saul Wold - July 18, 2013, 11:34 p.m.
On 07/18/2013 03:05 PM, Chris Larson wrote:
> On Thu, Jul 18, 2013 at 7:16 AM, Emilia Ciobanu
> <emilia.maria.silvia.ciobanu@intel.com
> <mailto:emilia.maria.silvia.ciobanu@intel.com>> wrote:
>
>     Git packages should have the following format:
>          version+gitAUTOINC[r|-]+revision
>
>     Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com
>     <mailto:emilia.maria.silvia.ciobanu@intel.com>>
>
>
> Just as an FYI, in case you didn't consider it, this may well result in
> package versions going backwards. Not in this case, but the general one,
> depending on the SRCREV.

I did ask her to verify that these would not, I believe that she did that.

Sau!

> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-extended/chkconfig/chkconfig-alternatives-native_1.3.59.bb b/meta/recipes-extended/chkconfig/chkconfig-alternatives-native_1.3.59.bb
index 7fd34aa..0b1077f 100644
--- a/meta/recipes-extended/chkconfig/chkconfig-alternatives-native_1.3.59.bb
+++ b/meta/recipes-extended/chkconfig/chkconfig-alternatives-native_1.3.59.bb
@@ -12,7 +12,7 @@  SRC_URI = "git://github.com/kergoth/chkconfig;branch=sysroot"
 S = "${WORKDIR}/git"
 
 SRCREV = "cd437ecbd8986c894442f8fce1e0061e20f04dee"
-PV = "1.3.59+${SRCPV}"
+PV = "1.3.59+git${SRCPV}"
 
 inherit native