Patchwork [00/11] Add read PV into recipes

login
register
mail settings
Submitter Emilia Ciobanu
Date July 18, 2013, 2:16 p.m.
Message ID <cover.1374141084.git.emilia.maria.silvia.ciobanu@intel.com>
Download mbox
Permalink /patch/53965/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib emac/pv_fixes

Comments

Emilia Ciobanu - July 18, 2013, 2:16 p.m.
Tested for backwards packages.

The following changes since commit 3dee534f1e25109e0bdb681de0746c336f4b8840:

  lib/oeqa: fix dependecy check (2013-07-16 10:04:17 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib emac/pv_fixes
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=emac/pv_fixes

Emilia Ciobanu (11):
  rt-tests: add PV variable into recipe
  kmod: add PV variable into recipe
  hwlatdetect: add PV variable into recipe
  lttng-ust: add PV variable into recipe
  connman-gnome: add PV variable into recipe
  mtd-utils: add PV variable into recipe
  update-rc.d: add PV variable into recipe
  build-appliance-image: add PV variable into recipe
  lttng-modules: Append _git to recipe name and update PV with git
    token
  chkconfig-alternatives-native: add git token in package version
  docbook-sgml-dtd-4.5-native.bb: Add real PV inside the recipe

 .../connman/connman-gnome_0.7.bb                   |    2 ++
 .../images/build-appliance-image_8.0.bb            |    2 ++
 meta/recipes-core/update-rc.d/update-rc.d_0.7.bb   |    1 +
 .../docbook-sgml-dtd-4.5-native.bb                 |    1 +
 .../add-exclusion-to-mkfs-jffs2-git-2.patch        |    0
 ...t-cleanmarker-with-flash_erase--j-command.patch |    0
 meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb       |    2 +-
 .../chkconfig-alternatives-native_1.3.59.bb        |    2 +-
 meta/recipes-kernel/kmod/kmod_git.bb               |    1 +
 ...lttng-modules_2.2.0.bb => lttng-modules_git.bb} |    2 +-
 meta/recipes-kernel/lttng/lttng-ust_2.2.0.bb       |    2 +-
 meta/recipes-rt/rt-tests/hwlatdetect_0.85.bb       |    1 +
 meta/recipes-rt/rt-tests/rt-tests_0.85.bb          |    1 +
 13 files changed, 13 insertions(+), 4 deletions(-)
 rename meta/recipes-devtools/mtd/{mtd-utils-1.5.0 => mtd-utils}/add-exclusion-to-mkfs-jffs2-git-2.patch (100%)
 rename meta/recipes-devtools/mtd/{mtd-utils-1.5.0 => mtd-utils}/mtd-utils-fix-corrupt-cleanmarker-with-flash_erase--j-command.patch (100%)
 rename meta/recipes-kernel/lttng/{lttng-modules_2.2.0.bb => lttng-modules_git.bb} (97%)
Paul Eggleton - July 23, 2013, 9:33 a.m.
Hi Emilia,

On Thursday 18 July 2013 17:16:24 Emilia Ciobanu wrote:
> Tested for backwards packages.
> 
> The following changes since commit 3dee534f1e25109e0bdb681de0746c336f4b8840:
> 
>   lib/oeqa: fix dependecy check (2013-07-16 10:04:17 +0100)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib emac/pv_fixes
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=emac/pv_fixes
> 
> Emilia Ciobanu (11):
>   rt-tests: add PV variable into recipe
>   kmod: add PV variable into recipe
>   hwlatdetect: add PV variable into recipe
>   lttng-ust: add PV variable into recipe
>   connman-gnome: add PV variable into recipe
>   mtd-utils: add PV variable into recipe
>   update-rc.d: add PV variable into recipe
>   build-appliance-image: add PV variable into recipe
>   lttng-modules: Append _git to recipe name and update PV with git
>     token
>   chkconfig-alternatives-native: add git token in package version
>   docbook-sgml-dtd-4.5-native.bb: Add real PV inside the recipe

Reviewing these for the consolidated pull I noticed that one or two change the 
filename to _git (or that's already the filename) whereas others don't. 

For recipes that do point to a git repository but are fetching the revision 
tagged for a release, it is correct to say they have a fixed PV without 
+git${SRCPV}, which is why we have done this. However, perhaps for consistency 
and avoidance of future confusion if SRCREV is changed we should ignore this.

When the recipe does set PV, it is probably best that the recipe's filename 
doesn't contain a specific version otherwise it could be that it gets upgraded 
later and the version in the filename no longer matches the new PV value. 
Therefore I'd suggest If PV is being set and the recipe is fetching from a git 
repository, we should rename the recipe to use _git.

Cheers,
Paul