Patchwork [V3] util-linux: replace += with _append to EXTRA_OECONF_class-native

login
register
mail settings
Submitter Ming Liu
Date July 18, 2013, 1:54 a.m.
Message ID <1374112474-13597-1-git-send-email-ming.liu@windriver.com>
Download mbox | patch
Permalink /patch/53927/
State New
Headers show

Comments

Ming Liu - July 18, 2013, 1:54 a.m.
The native/nativesdk overrides of EXTRA_OECONF should take effect before
append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
of be appended at native/nativesdk build time.

Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
 meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Saul Wold - July 22, 2013, 3:48 a.m.
On 07/17/2013 06:54 PM, Ming Liu wrote:
> The native/nativesdk overrides of EXTRA_OECONF should take effect before
> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
> of be appended at native/nativesdk build time.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
>   meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> index 12f5021..3040476 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>   SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>
>   CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-native = " --disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate --disable-use-tty-group"
>

While this seems correct, it is causing some down stream issues with 
e2fsprogs-native and not finding the uuid library

>  Enabling testio debugging by default
> | checking for x86_64-linux-pkg-config... no
> | checking for pkg-config... /srv/ssd/sgw/builds/world/tmp/sysroots/x86_64-linux/usr/bin/pkg-config
> | checking pkg-config is at least version 0.9.0... yes
> | checking for uuid_generate in -luuid... no
> | configure: error: external uuid library not found
> | Configure failed. The contents of all config.log files follows to aid debugging
> | ERROR: oe_runconf failed

Can you please research this further.

Thanks
	Sau!
Ming Liu - July 23, 2013, 1:49 a.m.
On 07/22/2013 11:48 AM, Saul Wold wrote:
> On 07/17/2013 06:54 PM, Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden 
>> instead
>> of be appended at native/nativesdk build time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>>   meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb 
>> b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> index 12f5021..3040476 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>>   SRC_URI[sha256sum] = 
>> "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>
>>   CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate 
>> --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate 
>> --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-native = " --disable-fallocate 
>> --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate 
>> --disable-use-tty-group"
>>
>
> While this seems correct, it is causing some down stream issues with 
> e2fsprogs-native and not finding the uuid library
>
>>  Enabling testio debugging by default
>> | checking for x86_64-linux-pkg-config... no
>> | checking for pkg-config... 
>> /srv/ssd/sgw/builds/world/tmp/sysroots/x86_64-linux/usr/bin/pkg-config
>> | checking pkg-config is at least version 0.9.0... yes
>> | checking for uuid_generate in -luuid... no
>> | configure: error: external uuid library not found
>> | Configure failed. The contents of all config.log files follows to 
>> aid debugging
>> | ERROR: oe_runconf failed
>
> Can you please research this further.

OK, I will investigate this issue.

the best,
thank you

>
> Thanks
>     Sau!
>
>
>
>
Ming Liu - July 25, 2013, 10:11 a.m.
On 07/22/2013 11:48 AM, Saul Wold wrote:
> On 07/17/2013 06:54 PM, Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden 
>> instead
>> of be appended at native/nativesdk build time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>>   meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb 
>> b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> index 12f5021..3040476 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>>   SRC_URI[sha256sum] = 
>> "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>
>>   CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate 
>> --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate 
>> --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-native = " --disable-fallocate 
>> --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate 
>> --disable-use-tty-group"
>>
>
> While this seems correct, it is causing some down stream issues with 
> e2fsprogs-native and not finding the uuid library
Hi, Saul:

I did some investigations about this issue, it should be a regression 
introduced by commit 91c0f9e3: util-linux: move libraries to 
base_libdir. It tried to transfer "--libdir=${base_libdir}" to 
EXTRA_OECONF at configure status, which conflicted with following code 
in configure.ac:
.........
case $libdir in
  ${exec_prefix}/* | ${prefix}/* | /usr/*)
     usrlib_execdir=$libdir ;;
  *)
     usrlib_execdir='${exec_prefix}'$libdir ;;
esac
AC_SUBST([usrlib_execdir])
........

It resulted a invalid usrlib_execdir, and therefore caused libuuid.so 
link unreachable. This would make packages relies on uuid fail to 
compile, like e2fsprogs.

Anyway, it could be fixed by appending "--prefix=${base_prefix} 
--exec_prefix=${base_prefix}" to EXTRA_OECONF and we don't need to worry 
it, however, things go to more complicated after applied 91c0f9e3 that 
it also breaks pkgconfig, because all *.pc go to ${base_libdir} instead 
of  ${libdir} though pkg-config looks for files in explicitly fixed 
directories set by PKG_CONFIG_PATH, which in this case is: 
${STAGING_DATADIR}/pkgconfig${EXTRA_NATIVE_PKGCONFIG_PATH}, that finally 
causes other packages fail to detect libuuid by pkg-config.

Two approaches to fix this pkg-config failure, first, we could move *.pc 
to ${libdir} at do_intall stage, and the other, modify PKG_CONFIG_PATH, 
adding ${libdir}/pkgconfig into it. Which one do you prefer? Or we could 
just revert commit 91c0f9e3?

the best,
thank you
>
>>  Enabling testio debugging by default
>> | checking for x86_64-linux-pkg-config... no
>> | checking for pkg-config... 
>> /srv/ssd/sgw/builds/world/tmp/sysroots/x86_64-linux/usr/bin/pkg-config
>> | checking pkg-config is at least version 0.9.0... yes
>> | checking for uuid_generate in -luuid... no
>> | configure: error: external uuid library not found
>> | Configure failed. The contents of all config.log files follows to 
>> aid debugging
>> | ERROR: oe_runconf failed
>
> Can you please research this further.
>
> Thanks
>     Sau!
>
>
>
>
Koen Kooi - July 25, 2013, 12:55 p.m.
Op 22 jul. 2013, om 05:48 heeft Saul Wold <sgw@linux.intel.com> het volgende geschreven:

> On 07/17/2013 06:54 PM, Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
>> of be appended at native/nativesdk build time.
>> 
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>>  meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> index 12f5021..3040476 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>>  SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>> 
>>  CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-native = " --disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate --disable-use-tty-group"
>> 
> 
> While this seems correct, it is causing some down stream issues with e2fsprogs-native and not finding the uuid library

I ran into this when backporting fixes for texinfoand gcc 4.8 hosts from master to danny and I used this hack:

	https://github.com/Angstrom-distribution/oe-core/commit/9cd55347769555e89374e83d011196ae5450204a

Not pretty, but it only affects the -native builds.

regards,

Koen
Ming Liu - July 26, 2013, 1:25 a.m.
On 07/25/2013 08:55 PM, Koen Kooi wrote:
> Op 22 jul. 2013, om 05:48 heeft Saul Wold <sgw@linux.intel.com> het volgende geschreven:
>
>> On 07/17/2013 06:54 PM, Ming Liu wrote:
>>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>>> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
>>> of be appended at native/nativesdk build time.
>>>
>>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>>> ---
>>>   meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>>> index 12f5021..3040476 100644
>>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>>>   SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>>
>>>   CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>>> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
>>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
>>> +EXTRA_OECONF_append_class-native = " --disable-fallocate --disable-use-tty-group"
>>> +EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate --disable-use-tty-group"
>>>
>> While this seems correct, it is causing some down stream issues with e2fsprogs-native and not finding the uuid library
> I ran into this when backporting fixes for texinfoand gcc 4.8 hosts from master to danny and I used this hack:
>
> 	https://github.com/Angstrom-distribution/oe-core/commit/9cd55347769555e89374e83d011196ae5450204a
>
> Not pretty, but it only affects the -native builds.

This hack may work for e2fsprogs-native because it uses a internal 
libuuid instead of detecting it in system, but it doesn't hit the root 
cause of this issue, as I described in this thread.

the best,
thank you
>
> regards,
>
> Koen
>

Patch

diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
index 12f5021..3040476 100644
--- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
@@ -18,5 +18,5 @@  SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
 SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
 
 CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-native = " --disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-nativesdk = " --disable-fallocate --disable-use-tty-group"