Patchwork [meta-fsl-ppc] perf: Remove hard coded include to /usr/local/include in Makefile

login
register
mail settings
Submitter Zhenhua Luo
Date July 17, 2013, 11:06 a.m.
Message ID <1374059203-24453-1-git-send-email-zhenhua.luo@freescale.com>
Download mbox | patch
Permalink /patch/53877/
State Accepted
Headers show

Comments

Zhenhua Luo - July 17, 2013, 11:06 a.m.
Having /usr/local/include hardcoded into the makefile is not necessary
as this is automatically included by GCC. It also infects cross-compile
builds with the host systems includes.

Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
---
 ...-include-to-usr-local-include-in-Makefile.patch |   36 ++++++++++++++++++++
 recipes-kernel/linux/linux-qoriq-sdk.bb            |    2 ++
 2 files changed, 38 insertions(+)
 create mode 100644 recipes-kernel/linux/files/libtraceevent-Remove-hard-coded-include-to-usr-local-include-in-Makefile.patch
Otavio Salvador - July 17, 2013, 12:21 p.m.
On Wed, Jul 17, 2013 at 8:06 AM, Zhenhua Luo <zhenhua.luo@freescale.com> wrote:
> Having /usr/local/include hardcoded into the makefile is not necessary
> as this is automatically included by GCC. It also infects cross-compile
> builds with the host systems includes.
>
> Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Zhenhua Luo - July 17, 2013, 1:04 p.m.
Applied. 


Best Regards,

Zhenhua


> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Wednesday, July 17, 2013 8:22 PM
> To: Luo Zhenhua-B19537
> Cc: meta-freescale@yoctoproject.org; Yu Zongchun-B40527
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] perf: Remove hard
> coded include to /usr/local/include in Makefile
> 
> On Wed, Jul 17, 2013 at 8:06 AM, Zhenhua Luo <zhenhua.luo@freescale.com>
> wrote:
> > Having /usr/local/include hardcoded into the makefile is not necessary
> > as this is automatically included by GCC. It also infects
> > cross-compile builds with the host systems includes.
> >
> > Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
> 
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/recipes-kernel/linux/files/libtraceevent-Remove-hard-coded-include-to-usr-local-include-in-Makefile.patch b/recipes-kernel/linux/files/libtraceevent-Remove-hard-coded-include-to-usr-local-include-in-Makefile.patch
new file mode 100644
index 0000000..15c397d
--- /dev/null
+++ b/recipes-kernel/linux/files/libtraceevent-Remove-hard-coded-include-to-usr-local-include-in-Makefile.patch
@@ -0,0 +1,36 @@ 
+Upstream-Status: Backport
+
+From b9e8c37220c80e78289a1e87b50c09418eb59a7e Mon Sep 17 00:00:00 2001
+From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
+Date: Fri, 08 Mar 2013 11:21:52 +0000
+Subject: libtraceevent: Remove hard coded include to /usr/local/include in Makefile
+
+having /usr/local/include hardcoded into the makefile is not necessary
+as this is automatically included by GCC. It also infects cross-compile
+builds with the host systems includes.
+
+Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
+Acked-by: Namhyung Kim <namhyung@kernel.org>
+Cc: Ingo Molnar <mingo@redhat.com>
+Cc: Paul Mackerras <paulus@samba.org>
+Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
+Link: http://lkml.kernel.org/r/1362741712-21308-1-git-send-email-ml@communistcode.co.uk
+Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
+---
+(limited to 'tools/lib/traceevent/Makefile')
+
+diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
+index a20e320..0b0a907 100644
+--- a/tools/lib/traceevent/Makefile
++++ b/tools/lib/traceevent/Makefile
+@@ -122,7 +122,7 @@ export Q VERBOSE
+ 
+ EVENT_PARSE_VERSION = $(EP_VERSION).$(EP_PATCHLEVEL).$(EP_EXTRAVERSION)
+ 
+-INCLUDES = -I. -I/usr/local/include $(CONFIG_INCLUDES)
++INCLUDES = -I. $(CONFIG_INCLUDES)
+ 
+ # Set compile option CFLAGS if not set elsewhere
+ CFLAGS ?= -g -Wall
+--
+cgit v0.9.2
diff --git a/recipes-kernel/linux/linux-qoriq-sdk.bb b/recipes-kernel/linux/linux-qoriq-sdk.bb
index 502132f..7dd7059 100644
--- a/recipes-kernel/linux/linux-qoriq-sdk.bb
+++ b/recipes-kernel/linux/linux-qoriq-sdk.bb
@@ -7,6 +7,8 @@  LICENSE = "GPLv2"
 
 require recipes-kernel/linux/linux-qoriq-sdk.inc
 
+SRC_URI += "file://libtraceevent-Remove-hard-coded-include-to-usr-local-include-in-Makefile.patch"
+
 PR = "${INC_PR}.1"
 
 DEPENDS_append = " libgcc"