Patchwork [V2] util-linux: replace += with _append to EXTRA_OECONF_class-native

login
register
mail settings
Submitter Ming Liu
Date July 17, 2013, 8:41 a.m.
Message ID <1374050497-20809-1-git-send-email-ming.liu@windriver.com>
Download mbox | patch
Permalink /patch/53833/
State New
Headers show

Comments

Ming Liu - July 17, 2013, 8:41 a.m.
The native/nativesdk overrides of EXTRA_OECONF should take effect before
append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
of be appended at native/nativesdk build time.

Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
 meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Ross Burton - July 17, 2013, 12:07 p.m.
On 17 July 2013 09:41, Ming Liu <ming.liu@windriver.com> wrote:
> +EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"

_append won't add a leading space so you're making a massive
assumption here, please add a leading space for safety.

Ross
Ming Liu - July 18, 2013, 1:30 a.m.
On 07/17/2013 08:07 PM, Burton, Ross wrote:
> On 17 July 2013 09:41, Ming Liu <ming.liu@windriver.com> wrote:
>> +EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"
> _append won't add a leading space so you're making a massive
> assumption here, please add a leading space for safety.
Yes, thanks for the reminding, I will send the V3.

the best,
thank you

> Ross
>
>

Patch

diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
index 12f5021..cc11977 100644
--- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
@@ -18,5 +18,5 @@  SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
 SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
 
 CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"