Patchwork [v2] valgrind: added perl dependency

login
register
mail settings
Submitter eu@felipetonello.com
Date July 16, 2013, 10:16 p.m.
Message ID <1374012965-4556-1-git-send-email-eu@felipetonello.com>
Download mbox | patch
Permalink /patch/53783/
State New
Headers show

Comments

eu@felipetonello.com - July 16, 2013, 10:16 p.m.
From: "Felipe F. Tonello" <eu@felipetonello.com>

This is necessary since the valgrind package depends on /usr/bin/perl.

This patch will fix this error while installing into rootfs:
Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Saul Wold - July 16, 2013, 10:54 p.m.
On 07/16/2013 03:16 PM, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> This is necessary since the valgrind package depends on /usr/bin/perl.
>
> This patch will fix this error while installing into rootfs:
> Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl
>
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>   meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> index 3520d49..4ee1b64 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
>
>   X11DEPENDS = "virtual/libx11"
>   DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> -PR = "r8"
> +PR = "r9"
>
PR Bump is not needed, mentioned this in past reviews.

Sau!
>   SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>   	   file://fix_issue_caused_by_ccache.patch \
> @@ -37,6 +37,8 @@ do_install_append () {
>       install -m 644 ${B}/default.supp ${D}/${libdir}/valgrind/
>   }
>
> +RDEPENDS_${PN} += "perl"
> +
>   FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
>   RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
>   RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
>
eu@felipetonello.com - July 16, 2013, 11:09 p.m.
Hum, I didn't noticed. Sorry.

I will send another patch.

On Tue, Jul 16, 2013 at 3:54 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 07/16/2013 03:16 PM, eu@felipetonello.com wrote:
>>
>> From: "Felipe F. Tonello" <eu@felipetonello.com>
>>
>> This is necessary since the valgrind package depends on /usr/bin/perl.
>>
>> This patch will fix this error while installing into rootfs:
>> Computing transaction...error: Can't install
>> valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl
>>
>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>> ---
>>   meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
>> b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
>> index 3520d49..4ee1b64 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
>> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=c46082167a314d785d012a244748d803 \
>>
>>   X11DEPENDS = "virtual/libx11"
>>   DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}',
>> '', d)}"
>> -PR = "r8"
>> +PR = "r9"
>>
> PR Bump is not needed, mentioned this in past reviews.
>
> Sau!
>
>>   SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>            file://fix_issue_caused_by_ccache.patch \
>> @@ -37,6 +37,8 @@ do_install_append () {
>>       install -m 644 ${B}/default.supp ${D}/${libdir}/valgrind/
>>   }
>>
>> +RDEPENDS_${PN} += "perl"
>> +
>>   FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
>>   RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
>>   RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
>>
>

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
index 3520d49..4ee1b64 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
 
 X11DEPENDS = "virtual/libx11"
 DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
-PR = "r8"
+PR = "r9"
 
 SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 	   file://fix_issue_caused_by_ccache.patch \
@@ -37,6 +37,8 @@  do_install_append () {
     install -m 644 ${B}/default.supp ${D}/${libdir}/valgrind/
 }
 
+RDEPENDS_${PN} += "perl"
+
 FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
 RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
 RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"