Patchwork [2/2] bluez4: conflicts with/replaces bluez5

login
register
mail settings
Submitter Cristian Iorga
Date July 15, 2013, 1:50 p.m.
Message ID <809bd57326a24570dfd583e33821f42c4e7b930a.1373896070.git.cristian.iorga@intel.com>
Download mbox | patch
Permalink /patch/53695/
State New
Headers show

Comments

Cristian Iorga - July 15, 2013, 1:50 p.m.
- RCONFLICTS/RREPLACES bluez5

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 meta/recipes-connectivity/bluez/bluez4_4.101.bb |    3 +++
 1 file changed, 3 insertions(+)
Saul Wold - July 15, 2013, 3:24 p.m.
On 07/15/2013 06:50 AM, Cristian Iorga wrote:
> - RCONFLICTS/RREPLACES bluez5
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
>   meta/recipes-connectivity/bluez/bluez4_4.101.bb |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-connectivity/bluez/bluez4_4.101.bb b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
> index f48adfd..b91c9c3 100644
> --- a/meta/recipes-connectivity/bluez/bluez4_4.101.bb
> +++ b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
> @@ -11,6 +11,9 @@ SRC_URI += "file://bluetooth.conf \
>   SRC_URI[md5sum] = "fb42cb7038c380eb0e2fa208987c96ad"
>   SRC_URI[sha256sum] = "59738410ade9f0e61a13c0f77d9aaffaafe49ba9418107e4ad75fe52846f7487"
>
> +RCONFLICTS_${PN} = "bluez5"
> +RREPLACES_${PN} = "bluez5"
> +
Is the RREPLACES correct here and in the bluez5 recipe?

I know they conflict, but I did not think they could replace each other.

Sau!

>   do_install_append() {
>   	install -m 0644 ${S}/audio/audio.conf ${D}/${sysconfdir}/bluetooth/
>   	install -m 0644 ${S}/network/network.conf ${D}/${sysconfdir}/bluetooth/
>
Phil Blundell - July 15, 2013, 4:27 p.m.
> +RCONFLICTS_${PN} = "bluez5"
> +RREPLACES_${PN} = "bluez5"

I'm not sure that this necessarily does quite what you want.  What
exactly were you trying to achieve with that RREPLACES?

p.
Ross Burton - July 15, 2013, 5 p.m.
On 15 July 2013 17:27, Phil Blundell <pb@pbcl.net> wrote:
>> +RCONFLICTS_${PN} = "bluez5"
>> +RREPLACES_${PN} = "bluez5"
>
> I'm not sure that this necessarily does quite what you want.  What
> exactly were you trying to achieve with that RREPLACES?

I remember when this series was first published there was a long
debate over the exact lines required.  That said, I can't see why we
need replaces either.

Ross
Cristian Iorga - July 16, 2013, 2:29 p.m.
Please see my V3 cover letter to observe the reasoning behind RREPLACES presence.

Thanks,
Cristian

-----Original Message-----
From: Burton, Ross [mailto:ross.burton@intel.com] 
Sent: Monday, July 15, 2013 8:01 PM
To: Phil Blundell
Cc: Iorga, Cristian; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 2/2] bluez4: conflicts with/replaces bluez5

On 15 July 2013 17:27, Phil Blundell <pb@pbcl.net> wrote:
>> +RCONFLICTS_${PN} = "bluez5"
>> +RREPLACES_${PN} = "bluez5"
>
> I'm not sure that this necessarily does quite what you want.  What 
> exactly were you trying to achieve with that RREPLACES?

I remember when this series was first published there was a long debate over the exact lines required.  That said, I can't see why we need replaces either.

Ross

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4_4.101.bb b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
index f48adfd..b91c9c3 100644
--- a/meta/recipes-connectivity/bluez/bluez4_4.101.bb
+++ b/meta/recipes-connectivity/bluez/bluez4_4.101.bb
@@ -11,6 +11,9 @@  SRC_URI += "file://bluetooth.conf \
 SRC_URI[md5sum] = "fb42cb7038c380eb0e2fa208987c96ad"
 SRC_URI[sha256sum] = "59738410ade9f0e61a13c0f77d9aaffaafe49ba9418107e4ad75fe52846f7487"
 
+RCONFLICTS_${PN} = "bluez5"
+RREPLACES_${PN} = "bluez5"
+
 do_install_append() {
 	install -m 0644 ${S}/audio/audio.conf ${D}/${sysconfdir}/bluetooth/
 	install -m 0644 ${S}/network/network.conf ${D}/${sysconfdir}/bluetooth/