Patchwork [0/1] eglibc: enable eglibc configurability V2

login
register
mail settings
Submitter Kang Kai
Date June 3, 2011, 6:47 a.m.
Message ID <cover.1307083232.git.kai.kang@windriver.com>
Download mbox
Permalink /patch/5369/
State New, archived
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib.git kangkai/distro

Comments

Kang Kai - June 3, 2011, 6:47 a.m.
From: Kang Kai <kai.kang@windriver.com>

Hi Saul,

I update the patch that move "DISTRO_FEATURES_EGLIBC ??=" to eglibc.inc

Migrate configurability from oe, try to shrink minimal image size

The switch is in local.conf.sample, uncomment the line
DISTRO_FEATURES_EGLIBC = ""
and write what options you want to enable.

If want to disable locale-code charsets or locales, you have to uncomment
PACKAGE_NO_GCONV = 1
Because without this, it fails on package_do_split_gconvs in libc-package.bbclass

The following changes since commit 484c4e73245c93a08413cd204513bf5c5698b994:

  clutter-1.6: Add patch to update gettext macro version (2011-06-01 18:34:37 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib.git kangkai/distro
  http://git.pokylinux.org/cgit.cgi//log/?h=kangkai/distro

Kang Kai (1):
  eglibc: migrate configurability from oe

 meta-yocto/conf/local.conf.sample                  |    9 +++
 .../eglibc-2.13-fix-macro-RTLD_DEBUG.patch         |   20 +++++++
 meta/recipes-core/eglibc/eglibc-options.inc        |   55 ++++++++++++++++++++
 meta/recipes-core/eglibc/eglibc.inc                |   13 +++++
 meta/recipes-core/eglibc/eglibc_2.13.bb            |    4 +-
 5 files changed, 100 insertions(+), 1 deletions(-)
 create mode 100644 meta/recipes-core/eglibc/eglibc-2.13/eglibc-2.13-fix-macro-RTLD_DEBUG.patch
 create mode 100644 meta/recipes-core/eglibc/eglibc-options.inc
Phil Blundell - June 3, 2011, 11:32 a.m.
On Fri, 2011-06-03 at 14:47 +0800, Kang Kai wrote:
> If want to disable locale-code charsets or locales, you have to uncomment
> PACKAGE_NO_GCONV = 1
> Because without this, it fails on package_do_split_gconvs in libc-package.bbclass

Can we not just fix libc-package.bbclass to stop it failing in that
situation?  It seems a bit sad to require an extra "flip this switch to
make it work" kind of variable.

p.
Richard Purdie - June 3, 2011, 11:50 a.m.
On Fri, 2011-06-03 at 12:32 +0100, Phil Blundell wrote:
> On Fri, 2011-06-03 at 14:47 +0800, Kang Kai wrote:
> > If want to disable locale-code charsets or locales, you have to uncomment
> > PACKAGE_NO_GCONV = 1
> > Because without this, it fails on package_do_split_gconvs in libc-package.bbclass
> 
> Can we not just fix libc-package.bbclass to stop it failing in that
> situation?  It seems a bit sad to require an extra "flip this switch to
> make it work" kind of variable.

That was my point in the earlier email :)

Cheers,

Richard
Phil Blundell - June 3, 2011, 12:06 p.m.
On Fri, 2011-06-03 at 12:50 +0100, Richard Purdie wrote:
> That was my point in the earlier email :)

Ah right, yes.  Evidently I hadn't had enough of my coffee when I
replied to that one. :-}

p.