Patchwork [meta-oe,1/3] protobuf: add recipe from meta-virtualization and tweak

login
register
mail settings
Submitter Paul Eggleton
Date July 13, 2013, 2:47 p.m.
Message ID <f70cc47eb65740d7307194b9a4e3414f78180348.1373726565.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/53635/
State Accepted, archived
Commit 54d9e46a44ff57aafa180c835343fddaca4687df
Headers show

Comments

Paul Eggleton - July 13, 2013, 2:47 p.m.
* Add proper SUMMARY
* Break long DESCRIPTION onto multiple lines
* Reorder some lines

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
Samuel Stirtzel - July 16, 2013, 3:36 p.m.
2013/7/13 Paul Eggleton <paul.eggleton@linux.intel.com>:
> * Add proper SUMMARY
> * Break long DESCRIPTION onto multiple lines
> * Reorder some lines
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
>
> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> new file mode 100644
> index 0000000..c4ed5e6
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> @@ -0,0 +1,20 @@
> +SUMMARY = "Protocol Buffers - structured data serialisation mechanism"
> +DESCRIPTION = "Protocol Buffers are a way of encoding structured data in an \
> +efficient yet extensible format. Google uses Protocol Buffers for almost \
> +all of its internal RPC protocols and file formats."
> +HOMEPAGE = "http://code.google.com/p/protobuf/"
> +SECTION = "console/tools"
> +LICENSE = "BSD-3-Clause"
> +
> +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=af6809583bfde9a31595a58bb4a24514"
> +
> +SRC_URI = "http://protobuf.googlecode.com/files/protobuf-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "dc84e9912ea768baa1976cb7bbcea7b5"
> +SRC_URI[sha256sum] = "eac6969b617f397247e805267da2b0db3ff9e5a9163b123503a192fbb5776567"
> +
> +EXTRA_OECONF += " --with-protoc=echo"


Hi,

do you know why it doesn't use:

EXTRA_OECONF += "--with-protoc=${STAGING_BINDIR_NATIVE}/protoc"

in combination with DEPENDS += "protobuf-native" in protobuf?
Instead the recipe that uses protobuf/protoc depends on protobuf and
protobuf-native.

My assumption is, that the result would the same, and it is currently
skipping tests for the cross compiled protobuf.
Or does it archive anything else?



--
Regards
Samuel
Paul Eggleton - July 16, 2013, 5:07 p.m.
On Tuesday 16 July 2013 17:36:08 Samuel Stirtzel wrote:
> 2013/7/13 Paul Eggleton <paul.eggleton@linux.intel.com>:
> > * Add proper SUMMARY
> > * Break long DESCRIPTION onto multiple lines
> > * Reorder some lines
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > 
> >  meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb | 20
> >  ++++++++++++++++++++ 1 file changed, 20 insertions(+)
> >  create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> > 
> > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> > b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb new file mode
> > 100644
> > index 0000000..c4ed5e6
> > --- /dev/null
> > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
> > @@ -0,0 +1,20 @@
> > +SUMMARY = "Protocol Buffers - structured data serialisation mechanism"
> > +DESCRIPTION = "Protocol Buffers are a way of encoding structured data in
> > an \ +efficient yet extensible format. Google uses Protocol Buffers for
> > almost \ +all of its internal RPC protocols and file formats."
> > +HOMEPAGE = "http://code.google.com/p/protobuf/"
> > +SECTION = "console/tools"
> > +LICENSE = "BSD-3-Clause"
> > +
> > +LIC_FILES_CHKSUM =
> > "file://COPYING.txt;md5=af6809583bfde9a31595a58bb4a24514" +
> > +SRC_URI = "http://protobuf.googlecode.com/files/protobuf-${PV}.tar.gz"
> > +
> > +SRC_URI[md5sum] = "dc84e9912ea768baa1976cb7bbcea7b5"
> > +SRC_URI[sha256sum] =
> > "eac6969b617f397247e805267da2b0db3ff9e5a9163b123503a192fbb5776567" +
> > +EXTRA_OECONF += " --with-protoc=echo"
> 
> Hi,
> 
> do you know why it doesn't use:
> 
> EXTRA_OECONF += "--with-protoc=${STAGING_BINDIR_NATIVE}/protoc"
> 
> in combination with DEPENDS += "protobuf-native" in protobuf?
> Instead the recipe that uses protobuf/protoc depends on protobuf and
> protobuf-native.
> 
> My assumption is, that the result would the same, and it is currently
> skipping tests for the cross compiled protobuf.
> Or does it archive anything else?

I'm not sure, this bit came from the original protobuf recipe in meta-
virtualization. David, you seem to have written this recipe originally, do you 
have any insight into the above?

Thanks,
Paul

Patch

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
new file mode 100644
index 0000000..c4ed5e6
--- /dev/null
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_2.4.1.bb
@@ -0,0 +1,20 @@ 
+SUMMARY = "Protocol Buffers - structured data serialisation mechanism"
+DESCRIPTION = "Protocol Buffers are a way of encoding structured data in an \
+efficient yet extensible format. Google uses Protocol Buffers for almost \
+all of its internal RPC protocols and file formats."
+HOMEPAGE = "http://code.google.com/p/protobuf/"
+SECTION = "console/tools"
+LICENSE = "BSD-3-Clause"
+
+LIC_FILES_CHKSUM = "file://COPYING.txt;md5=af6809583bfde9a31595a58bb4a24514"
+
+SRC_URI = "http://protobuf.googlecode.com/files/protobuf-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "dc84e9912ea768baa1976cb7bbcea7b5"
+SRC_URI[sha256sum] = "eac6969b617f397247e805267da2b0db3ff9e5a9163b123503a192fbb5776567"
+
+EXTRA_OECONF += " --with-protoc=echo"
+
+inherit autotools
+
+BBCLASSEXTEND = "native nativesdk"