Patchwork ncurses: add xterm-256color to terminfo-base

login
register
mail settings
Submitter Saul Wold
Date July 12, 2013, 12:53 a.m.
Message ID <1373590411-6276-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/53529/
State Accepted
Commit caa4130c685f04e2c9ac06126d4a8b09fa161cf6
Headers show

Comments

Saul Wold - July 12, 2013, 12:53 a.m.
This is to address the buildtools-tarball still having problems with certain
xterms

[YOCTO #4835]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/ncurses/ncurses.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Mark Hatle - July 12, 2013, 1:29 a.m.
On 7/11/13 7:53 PM, Saul Wold wrote:
> This is to address the buildtools-tarball still having problems with certain
> xterms
>
> [YOCTO #4835]

This is a reasonable workaround, but the real problem seems to be that nativesdk 
python/ncurses return crap (strings with embedded control codes) when they don't 
know what the TERM is.  I think this is the real underlying problem that needs 
to be fixed, unfortunately I have no idea what the cause is.

The alternative is to somehow enforce terminal settings when using the 
buildtools-tarball are one of the known terminals.

--Mark

> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   meta/recipes-core/ncurses/ncurses.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index 2ed1bba..671daf8 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -174,7 +174,7 @@ shell_do_install() {
>
>           # include some basic terminfo files
>           # stolen ;) from gentoo and modified a bit
> -        for x in ansi console dumb linux rxvt screen sun vt{52,100,102,200,220} xterm-color xterm-xfree86
> +        for x in ansi console dumb linux rxvt screen sun vt{52,100,102,200,220} xterm-color xterm-xfree86 xterm-256color
>           do
>                   local termfile="$(find "${D}${datadir}/terminfo/" -name "${x}" 2>/dev/null)"
>                   local basedir="$(basename $(dirname "${termfile}"))"
>

Patch

diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
index 2ed1bba..671daf8 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -174,7 +174,7 @@  shell_do_install() {
 
         # include some basic terminfo files
         # stolen ;) from gentoo and modified a bit
-        for x in ansi console dumb linux rxvt screen sun vt{52,100,102,200,220} xterm-color xterm-xfree86
+        for x in ansi console dumb linux rxvt screen sun vt{52,100,102,200,220} xterm-color xterm-xfree86 xterm-256color
         do
                 local termfile="$(find "${D}${datadir}/terminfo/" -name "${x}" 2>/dev/null)"
                 local basedir="$(basename $(dirname "${termfile}"))"