Patchwork xdg-utils: upgrade to 1.1.0-rc1

login
register
mail settings
Submitter Cristian Iorga
Date July 11, 2013, 12:51 p.m.
Message ID <1373547110-11539-1-git-send-email-cristian.iorga@intel.com>
Download mbox | patch
Permalink /patch/53511/
State New
Headers show

Comments

Cristian Iorga - July 11, 2013, 12:51 p.m.
This version of xdg-utils is needed by BA in order
to associate correctly types of files with PCManFM
file manager.
The release cycle of xdg-utils is very slow, so this
is the best shot of a stable version available for
YP 1.5 release.
As a reference, the previous stable version was released in 2007.
Also, desktop Linux distros use this release candidate as a stable
version, for example, Ubuntu 12.04.

Part of the implementation of [YOCTO #2370].

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 .../xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb}  |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
 rename meta/recipes-extended/xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb} (80%)
Koen Kooi - April 28, 2014, 2:26 p.m.
Op 11 jul. 2013, om 14:51 heeft Cristian Iorga <cristian.iorga@intel.com> het volgende geschreven:

> This version of xdg-utils is needed by BA in order
> to associate correctly types of files with PCManFM
> file manager.
> The release cycle of xdg-utils is very slow, so this
> is the best shot of a stable version available for
> YP 1.5 release.
> As a reference, the previous stable version was released in 2007.
> Also, desktop Linux distros use this release candidate as a stable
> version, for example, Ubuntu 12.04.
> 
> Part of the implementation of [YOCTO #2370].
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> .../xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb}  |    9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> rename meta/recipes-extended/xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb} (80%)

This has been in OE-core for a while, but I do have to point out that it violates the version policy, it should be: 1.0.2+1.1.0-rc1
Cristian Iorga - April 28, 2014, 2:40 p.m.
Hello Koen,

Care to go into details why exactly the version is wrong?
In YP Dev Manual, my recipe is given as an example of correct naming:
http://www.yoctoproject.org/docs/current/dev-manual/dev-manual.html#new-recipe-storing-and-naming-the-recipe
Quote:
"Naming Your Recipe: When you name your recipe, you need to follow this naming convention:

     <basename>_<version>.bb
                    

Use lower-cased characters and do not include the reserved suffixes -native, -cross, -initial, or -dev casually (i.e. do not use them as part of your recipe name unless the string applies). Here are some examples:

     cups_1.7.0.bb
     gawk_4.0.2.bb
     xdg-utils_1.1.0-rc1.bb"

Also, in meta-openembedded, I found several recipes following the same pattern, i.e. fim and irssi packages.

Regards,
Cristian
YP
Intel Corporation

-----Original Message-----
From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
Sent: Monday, April 28, 2014 5:26 PM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] xdg-utils: upgrade to 1.1.0-rc1


Op 11 jul. 2013, om 14:51 heeft Cristian Iorga <cristian.iorga@intel.com> het volgende geschreven:

> This version of xdg-utils is needed by BA in order to associate 
> correctly types of files with PCManFM file manager.
> The release cycle of xdg-utils is very slow, so this is the best shot 
> of a stable version available for YP 1.5 release.
> As a reference, the previous stable version was released in 2007.
> Also, desktop Linux distros use this release candidate as a stable 
> version, for example, Ubuntu 12.04.
> 
> Part of the implementation of [YOCTO #2370].
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> .../xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb}  |    9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-) rename 
> meta/recipes-extended/xdg-utils/{xdg-utils_1.0.2.bb => 
> xdg-utils_1.1.0-rc1.bb} (80%)

This has been in OE-core for a while, but I do have to point out that it violates the version policy, it should be: 1.0.2+1.1.0-rc1
Koen Kooi - April 28, 2014, 2:45 p.m.
Op 28 apr. 2014, om 16:40 heeft Iorga, Cristian <cristian.iorga@intel.com> het volgende geschreven:

> Hello Koen,
> 
> Care to go into details why exactly the version is wrong?

http://www.openembedded.org/wiki/Versioning_Policy

> In YP Dev Manual, my recipe is given as an example of correct naming:
> http://www.yoctoproject.org/docs/current/dev-manual/dev-manual.html#new-recipe-storing-and-naming-the-recipe
> Quote:
> "Naming Your Recipe: When you name your recipe, you need to follow this naming convention:
> 
>     <basename>_<version>.bb
> 
> 
> Use lower-cased characters and do not include the reserved suffixes -native, -cross, -initial, or -dev casually (i.e. do not use them as part of your recipe name unless the string applies). Here are some examples:
> 
>     cups_1.7.0.bb
>     gawk_4.0.2.bb
>     xdg-utils_1.1.0-rc1.bb"

And that's why I only read OE policy docs when working on OE.

> Also, in meta-openembedded, I found several recipes following the same pattern, i.e. fim and irssi packages.

koen@beast:/build/v2014.06/sources/meta-openembedded$ grep PV ./meta-oe/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
REALPV = "0.8.16-rc1"
PV = "0.8.15+${REALPV}"
SRC_URI = "http://irssi.org/files/irssi-${REALPV}.tar.gz"
S = "${WORKDIR}/irssi-${REALPV}"

But 'fim' violates versioning policy as well.


> 
> Regards,
> Cristian
> YP
> Intel Corporation
> 
> -----Original Message-----
> From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
> Sent: Monday, April 28, 2014 5:26 PM
> To: Iorga, Cristian
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] xdg-utils: upgrade to 1.1.0-rc1
> 
> 
> Op 11 jul. 2013, om 14:51 heeft Cristian Iorga <cristian.iorga@intel.com> het volgende geschreven:
> 
>> This version of xdg-utils is needed by BA in order to associate 
>> correctly types of files with PCManFM file manager.
>> The release cycle of xdg-utils is very slow, so this is the best shot 
>> of a stable version available for YP 1.5 release.
>> As a reference, the previous stable version was released in 2007.
>> Also, desktop Linux distros use this release candidate as a stable 
>> version, for example, Ubuntu 12.04.
>> 
>> Part of the implementation of [YOCTO #2370].
>> 
>> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
>> ---
>> .../xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb}  |    9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-) rename 
>> meta/recipes-extended/xdg-utils/{xdg-utils_1.0.2.bb => 
>> xdg-utils_1.1.0-rc1.bb} (80%)
> 
> This has been in OE-core for a while, but I do have to point out that it violates the version policy, it should be: 1.0.2+1.1.0-rc1
>
Cristian Iorga - April 28, 2014, 2:49 p.m.
Will do, thanks for the context.

-----Original Message-----
From: Koen Kooi [mailto:koen@dominion.thruhere.net] 
Sent: Monday, April 28, 2014 5:45 PM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] xdg-utils: upgrade to 1.1.0-rc1


Op 28 apr. 2014, om 16:40 heeft Iorga, Cristian <cristian.iorga@intel.com> het volgende geschreven:

> Hello Koen,
> 
> Care to go into details why exactly the version is wrong?

http://www.openembedded.org/wiki/Versioning_Policy

> In YP Dev Manual, my recipe is given as an example of correct naming:
> http://www.yoctoproject.org/docs/current/dev-manual/dev-manual.html#ne
> w-recipe-storing-and-naming-the-recipe
> Quote:
> "Naming Your Recipe: When you name your recipe, you need to follow this naming convention:
> 
>     <basename>_<version>.bb
> 
> 
> Use lower-cased characters and do not include the reserved suffixes -native, -cross, -initial, or -dev casually (i.e. do not use them as part of your recipe name unless the string applies). Here are some examples:
> 
>     cups_1.7.0.bb
>     gawk_4.0.2.bb
>     xdg-utils_1.1.0-rc1.bb"

And that's why I only read OE policy docs when working on OE.

> Also, in meta-openembedded, I found several recipes following the same pattern, i.e. fim and irssi packages.

koen@beast:/build/v2014.06/sources/meta-openembedded$ grep PV ./meta-oe/recipes-connectivity/irssi/irssi_0.8.16-rc1.bb
REALPV = "0.8.16-rc1"
PV = "0.8.15+${REALPV}"
SRC_URI = "http://irssi.org/files/irssi-${REALPV}.tar.gz"
S = "${WORKDIR}/irssi-${REALPV}"

But 'fim' violates versioning policy as well.


> 
> Regards,
> Cristian
> YP
> Intel Corporation
> 
> -----Original Message-----
> From: Koen Kooi [mailto:koen@dominion.thruhere.net]
> Sent: Monday, April 28, 2014 5:26 PM
> To: Iorga, Cristian
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] xdg-utils: upgrade to 1.1.0-rc1
> 
> 
> Op 11 jul. 2013, om 14:51 heeft Cristian Iorga <cristian.iorga@intel.com> het volgende geschreven:
> 
>> This version of xdg-utils is needed by BA in order to associate 
>> correctly types of files with PCManFM file manager.
>> The release cycle of xdg-utils is very slow, so this is the best shot 
>> of a stable version available for YP 1.5 release.
>> As a reference, the previous stable version was released in 2007.
>> Also, desktop Linux distros use this release candidate as a stable 
>> version, for example, Ubuntu 12.04.
>> 
>> Part of the implementation of [YOCTO #2370].
>> 
>> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
>> ---
>> .../xdg-utils/{xdg-utils_1.0.2.bb => xdg-utils_1.1.0-rc1.bb}  |    9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-) rename 
>> meta/recipes-extended/xdg-utils/{xdg-utils_1.0.2.bb => 
>> xdg-utils_1.1.0-rc1.bb} (80%)
> 
> This has been in OE-core for a while, but I do have to point out that 
> it violates the version policy, it should be: 1.0.2+1.1.0-rc1
>
Paul Eggleton - April 28, 2014, 3:17 p.m.
On Monday 28 April 2014 16:45:06 Koen Kooi wrote:
> Op 28 apr. 2014, om 16:40 heeft Iorga, Cristian <cristian.iorga@intel.com> 
het volgende geschreven:
> > Hello Koen,
> > 
> > Care to go into details why exactly the version is wrong?
> 
> http://www.openembedded.org/wiki/Versioning_Policy
> 
> > In YP Dev Manual, my recipe is given as an example of correct naming:
> > http://www.yoctoproject.org/docs/current/dev-manual/dev-manual.html#new-re
> > cipe-storing-and-naming-the-recipe Quote:
> > 
> > "Naming Your Recipe: When you name your recipe, you need to follow this 
naming convention:
> >     <basename>_<version>.bb
> > 
> > Use lower-cased characters and do not include the reserved suffixes -native, 
-cross, -initial, or -dev casually (i.e. do not use them as part of your 
recipe name unless the string applies). Here are some examples:
> >     cups_1.7.0.bb
> >     gawk_4.0.2.bb
> >     xdg-utils_1.1.0-rc1.bb"
> 
> And that's why I only read OE policy docs when working on OE.

It's not just OE policy, it's good practice - and hence we should fix the 
manual. To that end I have filed a bug:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=6243

Cheers,
Paul

Patch

diff --git a/meta/recipes-extended/xdg-utils/xdg-utils_1.0.2.bb b/meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb
similarity index 80%
rename from meta/recipes-extended/xdg-utils/xdg-utils_1.0.2.bb
rename to meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb
index f54d591..d5c7aa3 100644
--- a/meta/recipes-extended/xdg-utils/xdg-utils_1.0.2.bb
+++ b/meta/recipes-extended/xdg-utils/xdg-utils_1.1.0-rc1.bb
@@ -13,14 +13,13 @@  xdg-open \
 xdg-screensaver \ 
 "
 
-PR="r0"
-
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=a5367a90934098d6b05af3b746405014"
 
-SRC_URI = "http://portland.freedesktop.org/download/${BPN}-${PV}.tgz"
+SRC_URI = "http://portland.freedesktop.org/download/${BPN}-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "fadf5e7a08e0526fc60dbe3e5b7ef8d6"
+SRC_URI[sha256sum] = "7b05558ae4bb8ede356863cae8c42e3e012aa421bf9d45130a570fd209d79102"
 
 inherit autotools
 
-SRC_URI[md5sum] = "348a5b91dc66426505022c74a64b2940"
-SRC_URI[sha256sum] = "21aeb7d16b2529b8d3975118f59eec09953e09f9a68d718159e98c90474b01ac"