Patchwork [2/3] docbook-sgml-dtd-4.1-native.bb: Add real PV inside the recipe

login
register
mail settings
Submitter Emilia Ciobanu
Date July 10, 2013, 3:07 p.m.
Message ID <6c15f39c5d3d9c6d7d8788d1c76758078b446fbd.1373468672.git.emilia.maria.silvia.ciobanu@intel.com>
Download mbox | patch
Permalink /patch/53467/
State New
Headers show

Comments

Emilia Ciobanu - July 10, 2013, 3:07 p.m.
Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
---
 .../docbook-sgml-dtd-4.1-native.bb                 |    1 +
 1 file changed, 1 insertion(+)
Martin Jansa - July 10, 2013, 3:16 p.m.
On Wed, Jul 10, 2013 at 06:07:08PM +0300, Emilia Ciobanu wrote:
> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
> ---
>  .../docbook-sgml-dtd-4.1-native.bb                 |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
> index 88c9396..1f338fd 100644
> --- a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
> +++ b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
> @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE-OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e"
>  DTD_VERSION = "4.1"
>  
>  PR = "${INC_PR}.0"
> +PV = "41"

Why not 4.1?

>  
>  # Note: the upstream sources are not distributed with a license file.
>  # LICENSE-OASIS is included as a "patch" to workaround this. When
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Saul Wold - July 10, 2013, 6:08 p.m.
On 07/10/2013 08:16 AM, Martin Jansa wrote:
> On Wed, Jul 10, 2013 at 06:07:08PM +0300, Emilia Ciobanu wrote:
>> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
>> ---
>>   .../docbook-sgml-dtd-4.1-native.bb                 |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
>> index 88c9396..1f338fd 100644
>> --- a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
>> +++ b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
>> @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE-OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e"
>>   DTD_VERSION = "4.1"
>>
>>   PR = "${INC_PR}.0"
>> +PV = "41"
>
> Why not 4.1?
>
It seems that the older version (3.1 and 4.1) have their tarballs named 
with 31 and 41.

Ema, can you use the regex to handle this correctly?

Sau!



>>
>>   # Note: the upstream sources are not distributed with a license file.
>>   # LICENSE-OASIS is included as a "patch" to workaround this. When
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Emilia Ciobanu - July 11, 2013, 9:57 a.m.
Hi Saul,
> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Wednesday, July 10, 2013 9:08 PM
> To: Martin Jansa
> Cc: Ciobanu, Emilia Maria Silvia; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/3] docbook-sgml-dtd-4.1-native.bb: Add
> real PV inside the recipe
> 
> On 07/10/2013 08:16 AM, Martin Jansa wrote:
> > On Wed, Jul 10, 2013 at 06:07:08PM +0300, Emilia Ciobanu wrote:
> >> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
> >> ---
> >>   .../docbook-sgml-dtd-4.1-native.bb                 |    1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git
> >> a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> index 88c9396..1f338fd 100644
> >> ---
> >> a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> +++ b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> nat
> >> +++ ive.bb
> >> @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE-
> OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e"
> >>   DTD_VERSION = "4.1"
> >>
> >>   PR = "${INC_PR}.0"
> >> +PV = "41"
> >
> > Why not 4.1?
> >
> It seems that the older version (3.1 and 4.1) have their tarballs named with 31
> and 41.
> 
> Ema, can you use the regex to handle this correctly?
> 
> Sau!
> 
> 
> 
> >>
> >>   # Note: the upstream sources are not distributed with a license file.
> >>   # LICENSE-OASIS is included as a "patch" to workaround this. When
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
Emilia Ciobanu - July 11, 2013, 10:08 a.m.
Hi Saul,

> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Wednesday, July 10, 2013 9:08 PM
> To: Martin Jansa
> Cc: Ciobanu, Emilia Maria Silvia; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/3] docbook-sgml-dtd-4.1-native.bb: Add
> real PV inside the recipe
> 
> On 07/10/2013 08:16 AM, Martin Jansa wrote:
> > On Wed, Jul 10, 2013 at 06:07:08PM +0300, Emilia Ciobanu wrote:
> >> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
> >> ---
> >>   .../docbook-sgml-dtd-4.1-native.bb                 |    1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git
> >> a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> index 88c9396..1f338fd 100644
> >> ---
> >> a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> native.
> >> bb
> >> +++ b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-
> nat
> >> +++ ive.bb
> >> @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE-
> OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e"
> >>   DTD_VERSION = "4.1"
> >>
> >>   PR = "${INC_PR}.0"
> >> +PV = "41"
> >
> > Why not 4.1?
> >
> It seems that the older version (3.1 and 4.1) have their tarballs named with 31
> and 41.
> 
> Ema, can you use the regex to handle this correctly?

The regexes cannot handle this case, but I'm considering an alternative solution.

Thanks,
Ema

> 
> Sau!
> 
> 
> 
> >>
> >>   # Note: the upstream sources are not distributed with a license file.
> >>   # LICENSE-OASIS is included as a "patch" to workaround this. When
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >

Patch

diff --git a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
index 88c9396..1f338fd 100644
--- a/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
+++ b/meta/recipes-devtools/docbook-sgml-dtd/docbook-sgml-dtd-4.1-native.bb
@@ -6,6 +6,7 @@  LIC_FILES_CHKSUM = "file://LICENSE-OASIS;md5=c608985dd5f7f215e669e7639a0b1d2e"
 DTD_VERSION = "4.1"
 
 PR = "${INC_PR}.0"
+PV = "41"
 
 # Note: the upstream sources are not distributed with a license file.
 # LICENSE-OASIS is included as a "patch" to workaround this. When