Patchwork [0/4] Fix typos

login
register
mail settings
Submitter Emilia Ciobanu
Date July 9, 2013, 8:57 a.m.
Message ID <cover.1373359791.git.emilia.maria.silvia.ciobanu@intel.com>
Download mbox
Permalink /patch/53363/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib emac/typo_fixes

Comments

Emilia Ciobanu - July 9, 2013, 8:57 a.m.
The following changes since commit dc86293f0444384e8ae5131fdd10b6cb077164b0:

  bitbake: HOB:Proper handle of SIGINT (2013-07-05 15:52:48 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib emac/typo_fixes
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=emac/typo_fixes

Emilia Ciobanu (4):
  chkconfig-alternatives-native: add git token in package version
  lttng-modules: rename recipe
  unzip: rename recipe
  zip: rename recipe

 .../chkconfig-alternatives-native_1.3.59.bb        |    2 +-
 .../unzip/{unzip_6.0.bb => unzip_60.bb}            |    0
 .../recipes-extended/zip/{zip_3.0.bb => zip_30.bb} |    0
 ...lttng-modules_2.2.0.bb => lttng-modules_git.bb} |    2 +-
 4 files changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-extended/unzip/{unzip_6.0.bb => unzip_60.bb} (100%)
 rename meta/recipes-extended/zip/{zip_3.0.bb => zip_30.bb} (100%)
 rename meta/recipes-kernel/lttng/{lttng-modules_2.2.0.bb => lttng-modules_git.bb} (97%)
Paul Eggleton - July 9, 2013, 9:43 a.m.
Hi Emilia,

On Tuesday 09 July 2013 11:57:37 Emilia Ciobanu wrote:
> The following changes since commit dc86293f0444384e8ae5131fdd10b6cb077164b0:
> 
>   bitbake: HOB:Proper handle of SIGINT (2013-07-05 15:52:48 +0100)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib emac/typo_fixes
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=emac/typo_fixes
> 
> Emilia Ciobanu (4):
>   chkconfig-alternatives-native: add git token in package version
>   lttng-modules: rename recipe
>   unzip: rename recipe
>   zip: rename recipe
> 
>  .../chkconfig-alternatives-native_1.3.59.bb        |    2 +-
>  .../unzip/{unzip_6.0.bb => unzip_60.bb}            |    0
>  .../recipes-extended/zip/{zip_3.0.bb => zip_30.bb} |    0
>  ...lttng-modules_2.2.0.bb => lttng-modules_git.bb} |    2 +-
>  4 files changed, 2 insertions(+), 2 deletions(-)
>  rename meta/recipes-extended/unzip/{unzip_6.0.bb => unzip_60.bb} (100%)
>  rename meta/recipes-extended/zip/{zip_3.0.bb => zip_30.bb} (100%)
>  rename meta/recipes-kernel/lttng/{lttng-modules_2.2.0.bb =>
> lttng-modules_git.bb} (97%)

Unfortunately the unzip and zip version changes are not correct - the upstream 
versions are 6.0 and 3.0 respectively, and these are the versions we want to 
be going into the final packages. However, if it would help with the package 
reporting system, the recipes could be changed to convert PV of "6.0" into 
"60" in SRC_URI using some inline python.

Cheers,
Paul
Ross Burton - July 11, 2013, 10:21 a.m.
On 9 July 2013 09:57, Emilia Ciobanu
<emilia.maria.silvia.ciobanu@intel.com> wrote:
> Current local version is 30.

Explaining why this has to happen would be useful.  I presume the
situation is that the package report system is reporting updates
because upstream is at version "30" but we're at "3.0", when the
reality is that upstream is sticking to 8+3 filenames so drops the
dots in the version number.

I'm not sure making our packages have the wrong version just because
upstream tarballs versions are mangled is wise.  Can we extend the PRS
so that it can transform the PV before comparing it to upstream?

Ross
Ross Burton - July 11, 2013, 10:22 a.m.
On 9 July 2013 10:43, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> However, if it would help with the package
> reporting system, the recipes could be changed to convert PV of "6.0" into
> "60" in SRC_URI using some inline python.

Oh, somehow I didn't see Paul's reply.

This is basically what happens already:

SRC_URI = "ftp://ftp.info-zip.org/pub/infozip/src/zip${@d.getVar('PV',1).replace('.',
'')}.tgz"

Ross
Emilia Ciobanu - July 11, 2013, 10:31 a.m.
Hi Ross,

I'm looking at an alternative solution.

Thanks,
Ema