Patchwork pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package

login
register
mail settings
Submitter eu@felipetonello.com
Date July 8, 2013, 5:16 p.m.
Message ID <1373303785-8508-1-git-send-email-eu@felipetonello.com>
Download mbox | patch
Permalink /patch/53331/
State New
Headers show

Comments

eu@felipetonello.com - July 8, 2013, 5:16 p.m.
From: "Felipe F. Tonello" <eu@felipetonello.com>

When installing pulseaudio-module-console-kit package in an image the
consolekit dependecy cannot be find. This patch makes sure that the consolekit
recipe will be build.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - July 10, 2013, 6:50 p.m.
On 07/08/2013 10:16 AM, eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <eu@felipetonello.com>
>
> When installing pulseaudio-module-console-kit package in an image the
> consolekit dependecy cannot be find. This patch makes sure that the consolekit
> recipe will be build.
>
Is this really a build-time dependency or a runtime dependency specific 
to the pulseaudio-module?

Sau!

> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>   meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index e4fc648..f925e7d 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
>                       file://src/pulsecore/resampler.h;beginline=4;endline=23;md5=c3d539b93f8c82a1780bfa3cfa544a95"
>   DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool"
>   # optional
> -DEPENDS += "udev alsa-lib glib-2.0 dbus gconf"
> +DEPENDS += "udev alsa-lib glib-2.0 dbus gconf consolekit"
>
>   SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
>              file://gcc4-compile-fix.patch \
>
Ross Burton - July 11, 2013, 10:32 a.m.
On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> Is this really a build-time dependency or a runtime dependency specific to
> the pulseaudio-module?

It's a runtime dependency, but from memory bitbake doesn't manage to
piece the chain together enough to actually build consolekit (probably
because the packages are dynamically created).

Ross
Paul Eggleton - July 11, 2013, 12:20 p.m.
On Thursday 11 July 2013 11:32:14 Burton, Ross wrote:
> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> > Is this really a build-time dependency or a runtime dependency specific to
> > the pulseaudio-module?
> 
> It's a runtime dependency, but from memory bitbake doesn't manage to
> piece the chain together enough to actually build consolekit (probably
> because the packages are dynamically created).

If it's a stated RDEPENDS in the recipe it must be, and pulseaudio.inc already 
has RDEPENDS_pulseaudio-module-console-kit =+ "consolekit" so unless the 
module package doesn't actually end up being "pulseaudio-module-console-kit" 
I'm not sure why anything else should be needed. It's usually only when the 
dependencies get added dynamically at package time that bitbake not building a 
dependency can be a problem (we've seen this with recipes containing perl 
scripts for example).

Cheers,
Paul
Martin Jansa - July 11, 2013, 12:26 p.m.
On Thu, Jul 11, 2013 at 11:32:14AM +0100, Burton, Ross wrote:
> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
> > Is this really a build-time dependency or a runtime dependency specific to
> > the pulseaudio-module?
> 
> It's a runtime dependency, but from memory bitbake doesn't manage to
> piece the chain together enough to actually build consolekit (probably
> because the packages are dynamically created).

The problem is that RDEPENDS_<dynamic_package> = "foo"
doesn't enforce foo to be built before <dynamic_package> is used in
image:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=3498

So if <dynamic_package> is the only thing pulling "foo" into the image
you can get do_rootfs error about missing "foo".

Cheers,
eu@felipetonello.com - July 16, 2013, 10:07 p.m.
Hi Martin,

On Thu, Jul 11, 2013 at 5:26 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Jul 11, 2013 at 11:32:14AM +0100, Burton, Ross wrote:
>> On 10 July 2013 19:50, Saul Wold <sgw@linux.intel.com> wrote:
>> > Is this really a build-time dependency or a runtime dependency specific to
>> > the pulseaudio-module?
>>
>> It's a runtime dependency, but from memory bitbake doesn't manage to
>> piece the chain together enough to actually build consolekit (probably
>> because the packages are dynamically created).
>
> The problem is that RDEPENDS_<dynamic_package> = "foo"
> doesn't enforce foo to be built before <dynamic_package> is used in
> image:
>
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=3498
>
> So if <dynamic_package> is the only thing pulling "foo" into the image
> you can get do_rootfs error about missing "foo".
>
> Cheers,
>

Yes, that's exactly what happens. I added this dep in my bbappend for
a temporary fix, but I would like to see a final fix for it.

Regards,
Felipe

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index e4fc648..f925e7d 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
                     file://src/pulsecore/resampler.h;beginline=4;endline=23;md5=c3d539b93f8c82a1780bfa3cfa544a95"
 DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool"
 # optional
-DEPENDS += "udev alsa-lib glib-2.0 dbus gconf"
+DEPENDS += "udev alsa-lib glib-2.0 dbus gconf consolekit"
 
 SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
            file://gcc4-compile-fix.patch \