Patchwork [1/4] xf86-driver-common.inc: remove .la files to avoid unpackaged warning

login
register
mail settings
Submitter Otavio Salvador
Date June 2, 2011, 7:25 p.m.
Message ID <21881aba9031cefb72fcc33cca9d146169f344e9.1307042670.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/5331/
State New, archived
Headers show

Comments

Otavio Salvador - June 2, 2011, 7:25 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../xorg-driver/xf86-driver-common.inc             |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Saul Wold - June 3, 2011, 12:52 a.m.
On 06/02/2011 12:25 PM, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador<otavio@ossystems.com.br>
> ---
>   .../xorg-driver/xf86-driver-common.inc             |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc b/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
> index 550423b..6ff1391 100644
> --- a/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
> +++ b/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
> @@ -5,7 +5,7 @@ SECTION = "x11/drivers"
>   LICENSE = "MIT-X"
>
>   PE = "1"
> -PR = "r0"
> +PR = "r1"
>
>   DEPENDS = "virtual/xserver-xf86 xproto randrproto util-macros"
>
> @@ -27,3 +27,7 @@ do_configure_prepend () {
>       mv configure.ac.new configure.ac
>   }
>
> +do_install_append () {
> +    # driver's la files are not packaged
> +    rm -f ${D}${libdir}/xorg/modules/drivers/*.la
> +}
Would it not be better to package them in the -dev package instead of 
throwing them away?

Sau!
Otavio Salvador - June 3, 2011, 12:42 p.m.
On Fri, Jun 3, 2011 at 00:52, Saul Wold <sgw@linux.intel.com> wrote:
> Would it not be better to package them in the -dev package instead of
> throwing them away?

They are not packaged by I remove them to avoid the unshiped warning.
Phil Blundell - June 3, 2011, 12:49 p.m.
On Thu, 2011-06-02 at 17:52 -0700, Saul Wold wrote:
> On 06/02/2011 12:25 PM, Otavio Salvador wrote:
> > +do_install_append () {
> > +    # driver's la files are not packaged
> > +    rm -f ${D}${libdir}/xorg/modules/drivers/*.la
> > +}
>
> Would it not be better to package them in the -dev package instead of 
> throwing them away?

Not really.  The .la files for the drivers aren't good for anything: you
aren't ever going to link against them.

p.

Patch

diff --git a/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc b/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
index 550423b..6ff1391 100644
--- a/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
+++ b/meta/recipes-graphics/xorg-driver/xf86-driver-common.inc
@@ -5,7 +5,7 @@  SECTION = "x11/drivers"
 LICENSE = "MIT-X"
 
 PE = "1"
-PR = "r0"
+PR = "r1"
 
 DEPENDS = "virtual/xserver-xf86 xproto randrproto util-macros"
 
@@ -27,3 +27,7 @@  do_configure_prepend () {
     mv configure.ac.new configure.ac
 }
 
+do_install_append () {
+    # driver's la files are not packaged
+    rm -f ${D}${libdir}/xorg/modules/drivers/*.la
+}