Patchwork [1/1] udev: add runtime dependency on blkid

login
register
mail settings
Submitter jackie huang
Date July 8, 2013, 7:10 a.m.
Message ID <f3947aac42370ea5f114852fd677ff1689a9b7ca.1373267292.git.jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/53281/
State New
Headers show

Comments

jackie huang - July 8, 2013, 7:10 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

udev requires blkid, but this wasn't explicit.  Note that the
dependency is on util-linux specifically, the one from e2fsprogs
won't work.

Signed-off-by: Andy Ross <andy.ross@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-core/udev/udev_182.bb |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Saul Wold - July 8, 2013, 7:35 p.m.
On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> udev requires blkid, but this wasn't explicit.  Note that the
> dependency is on util-linux specifically, the one from e2fsprogs
> won't work.
>
Doesn't udev use an internal builtin-blkid?  Or is the configure finding 
that we have util-linux and using it instead of the built-in?

If it's a configure test, then it might need to be a DEPENDS, not RDEPENDS.

Sau!


> Signed-off-by: Andy Ross <andy.ross@windriver.com>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>   meta/recipes-core/udev/udev_182.bb |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev_182.bb b/meta/recipes-core/udev/udev_182.bb
> index d66292e..114a557 100644
> --- a/meta/recipes-core/udev/udev_182.bb
> +++ b/meta/recipes-core/udev/udev_182.bb
> @@ -5,5 +5,9 @@ PR = "r7"
>   # module-init-tools from kmod_git will provide libkmod runtime
>   DEPENDS += "module-init-tools"
>
> +# Needs blkid from this particular package. The one in e2fsprogs is
> +# old and incompatible.
> +RDEPENDS_${PN} += "util-linux-blkid"
> +
>   SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
>   SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"
>
Andy Ross - July 8, 2013, 7:47 p.m.
On 07/08/2013 12:35 PM, Saul Wold wrote:
> On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> udev requires blkid, but this wasn't explicit.  Note that the
>> dependency is on util-linux specifically, the one from e2fsprogs
>> won't work.
>>
> Doesn't udev use an internal builtin-blkid?  Or is the configure finding 
> that we have util-linux and using it instead of the built-in?

I think (I'm really stale here) I wrote that patch against a udev
version prior to the addition of the builtin.  And in any case didn't
I see that blkid got yanked from the e2fsprogs package at some point
anyway?  Pretty sure this is not needed in upstream oe-core.  Not sure
if it ever was.

Andy
jackie huang - July 9, 2013, 2:06 a.m.
On 7/9/2013 3:47 AM, Andy Ross wrote:
> On 07/08/2013 12:35 PM, Saul Wold wrote:
>> On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>
>>> udev requires blkid, but this wasn't explicit.  Note that the
>>> dependency is on util-linux specifically, the one from e2fsprogs
>>> won't work.
>>>
>> Doesn't udev use an internal builtin-blkid?  Or is the configure finding
>> that we have util-linux and using it instead of the built-in?
>
> I think (I'm really stale here) I wrote that patch against a udev
> version prior to the addition of the builtin.  And in any case didn't
> I see that blkid got yanked from the e2fsprogs package at some point
> anyway?  Pretty sure this is not needed in upstream oe-core.  Not sure

Thanks for clarifying this, I think it it not needed in our layer's 
bbappend file as well since we had sync up with upstream oe-core, I will 
check that and clean up the bbappend.

Thanks,
Jackie


> if it ever was.
>
> Andy
>
>

Patch

diff --git a/meta/recipes-core/udev/udev_182.bb b/meta/recipes-core/udev/udev_182.bb
index d66292e..114a557 100644
--- a/meta/recipes-core/udev/udev_182.bb
+++ b/meta/recipes-core/udev/udev_182.bb
@@ -5,5 +5,9 @@  PR = "r7"
 # module-init-tools from kmod_git will provide libkmod runtime
 DEPENDS += "module-init-tools"
 
+# Needs blkid from this particular package. The one in e2fsprogs is
+# old and incompatible.
+RDEPENDS_${PN} += "util-linux-blkid"
+
 SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
 SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"