Patchwork [meta-oe,v2] samba: remove /var/lock and /var/run from package

login
register
mail settings
Submitter Jonathan Liu
Date July 8, 2013, 5:37 a.m.
Message ID <1373261850-3744-1-git-send-email-net147@gmail.com>
Download mbox | patch
Permalink /patch/53277/
State Accepted
Commit 82f7bdc63e084e8482be0914d9b46fc10cada185
Headers show

Comments

Jonathan Liu - July 8, 2013, 5:37 a.m.
The /var/lock and /var/run directories are already created by
base-files.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
 1 file changed, 6 insertions(+)
Khem Raj - July 8, 2013, 5:53 a.m.
On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:

> The /var/lock and /var/run directories are already created by
> base-files.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> index a27a28c..255c0b4 100644
> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> @@ -57,3 +57,9 @@ do_configure() {
> do_compile () {
>     base_do_compile
> }
> +
> +do_install_append() {
> +    rmdir "${D}${localstatedir}/lock"
> +    rmdir "${D}${localstatedir}/run"
> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"

what is this last rmdir doing ?


> +}
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Jonathan Liu - July 8, 2013, 7:48 a.m.
On 8 July 2013 15:53, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:
>
>> The /var/lock and /var/run directories are already created by
>> base-files.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> index a27a28c..255c0b4 100644
>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> @@ -57,3 +57,9 @@ do_configure() {
>> do_compile () {
>>     base_do_compile
>> }
>> +
>> +do_install_append() {
>> +    rmdir "${D}${localstatedir}/lock"
>> +    rmdir "${D}${localstatedir}/run"
>> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>
> what is this last rmdir doing ?
It will remove the /var directory only if it is empty. In case there
is nothing else in /var it's useless to have an empty /var directory.

Regards,
Jonathan

>
>
>> +}
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj - July 8, 2013, 1:52 p.m.
On Monday, July 8, 2013, Jonathan Liu <net147@gmail.com> wrote:
> On 8 July 2013 15:53, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:
>>
>>> The /var/lock and /var/run directories are already created by
>>> base-files.
>>>
>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>> ---
>>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bbb/meta-oe/recipes-connectivity/samba/
samba_3.6.8.bb
>>> index a27a28c..255c0b4 100644
>>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> @@ -57,3 +57,9 @@ do_configure() {
>>> do_compile () {
>>>     base_do_compile
>>> }
>>> +
>>> +do_install_append() {
>>> +    rmdir "${D}${localstatedir}/lock"
>>> +    rmdir "${D}${localstatedir}/run"
>>> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>>
>> what is this last rmdir doing ?
> It will remove the /var directory only if it is empty. In case there
> is nothing else in /var it's useless to have an empty /var directory.
>

Good. Mention it in commit message

> Regards,
> Jonathan
>
>>
>>
>>> +}
>>> --
>>> 1.8.3.2
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
index a27a28c..255c0b4 100644
--- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
+++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
@@ -57,3 +57,9 @@  do_configure() {
 do_compile () {
     base_do_compile
 }
+
+do_install_append() {
+    rmdir "${D}${localstatedir}/lock"
+    rmdir "${D}${localstatedir}/run"
+    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}