Patchwork [RFC] base.bbclass: add binutils to BASEDEPENDS

login
register
mail settings
Submitter Martin Jansa
Date July 6, 2013, 11:16 p.m.
Message ID <1373152573-22879-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/53245/
State Accepted, archived
Headers show

Comments

Martin Jansa - July 6, 2013, 11:16 p.m.
* when gcc-cross is reused from the sstate cache then
  gcc-cross's dependency on binutils-cross.do_populate_sysroot
  is ignored due to being in the safe dependency list in
  setscene_depvalid
* many packages still require binutils-cross.do_populate_sysroot
  to be executed before their do_configure (or do_compile)
* usually some other recipe runs do_package task (which also
  require binutils-cross.do_populate_sysroot, before do_configure
  is executed

* rebuilding one recipe with everything else reused from sstate-cache
  before:
  $ grep binutils-cross log
  NOTE: Running setscene task 251 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_package_write_ipk_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_write_ipk_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_write_ipk_setscene: Succeeded
  NOTE: Running setscene task 254 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_packagedata_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_packagedata_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_packagedata_setscene: Succeeded
  NOTE: Running noexec task 209 of 1157 (ID: 530, oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_package_write)

  after:
  $ grep binutils-cross log2
  NOTE: Running setscene task 216 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_package_write_ipk_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_write_ipk_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_write_ipk_setscene: Succeeded
  NOTE: Running setscene task 341 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_packagedata_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_packagedata_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_packagedata_setscene: Succeeded
  NOTE: Running setscene task 344 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_package_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_package_setscene: Succeeded
  NOTE: Running setscene task 389 of 412 (oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_populate_sysroot_setscene)
  NOTE: recipe binutils-cross-2.23.1-r3: task do_populate_sysroot_setscene: Started
  NOTE: recipe binutils-cross-2.23.1-r3: task do_populate_sysroot_setscene: Succeeded
  NOTE: Running noexec task 187 of 1157 (ID: 108, oe-core/meta/recipes-devtools/binutils/binutils-cross_2.23.1.bb, do_package_write)

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 27edea8..4383d2e 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -72,7 +72,7 @@  def base_dep_prepend(d):
     # the application.
     if not d.getVar('INHIBIT_DEFAULT_DEPS'):
         if (d.getVar('HOST_SYS', True) != d.getVar('BUILD_SYS', True)):
-            deps += " virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}compilerlibs virtual/libc "
+            deps += " virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}compilerlibs virtual/${TARGET_PREFIX}binutils virtual/libc "
     return deps
 
 BASEDEPENDS = "${@base_dep_prepend(d)}"