Patchwork [meta-oe] busybox: Follow OE-Core update to 1.12.1 version

login
register
mail settings
Submitter Otavio Salvador
Date July 5, 2013, 5:01 p.m.
Message ID <1373043676-5621-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/53189/
State Accepted, archived
Headers show

Comments

Otavio Salvador - July 5, 2013, 5:01 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../busybox/{busybox_1.20.2.bbappend => busybox_1.21.1.bbappend}        | 2 --
 1 file changed, 2 deletions(-)
 rename meta-oe/recipes-core/busybox/{busybox_1.20.2.bbappend => busybox_1.21.1.bbappend} (91%)
Paul Eggleton - July 5, 2013, 5:29 p.m.
On Friday 05 July 2013 14:01:16 Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../busybox/{busybox_1.20.2.bbappend => busybox_1.21.1.bbappend}        | 2
> -- 1 file changed, 2 deletions(-)
>  rename meta-oe/recipes-core/busybox/{busybox_1.20.2.bbappend =>
> busybox_1.21.1.bbappend} (91%)
> 
> diff --git a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
> b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend similarity index 91%
> rename from meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
> rename to meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
> index 721ef19..7a2f0c3 100644
> --- a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
> +++ b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
> @@ -1,5 +1,3 @@
> -PRINC := "${@int(PRINC) + 1}"
> -
>  # look for files in the layer first
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"

Could someone *please* figure out what this bbappend is needed for and get it 
into OE-Core if it is still needed so we can drop it here?

Thanks,
Paul
Otavio Salvador - July 5, 2013, 5:34 p.m.
On Fri, Jul 5, 2013 at 2:29 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Friday 05 July 2013 14:01:16 Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>  .../busybox/{busybox_1.20.2.bbappend => busybox_1.21.1.bbappend}        | 2
>> -- 1 file changed, 2 deletions(-)
>>  rename meta-oe/recipes-core/busybox/{busybox_1.20.2.bbappend =>
>> busybox_1.21.1.bbappend} (91%)
>>
>> diff --git a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
>> b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend similarity index 91%
>> rename from meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
>> rename to meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
>> index 721ef19..7a2f0c3 100644
>> --- a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
>> +++ b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
>> @@ -1,5 +1,3 @@
>> -PRINC := "${@int(PRINC) + 1}"
>> -
>>  # look for files in the layer first
>>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> Could someone *please* figure out what this bbappend is needed for and get it
> into OE-Core if it is still needed so we can drop it here?

I agree; the changes here are easy to upstream but without a PRINC
here it can be done when someone finds the time.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Eric BENARD - July 5, 2013, 5:45 p.m.
Hi Paul,

Le Fri, 05 Jul 2013 18:29:04 +0100,
Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> 
> Could someone *please* figure out what this bbappend is needed for and get it 
> into OE-Core if it is still needed so we can drop it here?
> 
it's only here to install /etc/default/busybox-syslog which contains
only one line : OPTIONS="-C64" which sets the size of the logbuffer.
So obviously this could go into OE-Core.

Eric
Paul Eggleton - July 8, 2013, 12:35 p.m.
On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
> Le Fri, 05 Jul 2013 18:29:04 +0100,
> Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> > Could someone *please* figure out what this bbappend is needed for and get
> > it into OE-Core if it is still needed so we can drop it here?
> 
> it's only here to install /etc/default/busybox-syslog which contains
> only one line : OPTIONS="-C64" which sets the size of the logbuffer.
> So obviously this could go into OE-Core.

Yes but why is this needed? If we are to merge this into OE-Core we'll need to 
say why this change is needed in the commit message.

Cheers,
Paul
Paul Eggleton - July 23, 2013, 9:44 a.m.
On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
> > Le Fri, 05 Jul 2013 18:29:04 +0100,
> > 
> > Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> > > Could someone *please* figure out what this bbappend is needed for and
> > > get
> > > it into OE-Core if it is still needed so we can drop it here?
> > 
> > it's only here to install /etc/default/busybox-syslog which contains
> > only one line : OPTIONS="-C64" which sets the size of the logbuffer.
> > So obviously this could go into OE-Core.
> 
> Yes but why is this needed? If we are to merge this into OE-Core we'll need
> to say why this change is needed in the commit message.

ping...

Cheers,
Paul
Otavio Salvador - July 23, 2013, 12:09 p.m.
On Tue, Jul 23, 2013 at 6:44 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
>> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
>> > Le Fri, 05 Jul 2013 18:29:04 +0100,
>> >
>> > Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
>> > > Could someone *please* figure out what this bbappend is needed for and
>> > > get
>> > > it into OE-Core if it is still needed so we can drop it here?
>> >
>> > it's only here to install /etc/default/busybox-syslog which contains
>> > only one line : OPTIONS="-C64" which sets the size of the logbuffer.
>> > So obviously this could go into OE-Core.
>>
>> Yes but why is this needed? If we are to merge this into OE-Core we'll need
>> to say why this change is needed in the commit message.
>
> ping...

I am working in something else so I cannot work on busybox now. Feel
free to handle this.

The syslog support would be good to be kept.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Paul Eggleton - July 23, 2013, 12:41 p.m.
On Tuesday 23 July 2013 09:09:37 Otavio Salvador wrote:
> On Tue, Jul 23, 2013 at 6:44 AM, Paul Eggleton
> 
> <paul.eggleton@linux.intel.com> wrote:
> > On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
> >> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
> >> > Le Fri, 05 Jul 2013 18:29:04 +0100,
> >> > 
> >> > Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> >> > > Could someone *please* figure out what this bbappend is needed for
> >> > > and
> >> > > get
> >> > > it into OE-Core if it is still needed so we can drop it here?
> >> > 
> >> > it's only here to install /etc/default/busybox-syslog which contains
> >> > only one line : OPTIONS="-C64" which sets the size of the logbuffer.
> >> > So obviously this could go into OE-Core.
> >> 
> >> Yes but why is this needed? If we are to merge this into OE-Core we'll
> >> need
> >> to say why this change is needed in the commit message.
> > 
> > ping...
> 
> I am working in something else so I cannot work on busybox now. Feel
> free to handle this.
> 
> The syslog support would be good to be kept.

The problem is it's not clear to me what we should do here. Surely having this 
bbappend or not isn't the determining factor in whether we have syslog support 
with systemd...?

Cheers,
Paul
Otavio Salvador - July 23, 2013, 12:46 p.m.
On Tue, Jul 23, 2013 at 9:41 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Tuesday 23 July 2013 09:09:37 Otavio Salvador wrote:
>> On Tue, Jul 23, 2013 at 6:44 AM, Paul Eggleton
>>
>> <paul.eggleton@linux.intel.com> wrote:
>> > On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
>> >> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
>> >> > Le Fri, 05 Jul 2013 18:29:04 +0100,
>> >> >
>> >> > Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
>> >> > > Could someone *please* figure out what this bbappend is needed for
>> >> > > and
>> >> > > get
>> >> > > it into OE-Core if it is still needed so we can drop it here?
>> >> >
>> >> > it's only here to install /etc/default/busybox-syslog which contains
>> >> > only one line : OPTIONS="-C64" which sets the size of the logbuffer.
>> >> > So obviously this could go into OE-Core.
>> >>
>> >> Yes but why is this needed? If we are to merge this into OE-Core we'll
>> >> need
>> >> to say why this change is needed in the commit message.
>> >
>> > ping...
>>
>> I am working in something else so I cannot work on busybox now. Feel
>> free to handle this.
>>
>> The syslog support would be good to be kept.
>
> The problem is it's not clear to me what we should do here. Surely having this
> bbappend or not isn't the determining factor in whether we have syslog support
> with systemd...?

With systemd we shouldn't provide it but for sysv we should provide it.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Paul Eggleton - July 23, 2013, 12:54 p.m.
On Tuesday 23 July 2013 09:46:36 Otavio Salvador wrote:
> On Tue, Jul 23, 2013 at 9:41 AM, Paul Eggleton
> 
> <paul.eggleton@linux.intel.com> wrote:
> > On Tuesday 23 July 2013 09:09:37 Otavio Salvador wrote:
> >> On Tue, Jul 23, 2013 at 6:44 AM, Paul Eggleton
> >> 
> >> <paul.eggleton@linux.intel.com> wrote:
> >> > On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
> >> >> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
> >> >> > Le Fri, 05 Jul 2013 18:29:04 +0100,
> >> >> > 
> >> >> > Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> >> >> > > Could someone *please* figure out what this bbappend is needed for
> >> >> > > and
> >> >> > > get
> >> >> > > it into OE-Core if it is still needed so we can drop it here?
> >> >> > 
> >> >> > it's only here to install /etc/default/busybox-syslog which contains
> >> >> > only one line : OPTIONS="-C64" which sets the size of the logbuffer.
> >> >> > So obviously this could go into OE-Core.
> >> >> 
> >> >> Yes but why is this needed? If we are to merge this into OE-Core we'll
> >> >> need
> >> >> to say why this change is needed in the commit message.
> >> > 
> >> > ping...
> >> 
> >> I am working in something else so I cannot work on busybox now. Feel
> >> free to handle this.
> >> 
> >> The syslog support would be good to be kept.
> > 
> > The problem is it's not clear to me what we should do here. Surely having
> > this bbappend or not isn't the determining factor in whether we have
> > syslog support with systemd...?
> 
> With systemd we shouldn't provide it but for sysv we should provide it.

I still need to know what this is needed for. Surely it doesn't actually 
enable syslog functionality, just adds one configuration value to it? If that's 
the case, why is this configuration change needed?

Cheers,
Paul
Qi.Chen@windriver.com - July 24, 2013, 2:08 a.m.
On 07/23/2013 08:54 PM, Paul Eggleton wrote:
> On Tuesday 23 July 2013 09:46:36 Otavio Salvador wrote:
>> On Tue, Jul 23, 2013 at 9:41 AM, Paul Eggleton
>>
>> <paul.eggleton@linux.intel.com> wrote:
>>> On Tuesday 23 July 2013 09:09:37 Otavio Salvador wrote:
>>>> On Tue, Jul 23, 2013 at 6:44 AM, Paul Eggleton
>>>>
>>>> <paul.eggleton@linux.intel.com> wrote:
>>>>> On Monday 08 July 2013 13:35:21 Paul Eggleton wrote:
>>>>>> On Friday 05 July 2013 19:45:25 Eric Bénard wrote:
>>>>>>> Le Fri, 05 Jul 2013 18:29:04 +0100,
>>>>>>>
>>>>>>> Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
>>>>>>>> Could someone *please* figure out what this bbappend is needed for
>>>>>>>> and
>>>>>>>> get
>>>>>>>> it into OE-Core if it is still needed so we can drop it here?
>>>>>>> it's only here to install /etc/default/busybox-syslog which contains
>>>>>>> only one line : OPTIONS="-C64" which sets the size of the logbuffer.
>>>>>>> So obviously this could go into OE-Core.
>>>>>> Yes but why is this needed? If we are to merge this into OE-Core we'll
>>>>>> need
>>>>>> to say why this change is needed in the commit message.
>>>>> ping...
>>>> I am working in something else so I cannot work on busybox now. Feel
>>>> free to handle this.
>>>>
>>>> The syslog support would be good to be kept.
>>> The problem is it's not clear to me what we should do here. Surely having
>>> this bbappend or not isn't the determining factor in whether we have
>>> syslog support with systemd...?
>> With systemd we shouldn't provide it but for sysv we should provide it.
> I still need to know what this is needed for. Surely it doesn't actually
> enable syslog functionality, just adds one configuration value to it? If that's
> the case, why is this configuration change needed?
>
> Cheers,
> Paul
>
Hi All,

FWIW, there are two bugs which might be related to this.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4837
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4860

My opinion is to respect the same configuration file in both sysv and 
systemd systems.
The configuration file is /etc/syslog-startup.conf.

Best Regards,
Chen Qi

Patch

diff --git a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
similarity index 91%
rename from meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
rename to meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
index 721ef19..7a2f0c3 100644
--- a/meta-oe/recipes-core/busybox/busybox_1.20.2.bbappend
+++ b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
@@ -1,5 +1,3 @@ 
-PRINC := "${@int(PRINC) + 1}"
-
 # look for files in the layer first
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"