Patchwork [2/8] util-linux: disable runuser by default since it depends on PAM

login
register
mail settings
Submitter Saul Wold
Date July 3, 2013, 10:26 p.m.
Message ID <c9b8490c65d03e9bc3f603d2a3a20ea680c089aa.1372890071.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/52921/
State New
Headers show

Comments

Saul Wold - July 3, 2013, 10:26 p.m.
util-linux's configure checks for pam_misc.h and if it finds it will
enable runuser, there was a case where it was found via shared state
and then got rebuilt. This makes the build more deterministic.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/util-linux/util-linux.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Ross Burton - July 4, 2013, 10:18 a.m.
On 3 July 2013 23:26, Saul Wold <sgw@linux.intel.com> wrote:
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -45,6 +45,7 @@ EXTRA_OECONF = "--libdir=${base_libdir} --disable-use-tty-group \
>                  --disable-vipw --disable-newgrp --disable-chfn-chsh --disable-su \
>                  --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
>                  --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
> +                --disable-runuser \
>                 usrsbin_execdir='${sbindir}' \
>  "
>
> @@ -52,7 +53,7 @@ EXTRA_OECONF = "--libdir=${base_libdir} --disable-use-tty-group \
>  EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--enable-socket-activation', '--disable-socket-activation', d)}"
>  EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
>
> -EXTRA_OECONF_append_class-native = " --disable-login --disable-su"
> +EXTRA_OECONF_append_class-native = " --disable-login --disable-su --disable-runuser"

Surely the class-native append is redundant?

Also, is runuser something that we should enable if the pam distro
feature is enabled?

Ross
Otavio Salvador - July 4, 2013, 1:21 p.m.
On Wed, Jul 3, 2013 at 7:26 PM, Saul Wold <sgw@linux.intel.com> wrote:
> util-linux's configure checks for pam_misc.h and if it finds it will
> enable runuser, there was a case where it was found via shared state
> and then got rebuilt. This makes the build more deterministic.
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

Please make this as a PACKAGECONFIG and add it if pam feature is enabled.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 0ada1a5..5bae370 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -45,6 +45,7 @@  EXTRA_OECONF = "--libdir=${base_libdir} --disable-use-tty-group \
                 --disable-vipw --disable-newgrp --disable-chfn-chsh --disable-su \
                 --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
                 --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
+                --disable-runuser \
 		usrsbin_execdir='${sbindir}' \
 "
 
@@ -52,7 +53,7 @@  EXTRA_OECONF = "--libdir=${base_libdir} --disable-use-tty-group \
 EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--enable-socket-activation', '--disable-socket-activation', d)}"
 EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}"
 
-EXTRA_OECONF_append_class-native = " --disable-login --disable-su"
+EXTRA_OECONF_append_class-native = " --disable-login --disable-su --disable-runuser"
 
 FILES_${PN}-bash-completion += "${datadir}/bash-completion"
 FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"