Patchwork qemu: use PACKAGECONFIG to address libaio/attr/libcap dependencies

login
register
mail settings
Submitter Ting Liu
Date July 3, 2013, 9:45 a.m.
Message ID <1372844710-15122-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/52879/
State New
Headers show

Comments

Ting Liu - July 3, 2013, 9:45 a.m.
From: Ting Liu <b28495@freescale.com>

Move to using the PACKAGECONFIG mechanism to select configure options
and dependencies. Without this the system will attempt to discover
various dependencies, and sometimes does so incorrectly.

Signed-off-by: Ting Liu <b28495@freescale.com>
---
 meta/recipes-devtools/qemu/qemu.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Paul Eggleton - July 3, 2013, 1:37 p.m.
Hi Ting,

On Wednesday 03 July 2013 17:45:10 b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
> 
> Move to using the PACKAGECONFIG mechanism to select configure options
> and dependencies. Without this the system will attempt to discover
> various dependencies, and sometimes does so incorrectly.
> 
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
>  meta/recipes-devtools/qemu/qemu.inc |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc index 7caef6e..8be3890 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -84,6 +84,8 @@ do_install_append() {
>  # END of qemu-mips workaround
> 
>  PACKAGECONFIG ??= ""
> +PACKAGECONFIG[virtfs] = "--enable-virtfs
> --enable-attr,--disable-virtfs,libcap attr," 
> +PACKAGECONFIG[libaio] =
> "--enable-linux-aio,--disable-linux-aio,libaio,"

The latter should be "aio" and not "libaio" (since "aio" is the feature being 
enabled/disabled).

Cheers,
Paul
Ting Liu - July 4, 2013, 2:01 a.m.
Hello Paul,

> -----Original Message-----
> From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com]
> Sent: Wednesday, July 03, 2013 9:38 PM
> To: Liu Ting-B28495
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [oe-core][PATCH] qemu: use PACKAGECONFIG to
> address libaio/attr/libcap dependencies
> 
> Hi Ting,
> 
> On Wednesday 03 July 2013 17:45:10 b28495@freescale.com wrote:
> > From: Ting Liu <b28495@freescale.com>
> >
> > Move to using the PACKAGECONFIG mechanism to select configure options
> > and dependencies. Without this the system will attempt to discover
> > various dependencies, and sometimes does so incorrectly.
> >
> > Signed-off-by: Ting Liu <b28495@freescale.com>
> > ---
> >  meta/recipes-devtools/qemu/qemu.inc |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/qemu/qemu.inc
> > b/meta/recipes-devtools/qemu/qemu.inc index 7caef6e..8be3890 100644
> > --- a/meta/recipes-devtools/qemu/qemu.inc
> > +++ b/meta/recipes-devtools/qemu/qemu.inc
> > @@ -84,6 +84,8 @@ do_install_append() {  # END of qemu-mips workaround
> >
> >  PACKAGECONFIG ??= ""
> > +PACKAGECONFIG[virtfs] = "--enable-virtfs
> > --enable-attr,--disable-virtfs,libcap attr,"
> > +PACKAGECONFIG[libaio] =
> > "--enable-linux-aio,--disable-linux-aio,libaio,"
> 
> The latter should be "aio" and not "libaio" (since "aio" is the feature
> being enabled/disabled).

Good catch. Patch v2 sent out. Thanks.

-Ting

> 
> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre

Patch

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index 7caef6e..8be3890 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -84,6 +84,8 @@  do_install_append() {
 # END of qemu-mips workaround
 
 PACKAGECONFIG ??= ""
+PACKAGECONFIG[virtfs] = "--enable-virtfs --enable-attr,--disable-virtfs,libcap attr,"
+PACKAGECONFIG[libaio] = "--enable-linux-aio,--disable-linux-aio,libaio,"
 
 # Qemu target will not build in world build for ARM or Mips
 BROKEN_qemuarm = "1"