Patchwork [meta-fsl-arm,1/4] linux-imx (3.0.35): Enable tracing support so lttng's modules are build

login
register
mail settings
Submitter Otavio Salvador
Date July 2, 2013, 7:34 p.m.
Message ID <1372793661-3955-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/52831/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - July 2, 2013, 7:34 p.m.
lttng support is enabled in Freescale test images however its modules
were not being build due lacking of tracing support in the
kernel. This patch enables the needed kernel features to allow the
modules to be build and thus making lttng usable.

Change-Id: Ifa5fd3a5206502d8b100ce6211d2cbb69b9c6f3b
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-kernel/linux/linux-imx-3.0.35/mx6dl/defconfig | 5 ++++-
 recipes-kernel/linux/linux-imx-3.0.35/mx6q/defconfig  | 4 ++++
 recipes-kernel/linux/linux-imx-3.0.35/mx6sl/defconfig | 5 +++++
 3 files changed, 13 insertions(+), 1 deletion(-)
Eric BENARD - July 2, 2013, 8:04 p.m.
Le Tue,  2 Jul 2013 16:34:18 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> lttng support is enabled in Freescale test images however its modules
> were not being build due lacking of tracing support in the
> kernel. This patch enables the needed kernel features to allow the
> modules to be build and thus making lttng usable.
> 
this patch does much more than simply enabling tracing support

Eric
Otavio Salvador - July 3, 2013, 12:56 p.m.
On Tue, Jul 2, 2013 at 5:04 PM, Eric Bénard <eric@eukrea.com> wrote:
> Le Tue,  2 Jul 2013 16:34:18 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
>> lttng support is enabled in Freescale test images however its modules
>> were not being build due lacking of tracing support in the
>> kernel. This patch enables the needed kernel features to allow the
>> modules to be build and thus making lttng usable.
>>
> this patch does much more than simply enabling tracing support

It does not; I know it has more enables there but those are result of
the new dependencies added by Freescale kernel as I just enabled the
tracing and runned savedefconfig.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Fabio Estevam - July 3, 2013, 12:58 p.m.
On Wed, Jul 3, 2013 at 9:56 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Tue, Jul 2, 2013 at 5:04 PM, Eric Bénard <eric@eukrea.com> wrote:
>> Le Tue,  2 Jul 2013 16:34:18 -0300,
>> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>>
>>> lttng support is enabled in Freescale test images however its modules
>>> were not being build due lacking of tracing support in the
>>> kernel. This patch enables the needed kernel features to allow the
>>> modules to be build and thus making lttng usable.
>>>
>> this patch does much more than simply enabling tracing support
>
> It does not; I know it has more enables there but those are result of
> the new dependencies added by Freescale kernel as I just enabled the
> tracing and runned savedefconfig.

I agree with Eric.

In this patch you added:
+CONFIG_MACH_MX6Q_HDMIDONGLE=y

,which has nothing to do with enabling trace support.
Eric BENARD - July 3, 2013, 1:01 p.m.
Le Wed, 3 Jul 2013 09:56:18 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :

> On Tue, Jul 2, 2013 at 5:04 PM, Eric Bénard <eric@eukrea.com> wrote:
> > Le Tue,  2 Jul 2013 16:34:18 -0300,
> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
> >
> >> lttng support is enabled in Freescale test images however its modules
> >> were not being build due lacking of tracing support in the
> >> kernel. This patch enables the needed kernel features to allow the
> >> modules to be build and thus making lttng usable.
> >>
> > this patch does much more than simply enabling tracing support
> 
> It does not; I know it has more enables there but those are result of
> the new dependencies added by Freescale kernel as I just enabled the
> tracing and runned savedefconfig.
> 
this one adds a new machine :
+CONFIG_MACH_MX6Q_HDMIDONGLE=y
.../...

later you enable netfilter :
+CONFIG_NETFILTER=y
+CONFIG_LLC2=y

these options doesn't seems to be dependencies for tracing support.

Eric
Otavio Salvador - July 3, 2013, 1:04 p.m.
On Wed, Jul 3, 2013 at 9:58 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Jul 3, 2013 at 9:56 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Tue, Jul 2, 2013 at 5:04 PM, Eric Bénard <eric@eukrea.com> wrote:
>>> Le Tue,  2 Jul 2013 16:34:18 -0300,
>>> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>>>
>>>> lttng support is enabled in Freescale test images however its modules
>>>> were not being build due lacking of tracing support in the
>>>> kernel. This patch enables the needed kernel features to allow the
>>>> modules to be build and thus making lttng usable.
>>>>
>>> this patch does much more than simply enabling tracing support
>>
>> It does not; I know it has more enables there but those are result of
>> the new dependencies added by Freescale kernel as I just enabled the
>> tracing and runned savedefconfig.
>
> I agree with Eric.
>
> In this patch you added:
> +CONFIG_MACH_MX6Q_HDMIDONGLE=y
>
> ,which has nothing to do with enabling trace support.

and has been added because of changes in the kernel. I didn't enable
them explicitly.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Otavio Salvador - July 3, 2013, 1:05 p.m.
On Wed, Jul 3, 2013 at 10:01 AM, Eric Bénard <eric@eukrea.com> wrote:
> Le Wed, 3 Jul 2013 09:56:18 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>
>> On Tue, Jul 2, 2013 at 5:04 PM, Eric Bénard <eric@eukrea.com> wrote:
>> > Le Tue,  2 Jul 2013 16:34:18 -0300,
>> > Otavio Salvador <otavio@ossystems.com.br> a écrit :
>> >
>> >> lttng support is enabled in Freescale test images however its modules
>> >> were not being build due lacking of tracing support in the
>> >> kernel. This patch enables the needed kernel features to allow the
>> >> modules to be build and thus making lttng usable.
>> >>
>> > this patch does much more than simply enabling tracing support
>>
>> It does not; I know it has more enables there but those are result of
>> the new dependencies added by Freescale kernel as I just enabled the
>> tracing and runned savedefconfig.
>>
> this one adds a new machine :
> +CONFIG_MACH_MX6Q_HDMIDONGLE=y
> .../...
>
> later you enable netfilter :
> +CONFIG_NETFILTER=y
> +CONFIG_LLC2=y
>
> these options doesn't seems to be dependencies for tracing support.

Ok; I will do a sync commit before and then this one.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/recipes-kernel/linux/linux-imx-3.0.35/mx6dl/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/mx6dl/defconfig
index 7193921..d709519 100644
--- a/recipes-kernel/linux/linux-imx-3.0.35/mx6dl/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.0.35/mx6dl/defconfig
@@ -6,6 +6,7 @@  CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
+CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_MODULE_FORCE_UNLOAD=y
@@ -19,6 +20,7 @@  CONFIG_MACH_MX6Q_ARM2=y
 CONFIG_MACH_MX6Q_SABRELITE=y
 CONFIG_MACH_MX6Q_SABRESD=y
 CONFIG_MACH_MX6Q_SABREAUTO=y
+CONFIG_MACH_MX6Q_HDMIDONGLE=y
 CONFIG_USB_EHCI_ARC_H1=y
 CONFIG_USB_FSL_ARC_OTG=y
 CONFIG_MXC_PWM=y
@@ -278,8 +280,9 @@  CONFIG_NLS_ASCII=m
 CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_UTF8=m
 CONFIG_MAGIC_SYSRQ=y
-CONFIG_DEBUG_FS=y
 CONFIG_SYSCTL_SYSCALL_CHECK=y
+# CONFIG_EVENT_POWER_TRACING_DEPRECATED is not set
+CONFIG_FTRACE=y
 # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
 CONFIG_CRYPTO_TEST=m
 CONFIG_CRYPTO_CCM=y
diff --git a/recipes-kernel/linux/linux-imx-3.0.35/mx6q/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/mx6q/defconfig
index 7193921..542e949 100644
--- a/recipes-kernel/linux/linux-imx-3.0.35/mx6q/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.0.35/mx6q/defconfig
@@ -6,6 +6,7 @@  CONFIG_LOG_BUF_SHIFT=14
 CONFIG_CGROUPS=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
+CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_MODULE_FORCE_UNLOAD=y
@@ -19,6 +20,7 @@  CONFIG_MACH_MX6Q_ARM2=y
 CONFIG_MACH_MX6Q_SABRELITE=y
 CONFIG_MACH_MX6Q_SABRESD=y
 CONFIG_MACH_MX6Q_SABREAUTO=y
+CONFIG_MACH_MX6Q_HDMIDONGLE=y
 CONFIG_USB_EHCI_ARC_H1=y
 CONFIG_USB_FSL_ARC_OTG=y
 CONFIG_MXC_PWM=y
@@ -280,6 +282,8 @@  CONFIG_NLS_UTF8=m
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 CONFIG_SYSCTL_SYSCALL_CHECK=y
+# CONFIG_EVENT_POWER_TRACING_DEPRECATED is not set
+CONFIG_FTRACE=y
 # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
 CONFIG_CRYPTO_TEST=m
 CONFIG_CRYPTO_CCM=y
diff --git a/recipes-kernel/linux/linux-imx-3.0.35/mx6sl/defconfig b/recipes-kernel/linux/linux-imx-3.0.35/mx6sl/defconfig
index 5bb9666..b8f88f7 100644
--- a/recipes-kernel/linux/linux-imx-3.0.35/mx6sl/defconfig
+++ b/recipes-kernel/linux/linux-imx-3.0.35/mx6sl/defconfig
@@ -4,8 +4,10 @@  CONFIG_SYSVIPC=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
 CONFIG_LOG_BUF_SHIFT=14
+CONFIG_CGROUPS=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
+CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_MODULE_FORCE_UNLOAD=y
@@ -61,6 +63,8 @@  CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
 # CONFIG_INET_LRO is not set
 # CONFIG_IPV6 is not set
+CONFIG_NETFILTER=y
+CONFIG_LLC2=y
 CONFIG_CAN=y
 CONFIG_CAN_RAW=y
 CONFIG_CAN_BCM=y
@@ -254,6 +258,7 @@  CONFIG_NLS_ISO8859_1=y
 CONFIG_NLS_UTF8=m
 CONFIG_DEBUG_FS=y
 CONFIG_SYSCTL_SYSCALL_CHECK=y
+CONFIG_FTRACE=y
 CONFIG_CRYPTO_AUTHENC=m
 CONFIG_CRYPTO_TEST=m
 CONFIG_CRYPTO_CBC=y