Patchwork [meta-fsl-ppc,2/2] usdpaa: set MACHINE_ARCH specific, same with dependency fmc

login
register
mail settings
Submitter Ting Liu
Date July 2, 2013, 3:39 a.m.
Message ID <1372736343-8839-2-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/52775/
State Superseded
Headers show

Comments

Ting Liu - July 2, 2013, 3:39 a.m.
From: Ting Liu <b28495@freescale.com>

Signed-off-by: Ting Liu <b28495@freescale.com>
Tested-by: Luo Zhenhua-B19537 <zhenhua.luo@freescale.com>
---
 recipes-tools/usdpaa/usdpaa_git.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Otavio Salvador - July 2, 2013, 12:10 p.m.
On Tue, Jul 2, 2013 at 12:39 AM,  <b28495@freescale.com> wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> Tested-by: Luo Zhenhua-B19537 <zhenhua.luo@freescale.com>
> ---
>  recipes-tools/usdpaa/usdpaa_git.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/recipes-tools/usdpaa/usdpaa_git.bb b/recipes-tools/usdpaa/usdpaa_git.bb
> index cb7b76b..93cb8ef 100644
> --- a/recipes-tools/usdpaa/usdpaa_git.bb
> +++ b/recipes-tools/usdpaa/usdpaa_git.bb
> @@ -4,6 +4,8 @@ LICENSE = "BSD & GPLv2"
>  LIC_FILES_CHKSUM = "file://Makefile;endline=30;md5=39e58bedc879163c9338596e52df5b1f"
>  PR = "r4"
>
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +

Usually PACKAGE_ARCH is the last field being set in the recipe (near
COMPATIBLE_MACHINE when it is the case). I'd move it down.

>  inherit pkgconfig
>
>  DEPENDS = "libxml2 libedit ncurses readline flib fmc"
> --
> 1.7.3.4
>
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale



--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Ting Liu - July 3, 2013, 2:14 a.m.
> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Tuesday, July 02, 2013 8:11 PM
> To: Liu Ting-B28495
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 2/2] usdpaa: set
> MACHINE_ARCH specific, same with dependency fmc
> 
> On Tue, Jul 2, 2013 at 12:39 AM,  <b28495@freescale.com> wrote:
> > From: Ting Liu <b28495@freescale.com>
> >
> > Signed-off-by: Ting Liu <b28495@freescale.com>
> > Tested-by: Luo Zhenhua-B19537 <zhenhua.luo@freescale.com>
> > ---
> >  recipes-tools/usdpaa/usdpaa_git.bb |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/recipes-tools/usdpaa/usdpaa_git.bb
> > b/recipes-tools/usdpaa/usdpaa_git.bb
> > index cb7b76b..93cb8ef 100644
> > --- a/recipes-tools/usdpaa/usdpaa_git.bb
> > +++ b/recipes-tools/usdpaa/usdpaa_git.bb
> > @@ -4,6 +4,8 @@ LICENSE = "BSD & GPLv2"
> >  LIC_FILES_CHKSUM =
> "file://Makefile;endline=30;md5=39e58bedc879163c9338596e52df5b1f"
> >  PR = "r4"
> >
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> 
> Usually PACKAGE_ARCH is the last field being set in the recipe (near
> COMPATIBLE_MACHINE when it is the case). I'd move it down.

Patch v2 sent out. Thanks for your suggestion.

> 
> >  inherit pkgconfig
> >
> >  DEPENDS = "libxml2 libedit ncurses readline flib fmc"
> > --
> > 1.7.3.4
> >
> >
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
> 
> 
> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://projetos.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/recipes-tools/usdpaa/usdpaa_git.bb b/recipes-tools/usdpaa/usdpaa_git.bb
index cb7b76b..93cb8ef 100644
--- a/recipes-tools/usdpaa/usdpaa_git.bb
+++ b/recipes-tools/usdpaa/usdpaa_git.bb
@@ -4,6 +4,8 @@  LICENSE = "BSD & GPLv2"
 LIC_FILES_CHKSUM = "file://Makefile;endline=30;md5=39e58bedc879163c9338596e52df5b1f"
 PR = "r4"
 
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 inherit pkgconfig
 
 DEPENDS = "libxml2 libedit ncurses readline flib fmc"