Patchwork [4/4] packagegroup-core-boot: used udev-cache for sysvinit

login
register
mail settings
Submitter Saul Wold
Date June 27, 2013, 10:43 p.m.
Message ID <1372372997-1604-5-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/52483/
State New
Headers show

Comments

Saul Wold - June 27, 2013, 10:43 p.m.
Enabling this by default since it does improve boot time when using sysvinit udev

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 1 +
 1 file changed, 1 insertion(+)
Paul Eggleton - June 28, 2013, 10:02 a.m.
On Thursday 27 June 2013 15:43:17 Saul Wold wrote:
> Enabling this by default since it does improve boot time when using sysvinit
> udev
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb index
> d69c41d..1e1ee8e 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -43,6 +43,7 @@ RDEPENDS_${PN} = "\
>      ${VIRTUAL-RUNTIME_init_manager} \
>      ${VIRTUAL-RUNTIME_initscripts} \
>      ${VIRTUAL-RUNTIME_dev_manager} \
> +    ${@base_contains("DISTRO_FEATURES", "systemd", "", "udev-cache", d)} \
>      ${VIRTUAL-RUNTIME_update-alternatives} \
>      ${MACHINE_ESSENTIAL_EXTRA_RDEPENDS}"

I appreciate the intention here but I'm not sure if this is really the 
appropriate place to put this; packagegroup-core-boot is supposed to only 
directly pull in the essentials required for booting. This will cause problems 
for those people using alternative device managers (e.g. busybox mdev) as 
well.

I'm not sure where this should go, but adding it to VIRTUAL-
RUNTIME_dev_manager (in the distro config?) could work. Anyone else have any 
better suggestion?

Cheers,
Paul
Ross Burton - July 1, 2013, 2:49 p.m.
On 28 June 2013 11:02, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> I appreciate the intention here but I'm not sure if this is really the
> appropriate place to put this; packagegroup-core-boot is supposed to only
> directly pull in the essentials required for booting. This will cause problems
> for those people using alternative device managers (e.g. busybox mdev) as
> well.
>
> I'm not sure where this should go, but adding it to VIRTUAL-
> RUNTIME_dev_manager (in the distro config?) could work. Anyone else have any
> better suggestion?

How about making udev RRECOMMEND udev-cache?

Ross
Paul Eggleton - July 1, 2013, 2:58 p.m.
On Monday 01 July 2013 15:49:00 Burton, Ross wrote:
> On 28 June 2013 11:02, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> > I appreciate the intention here but I'm not sure if this is really the
> > appropriate place to put this; packagegroup-core-boot is supposed to only
> > directly pull in the essentials required for booting. This will cause
> > problems for those people using alternative device managers (e.g. busybox
> > mdev) as well.
> > 
> > I'm not sure where this should go, but adding it to VIRTUAL-
> > RUNTIME_dev_manager (in the distro config?) could work. Anyone else have
> > any better suggestion?
> 
> How about making udev RRECOMMEND udev-cache?

It's not that udev-cache might not be available, rather that packagegroup-
core-boot shouldn't have any kind of reference to it. In any case unless udev 
is skipped somehow, an RRECOMMENDS on udev-cache will end up building udev 
even if you haven't selected it in VIRTUAL-RUNTIME_dev_manager so that won't 
help.

Cheers,
Paul
Ross Burton - July 1, 2013, 3:02 p.m.
On 1 July 2013 15:58, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> On Monday 01 July 2013 15:49:00 Burton, Ross wrote:
>> On 28 June 2013 11:02, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>> > I appreciate the intention here but I'm not sure if this is really the
>> > appropriate place to put this; packagegroup-core-boot is supposed to only
>> > directly pull in the essentials required for booting. This will cause
>> > problems for those people using alternative device managers (e.g. busybox
>> > mdev) as well.
>> >
>> > I'm not sure where this should go, but adding it to VIRTUAL-
>> > RUNTIME_dev_manager (in the distro config?) could work. Anyone else have
>> > any better suggestion?
>>
>> How about making udev RRECOMMEND udev-cache?
>
> It's not that udev-cache might not be available, rather that packagegroup-
> core-boot shouldn't have any kind of reference to it. In any case unless udev
> is skipped somehow, an RRECOMMENDS on udev-cache will end up building udev
> even if you haven't selected it in VIRTUAL-RUNTIME_dev_manager so that won't
> help.

I mean add a recommends to the udev binary package itself, so you'll
get udev-cache if you build udev (and keep the existing udev-selection
logic as-is).

Ross
Paul Eggleton - July 1, 2013, 3:07 p.m.
On Monday 01 July 2013 16:02:56 Burton, Ross wrote:
> On 1 July 2013 15:58, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> > On Monday 01 July 2013 15:49:00 Burton, Ross wrote:
> >> On 28 June 2013 11:02, Paul Eggleton <paul.eggleton@linux.intel.com> 
wrote:
> >> > I appreciate the intention here but I'm not sure if this is really the
> >> > appropriate place to put this; packagegroup-core-boot is supposed to
> >> > only
> >> > directly pull in the essentials required for booting. This will cause
> >> > problems for those people using alternative device managers (e.g.
> >> > busybox
> >> > mdev) as well.
> >> > 
> >> > I'm not sure where this should go, but adding it to VIRTUAL-
> >> > RUNTIME_dev_manager (in the distro config?) could work. Anyone else
> >> > have any better suggestion?
> >> 
> >> How about making udev RRECOMMEND udev-cache?
> > 
> > It's not that udev-cache might not be available, rather that packagegroup-
> > core-boot shouldn't have any kind of reference to it. In any case unless
> > udev is skipped somehow, an RRECOMMENDS on udev-cache will end up
> > building udev even if you haven't selected it in
> > VIRTUAL-RUNTIME_dev_manager so that won't help.
> 
> I mean add a recommends to the udev binary package itself, so you'll
> get udev-cache if you build udev (and keep the existing udev-selection
> logic as-is).

Right, that could work yes.

Cheers,
Paul

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index d69c41d..1e1ee8e 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -43,6 +43,7 @@  RDEPENDS_${PN} = "\
     ${VIRTUAL-RUNTIME_init_manager} \
     ${VIRTUAL-RUNTIME_initscripts} \
     ${VIRTUAL-RUNTIME_dev_manager} \
+    ${@base_contains("DISTRO_FEATURES", "systemd", "", "udev-cache", d)} \
     ${VIRTUAL-RUNTIME_update-alternatives} \
     ${MACHINE_ESSENTIAL_EXTRA_RDEPENDS}"