Patchwork [1/1] qt-x11-free: add missing DEPENDS on libglu for LSB Library Check

login
register
mail settings
Submitter Hongxu Jia
Date June 26, 2013, 2:32 a.m.
Message ID <702dd5ac09c4e06fcad0b1831217ea3416d6c764.1372213028.git.hongxu.jia@windriver.com>
Download mbox | patch
Permalink /patch/52353/
State Accepted, archived
Headers show

Comments

Hongxu Jia - June 26, 2013, 2:32 a.m.
When libglu is missing in qt-x11-free's DEPENDS, the LSB 4.1 Library
Check will fail:
...
Checking library symbols (libqt-mt.so.3)
Did not find _ZN10QGLContext10currentCtxE (unversioned) in libqt-mt.so.3
Unmangled symbol name: QGLContext::currentCtx
...

[YOCTO #4016]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 recipes-qt3/qt3/qt-x11-free_3.3.7.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - June 28, 2013, 10:50 a.m.
Hi Hongxu,

On Wednesday 26 June 2013 10:38:52 Hongxu Jia wrote:
> When libglu is missing in qt-x11-free's DEPENDS, the LSB 4.1 Library
> Check will fail:
> ...
> Checking library symbols (libqt-mt.so.3)
> Did not find _ZN10QGLContext10currentCtxE (unversioned) in libqt-mt.so.3
> Unmangled symbol name: QGLContext::currentCtx
> ...
> 
> [YOCTO #4016]
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  recipes-qt3/qt3/qt-x11-free_3.3.7.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
> b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb index a67dd63..af4fc01 100644
> --- a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
> +++ b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
> @@ -1,4 +1,4 @@
> -DEPENDS = "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext
> libxrender libxrandr libxcursor  virtual/libgl" +DEPENDS =
> "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext
> libxrender libxrandr libxcursor  virtual/libgl libglu" PROVIDES = "qt3x11"
>  PR = "${INC_PR}.1"

Merged to meta-qt3, thanks.

I noticed we didn't actually specify in the README in meta-qt3 where patches 
should be sent, I have now fixed this. In future if you have any patches for 
this layer could you please send them to the yocto@yoctoproject.org mailing 
list.

Thanks,
Paul
Hongxu Jia - June 29, 2013, 5:36 a.m.
Hi Paul,

Got it

Thanks,
Hongxu

On 06/28/2013 06:50 PM, Paul Eggleton wrote:
> Hi Hongxu,
>
> On Wednesday 26 June 2013 10:38:52 Hongxu Jia wrote:
>> When libglu is missing in qt-x11-free's DEPENDS, the LSB 4.1 Library
>> Check will fail:
>> ...
>> Checking library symbols (libqt-mt.so.3)
>> Did not find _ZN10QGLContext10currentCtxE (unversioned) in libqt-mt.so.3
>> Unmangled symbol name: QGLContext::currentCtx
>> ...
>>
>> [YOCTO #4016]
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   recipes-qt3/qt3/qt-x11-free_3.3.7.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
>> b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb index a67dd63..af4fc01 100644
>> --- a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
>> +++ b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
>> @@ -1,4 +1,4 @@
>> -DEPENDS = "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext
>> libxrender libxrandr libxcursor  virtual/libgl" +DEPENDS =
>> "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext
>> libxrender libxrandr libxcursor  virtual/libgl libglu" PROVIDES = "qt3x11"
>>   PR = "${INC_PR}.1"
> Merged to meta-qt3, thanks.
>
> I noticed we didn't actually specify in the README in meta-qt3 where patches
> should be sent, I have now fixed this. In future if you have any patches for
> this layer could you please send them to the yocto@yoctoproject.org mailing
> list.
>
> Thanks,
> Paul
>

Patch

diff --git a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
index a67dd63..af4fc01 100644
--- a/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
+++ b/recipes-qt3/qt3/qt-x11-free_3.3.7.bb
@@ -1,4 +1,4 @@ 
-DEPENDS = "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext libxrender libxrandr libxcursor  virtual/libgl"
+DEPENDS = "qt-x11-free-native freetype virtual/libx11 libxmu libxft libxext libxrender libxrandr libxcursor  virtual/libgl libglu"
 PROVIDES = "qt3x11"
 PR = "${INC_PR}.1"