Patchwork alsa-tools: Pass ACLOCAL_FLAGS so aclocal uses the right params

login
register
mail settings
Submitter Otavio Salvador
Date June 25, 2013, 5:56 p.m.
Message ID <1372182987-27781-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/52335/
State Accepted
Commit b74e632c61327b898b3b9c970cd502eb9e7e264c
Headers show

Comments

Otavio Salvador - June 25, 2013, 5:56 p.m.
The compile step ends regenerating the configure scripts included in
the source subdirs, for it to properly work we need to pass the
ACLOCAL_FLAGS or the .m4 files won't be found.

,----[ Build error ]
| ./ac3dec
| aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
| configure.in:18: warning: macro 'AM_PATH_ALSA' not found in library
| automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
| configure.in:9: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated.  For more info, see:
| configure.in:9: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_INIT_AUTOMAKE-invocation
| automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
| test/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
| configure.in:18: error: possibly undefined macro: AM_PATH_ALSA
|       If this token and others are legitimate, please use m4_pattern_allow.
|       See the Autoconf documentation.
| make: *** [all] Error 1
| ERROR: oe_runmake failed
`----

Reported-by: Rogerio Nunes <rogerio.nunes@freescale.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-multimedia/alsa/alsa-tools_1.0.26.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - June 25, 2013, 5:58 p.m.
On Tue, Jun 25, 2013 at 2:56 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The compile step ends regenerating the configure scripts included in
> the source subdirs, for it to properly work we need to pass the
> ACLOCAL_FLAGS or the .m4 files won't be found.
>
> ,----[ Build error ]
> | ./ac3dec
> | aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
> | configure.in:18: warning: macro 'AM_PATH_ALSA' not found in library
> | automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
> | configure.in:9: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated.  For more info, see:
> | configure.in:9: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_INIT_AUTOMAKE-invocation
> | automake: warning: autoconf input should be named 'configure.ac', not 'configure.in'
> | test/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> | configure.in:18: error: possibly undefined macro: AM_PATH_ALSA
> |       If this token and others are legitimate, please use m4_pattern_allow.
> |       See the Autoconf documentation.
> | make: *** [all] Error 1
> | ERROR: oe_runmake failed
> `----
>
> Reported-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Paul,

Can you please consider it for dylan? I am using it in master and
dylan for some time without issues and it does address the build
failure for me.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Patch

diff --git a/meta/recipes-multimedia/alsa/alsa-tools_1.0.26.1.bb b/meta/recipes-multimedia/alsa/alsa-tools_1.0.26.1.bb
index 24af545..a18cb46 100644
--- a/meta/recipes-multimedia/alsa/alsa-tools_1.0.26.1.bb
+++ b/meta/recipes-multimedia/alsa/alsa-tools_1.0.26.1.bb
@@ -33,7 +33,7 @@  do_configure () {
 do_compile_prepend () {
     #Automake dir is not correctly detected in cross compilation case
     export AUTOMAKE_DIR=${STAGING_DATADIR_NATIVE}/$(ls ${STAGING_DATADIR_NATIVE} | grep automake)
-    export ACLOCAL="aclocal --system-acdir=${ACLOCALDIR}/"
+    export ACLOCAL_FLAGS="--system-acdir=${ACLOCALDIR}/"
 }
 
 FILES_${PN} += "${datadir}/ld10k1"