Patchwork [RFC,v1,07/16] git: should depend on perl-native-runtime rather than perl-native

login
register
mail settings
Submitter Dexuan Cui
Date June 1, 2011, 1:18 p.m.
Message ID <06193403fa3f66c8ba416ace8fee6f10e05a4f13.1306931849.git.dexuan.cui@intel.com>
Download mbox | patch
Permalink /patch/5229/
State New, archived
Headers show

Comments

Dexuan Cui - June 1, 2011, 1:18 p.m.
Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
---
 meta/recipes-devtools/git/git.inc        |    4 ++--
 meta/recipes-devtools/git/git_1.7.5.1.bb |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Joshua Lock - June 10, 2011, 12:10 a.m.
On Wed, 2011-06-01 at 21:18 +0800, Dexuan Cui wrote:
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
> ---
>  meta/recipes-devtools/git/git.inc        |    4 ++--
>  meta/recipes-devtools/git/git_1.7.5.1.bb |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
> index c884f9c..3cdd1fa 100644
> --- a/meta/recipes-devtools/git/git.inc
> +++ b/meta/recipes-devtools/git/git.inc
> @@ -1,14 +1,14 @@
>  DESCRIPTION = "The git revision control system used by the Linux kernel developers"
>  SECTION = "console/utils"
>  LICENSE = "GPLv2"
> -DEPENDS = "perl-native openssl curl zlib expat"
> +DEPENDS = "perl-native-runtime openssl curl zlib expat"

This change made git-native fail to build for me until I installed
perl-ExtUtils-MakeMaker on my Fedora 15 workstation.

If this is expected we need to be documenting this additional host
dependency.

Tracking bug: http://bugzilla.yoctoproject.org/show_bug.cgi?id=1155

Regards,
Joshua
Dexuan Cui - June 10, 2011, 7:28 a.m.
Joshua Lock wrote:
> On Wed, 2011-06-01 at 21:18 +0800, Dexuan Cui wrote:
>> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
>> ---
>>  meta/recipes-devtools/git/git.inc        |    4 ++--
>>  meta/recipes-devtools/git/git_1.7.5.1.bb |    2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/meta/recipes-devtools/git/git.inc
>> b/meta/recipes-devtools/git/git.inc index c884f9c..3cdd1fa 100644
>> --- a/meta/recipes-devtools/git/git.inc +++
>> b/meta/recipes-devtools/git/git.inc @@ -1,14 +1,14 @@
>>  DESCRIPTION = "The git revision control system used by the Linux
>>  kernel developers"  SECTION = "console/utils" LICENSE = "GPLv2"
>> -DEPENDS = "perl-native openssl curl zlib expat"
>> +DEPENDS = "perl-native-runtime openssl curl zlib expat"
> 
> This change made git-native fail to build for me until I installed
> perl-ExtUtils-MakeMaker on my Fedora 15 workstation.
> 
> If this is expected we need to be documenting this additional host
> dependency.
> 
> Tracking bug: http://bugzilla.yoctoproject.org/show_bug.cgi?id=1155

Hi Joshua,
Thanks for reporting this!

Cc-ed Richard:
It might be inappropriate to "add perl-ExtUtils-MakeMaker to the host package requirements"?
Looks git should depend on perl-native?

I've made a patch http://git.pokylinux.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcui/distro&id=79356a51507f1872199ba38262b749277633b4d4 and I'll send the pull request.
Please review it.

Thanks,
-- Dexuan

Patch

diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
index c884f9c..3cdd1fa 100644
--- a/meta/recipes-devtools/git/git.inc
+++ b/meta/recipes-devtools/git/git.inc
@@ -1,14 +1,14 @@ 
 DESCRIPTION = "The git revision control system used by the Linux kernel developers"
 SECTION = "console/utils"
 LICENSE = "GPLv2"
-DEPENDS = "perl-native openssl curl zlib expat"
+DEPENDS = "perl-native-runtime openssl curl zlib expat"
 
 SRC_URI = "${KERNELORG_MIRROR}/software/scm/git/git-${PV}.tar.bz2 "
 S = "${WORKDIR}/git-${PV}"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
 
-EXTRA_OECONF = "--with-perl=${STAGING_BINDIR_NATIVE}/perl --without-tcltk"
+EXTRA_OECONF = "--without-tcltk"
 
 inherit autotools
 
diff --git a/meta/recipes-devtools/git/git_1.7.5.1.bb b/meta/recipes-devtools/git/git_1.7.5.1.bb
index bfdbf62..9aa2bdf 100644
--- a/meta/recipes-devtools/git/git_1.7.5.1.bb
+++ b/meta/recipes-devtools/git/git_1.7.5.1.bb
@@ -1,6 +1,6 @@ 
 require git.inc
 
-PR = "r0"
+PR = "r1"
 
 EXTRA_OECONF += "ac_cv_snprintf_returns_bogus=no ac_cv_c_c99_format=yes \
                  ac_cv_fread_reads_directories=${ac_cv_fread_reads_directories=yes} \