Patchwork [meta-fsl-arm,for,dylan] amd-gpu-x11-bin-mx51: install dev symbolic link

login
register
mail settings
Submitter Daiane Angolini
Date June 20, 2013, 8:42 p.m.
Message ID <1371760942-26330-1-git-send-email-daiane.angolini@freescale.com>
Download mbox | patch
Permalink /patch/52177/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Daiane Angolini - June 20, 2013, 8:42 p.m.
Create the .so file needed by -dev package.

Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com>
---
 recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Otavio Salvador - June 20, 2013, 8:50 p.m.
On Thu, Jun 20, 2013 at 5:42 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> Create the .so file needed by -dev package.
>
> Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com>

Applied to dylan-next.

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Javier Viguera - June 21, 2013, 8:27 a.m.
Hi Daiane,

On 20/06/13 22:42, Daiane Angolini wrote:
> +    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
> +    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so

Shouldn't this symbolic links be relative?

Something like:

ln -sf lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
ln -sf lib2dz430.so.0 ${D}${libdir}/lib2dz430.so

The rest of symbolic links under '/usr/lib' or '/lib' are relative.

-
Javier Viguera
Software Engineer
Digi InternationalĀ® Spain S.A.U.
Andrei Gherzan - June 21, 2013, 9:08 a.m.
On Fri, Jun 21, 2013 at 11:27 AM, Javier Viguera <javier.viguera@digi.com>wrote:

> Hi Daiane,
>
> On 20/06/13 22:42, Daiane Angolini wrote:
>
>> +    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
>> +    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
>>
>
> Shouldn't this symbolic links be relative?
>
> Something like:
>
> ln -sf lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
> ln -sf lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
>
> The rest of symbolic links under '/usr/lib' or '/lib' are relative.
>

I understand the idea of consistency but this doesn't make a difference -
functional I mean.
Otavio Salvador - June 21, 2013, 11:38 a.m.
On Fri, Jun 21, 2013 at 5:27 AM, Javier Viguera <javier.viguera@digi.com> wrote:
> Hi Daiane,
>
>
> On 20/06/13 22:42, Daiane Angolini wrote:
>>
>> +    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
>> +    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
>
>
> Shouldn't this symbolic links be relative?
>
> Something like:
>
> ln -sf lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
> ln -sf lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
>
> The rest of symbolic links under '/usr/lib' or '/lib' are relative.

It has no real impact but it does seem to be the best alternative for
consistency.

Daiane, can you update both patches?

Regards,

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Angolini Daiane-B19406 - June 21, 2013, 11:47 a.m.
They are right on my rootfs on target.

Do you think it makes any difference?


Daiane

-----Original Message-----
From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Javier Viguera
Sent: Friday, June 21, 2013 5:28 AM
To: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm for dylan][PATCH] amd-gpu-x11-bin-mx51: install dev symbolic link

Hi Daiane,

On 20/06/13 22:42, Daiane Angolini wrote:
> +    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
> +    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so

Shouldn't this symbolic links be relative?

Something like:

ln -sf lib2dz160.so.0 ${D}${libdir}/lib2dz160.so ln -sf lib2dz430.so.0 ${D}${libdir}/lib2dz430.so

The rest of symbolic links under '/usr/lib' or '/lib' are relative.

-
Javier Viguera
Software Engineer
Digi International(r) Spain S.A.U.
Angolini Daiane-B19406 - June 21, 2013, 11:51 a.m.
Sure (sorry for the top posting, I only have outlook and it sucks [or I donĀ“t know how to make it rules])

I will update the patches.


Thanks in advance,
Daiane
-----Original Message-----
From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Otavio Salvador
Sent: Friday, June 21, 2013 8:38 AM
To: Javier Viguera
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm for dylan][PATCH] amd-gpu-x11-bin-mx51: install dev symbolic link

On Fri, Jun 21, 2013 at 5:27 AM, Javier Viguera <javier.viguera@digi.com> wrote:
> Hi Daiane,
>
>
> On 20/06/13 22:42, Daiane Angolini wrote:
>>
>> +    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
>> +    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
>
>
> Shouldn't this symbolic links be relative?
>
> Something like:
>
> ln -sf lib2dz160.so.0 ${D}${libdir}/lib2dz160.so ln -sf lib2dz430.so.0 
> ${D}${libdir}/lib2dz430.so
>
> The rest of symbolic links under '/usr/lib' or '/lib' are relative.

It has no real impact but it does seem to be the best alternative for consistency.

Daiane, can you update both patches?

Regards,

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
Javier Viguera - June 21, 2013, 11:54 a.m.
Hi Daiane,

On 21/06/13 13:47, Angolini Daiane-B19406 wrote:
> They are right on my rootfs on target.
>
> Do you think it makes any difference?

There is no functional difference. It will work just the same.

It's a bit of style. See the difference doing one link relative (z430) 
and the other absolute (z160):

root@ccimx53js:/usr/lib# ls -l lib2dz*
       23 Jun 21  2013 lib2dz160.so -> /usr/lib/lib2dz160.so.0
       14 Jun 20 17:28 lib2dz160.so.0 -> lib2dz160.so.1
   222959 Sep 25  2011 lib2dz160.so.1
       14 Jun 21  2013 lib2dz430.so -> lib2dz430.so.0
       14 Jun 20 17:28 lib2dz430.so.0 -> lib2dz430.so.1
   285066 Sep 25  2011 lib2dz430.so.1


Normally the libs do relative symlinks. You can verify it in your 
development machine.
Angolini Daiane-B19406 - June 21, 2013, 11:59 a.m.
Thanks a lot

=D

Daiane

-----Original Message-----
From: Javier Viguera [mailto:javier.viguera@digi.com] 
Sent: Friday, June 21, 2013 8:54 AM
To: Angolini Daiane-B19406
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-arm for dylan][PATCH] amd-gpu-x11-bin-mx51: install dev symbolic link



Hi Daiane,

On 21/06/13 13:47, Angolini Daiane-B19406 wrote:
> They are right on my rootfs on target.
>
> Do you think it makes any difference?

There is no functional difference. It will work just the same.

It's a bit of style. See the difference doing one link relative (z430) and the other absolute (z160):

root@ccimx53js:/usr/lib# ls -l lib2dz*
       23 Jun 21  2013 lib2dz160.so -> /usr/lib/lib2dz160.so.0
       14 Jun 20 17:28 lib2dz160.so.0 -> lib2dz160.so.1
   222959 Sep 25  2011 lib2dz160.so.1
       14 Jun 21  2013 lib2dz430.so -> lib2dz430.so.0
       14 Jun 20 17:28 lib2dz430.so.0 -> lib2dz430.so.1
   285066 Sep 25  2011 lib2dz430.so.1


Normally the libs do relative symlinks. You can verify it in your development machine.

--
Regards,

Javier Viguera

Patch

diff --git a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb
index 2dee47a..fd972ed 100644
--- a/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb
+++ b/recipes-graphics/amd-gpu-x11-bin/amd-gpu-x11-bin-mx51_11.09.01.bb
@@ -4,7 +4,7 @@ 
 DESCRIPTION = "GPU driver and apps for x11 on mx51"
 LICENSE = "Proprietary"
 SECTION = "libs"
-PR = "r12"
+PR = "r13"
 
 # FIXME: Replace for correct AMD license
 LIC_FILES_CHKSUM = "file://usr/include/VG/openvg.h;endline=30;md5=b0109611dd76961057d4c45ae6519802"
@@ -42,6 +42,8 @@  do_install () {
     # FIXME: Fix sonames of broken libraries
     mv ${D}${libdir}/lib2dz160.so ${D}${libdir}/lib2dz160.so.0
     mv ${D}${libdir}/lib2dz430.so ${D}${libdir}/lib2dz430.so.0
+    ln -sf ${libdir}/lib2dz160.so.0 ${D}${libdir}/lib2dz160.so
+    ln -sf ${libdir}/lib2dz430.so.0 ${D}${libdir}/lib2dz430.so
 
     # FIXME: Remove unkown files
     rm -r ${D}${libdir}/libcsi.a \